Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp37842ybl; Tue, 7 Jan 2020 01:39:10 -0800 (PST) X-Google-Smtp-Source: APXvYqypnqiGNQ1tXTL6QE6TWH9p1ZfRxjENvO1V+Cn5fo6o0wme1Rv/NRM18tdzK5ApIuVMiUKt X-Received: by 2002:a05:6830:1042:: with SMTP id b2mr121203716otp.306.1578389950861; Tue, 07 Jan 2020 01:39:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578389950; cv=none; d=google.com; s=arc-20160816; b=KfDtZoqCVxbdudT1ZBO1S26A8CWu2F2yOFoMeE5Xh6LplwRQq7ickEAeAiAZhATD6I lrwC5Gea6q72tZ6Gp/UM9NJTVWuovmVD4U0CcWCL8geZQaB/OcLr1dDmzn+dEtuffT/n gxvQqjkyH+wEHgth4GkrHxgbm5BCsnqob8r/CIL8IV8x63ToGzLVbs1E2MCKnvlanBP7 BOjRv5BOSTttJIdXPeTY7Cgz9vMpcLGeaVJSJaXtACjyVoQycURrZT1Jfa8ybssd5rsf EE1NPeOSb1+9lSsg0weoMumLzzGOdB1+6mjVqunpghg5C2KazMycHudUAJJK85IwSeuU 8KAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=iOzsDiA93EEXCj5CPXGYOMKbO3hqCyKIPwigEHrxJOw=; b=gfN1m636UdafGUS4XKjRaoDgbgX+/8ubPK+Inmo/0IlX4sj4vol6AXIby3Uc65BGFm TCUwcpHdH1X7TIcWFi4m2jpBBXEkFvXAoh0CcxvajB6owp9keIoD407ItwBt6NFUmTmm ahZeOFYqmQM4RuR7z1PgTfQetff0b3f9jTLd/4xpXXbjHCdTSAZVgwH0GPH0pgoyobaA nC3Uc9cn9ODaiofsLPQ8y3hqyIpJfxfh7TKr/Vrligvgpg9Xii2ZnCnGw4Y7lqznZayb UzPd3v9YwEIIlRe7AZ+fCADuaACw2izXnYMlEKwCOe30RgdhlPuihOQjJz+3wAFw2MGS j0EA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2si30835710oti.273.2020.01.07.01.38.57; Tue, 07 Jan 2020 01:39:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727770AbgAGJiF (ORCPT + 99 others); Tue, 7 Jan 2020 04:38:05 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:8232 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726485AbgAGJiE (ORCPT ); Tue, 7 Jan 2020 04:38:04 -0500 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E0FEF457812A5B5BC153; Tue, 7 Jan 2020 17:38:02 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.439.0; Tue, 7 Jan 2020 17:37:53 +0800 From: Chen Zhou To: , CC: , , Subject: [PATCH next] drivers: net: cisco_hdlc: use __func__ in debug message Date: Tue, 7 Jan 2020 17:33:46 +0800 Message-ID: <20200107093346.99855-1-chenzhou10@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 7BIT Content-Type: text/plain; charset=US-ASCII X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Use __func__ to print the function name instead of hard coded string. BTW, replace printk(KERN_DEBUG, ...) with netdev_dbg. Signed-off-by: Chen Zhou --- drivers/net/wan/hdlc_cisco.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wan/hdlc_cisco.c b/drivers/net/wan/hdlc_cisco.c index a030f5a..d8cba36 100644 --- a/drivers/net/wan/hdlc_cisco.c +++ b/drivers/net/wan/hdlc_cisco.c @@ -75,7 +75,7 @@ static int cisco_hard_header(struct sk_buff *skb, struct net_device *dev, { struct hdlc_header *data; #ifdef DEBUG_HARD_HEADER - printk(KERN_DEBUG "%s: cisco_hard_header called\n", dev->name); + netdev_dbg(dev, "%s called\n", __func__); #endif skb_push(skb, sizeof(struct hdlc_header)); @@ -101,7 +101,7 @@ static void cisco_keepalive_send(struct net_device *dev, u32 type, skb = dev_alloc_skb(sizeof(struct hdlc_header) + sizeof(struct cisco_packet)); if (!skb) { - netdev_warn(dev, "Memory squeeze on cisco_keepalive_send()\n"); + netdev_warn(dev, "Memory squeeze on %s()\n", __func__); return; } skb_reserve(skb, 4); -- 2.7.4