Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp69506ybl; Tue, 7 Jan 2020 02:20:28 -0800 (PST) X-Google-Smtp-Source: APXvYqwsejNpFG8O6UW5ib+N3aQ+RgcR00ZpzuTGWlJQ7eK5PuG5+9i6MKhDqm39yNDxZ57kFjCO X-Received: by 2002:a9d:6f0d:: with SMTP id n13mr125783600otq.165.1578392428804; Tue, 07 Jan 2020 02:20:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578392428; cv=none; d=google.com; s=arc-20160816; b=Y6wzL8506Sbjlwpg28b1xTbp6loqHw1DHXQhAt7GrWoePx4kM9VCQobqaAwRqTStuZ GUvQms8vdUTfle/5kH9PC5e6tSKRsu9aA36OcoVNw7zypYlmyhel5mIR5M+8oW7uhfkw wUy0dP8ZnqvDl1hz4+U2wJ+kywFNX9CqSOkTz3IAG3NiSNekpP5FuYBV3/j1uLOfTiQ/ mFHisplVisCHQ7V3JDOQDVcEUtaxiISVqaQgKEo59Ln+nCaWWpymT4+Og66hI1BQMvaK ntwheT35HNg/fbWEaTmEe/vm5LS/rDIjSVUk4J7py7259KCLG2LF9aDjIpGl1Q5SJoqp //RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=4ujOCwMmSNd48tTgMYf4usU73MoBKd5XK8ydeEYBSLI=; b=yYdWW1zqCfHS56lajmbdHzlE5Q8/smlCKvF8c66DQ1W5S2Ry6WxwXXJVvN8CtjyNOI rB/bSfj6BYpILweTYx9BwZFxeW+RriKwHQlTqpp9RTDE8XxDhPF+sQMZxFdMk7KDuPZD 8n9aOGCFsyCO6XNOhImg57aw4zPAL4KVQhbytPTHSTpErllyJClb58ESNIqwe9CUy0ac LDZFKnm/q0yc331V48grxJoUVFhUAcVHBAbsPzKNXkJpxw8WV85mrNzP65QizCEyCR+x ZcjTLbavI8dUt4tAhTng793GZ8cL95bEygfXm18XOEhIVFD3JwJH06/jb7MoM5eiMn2X UxLg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n203si33804529oia.112.2020.01.07.02.20.15; Tue, 07 Jan 2020 02:20:28 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727778AbgAGKT3 (ORCPT + 99 others); Tue, 7 Jan 2020 05:19:29 -0500 Received: from foss.arm.com ([217.140.110.172]:55306 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726558AbgAGKT3 (ORCPT ); Tue, 7 Jan 2020 05:19:29 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4192A328; Tue, 7 Jan 2020 02:19:28 -0800 (PST) Received: from localhost (unknown [10.37.6.20]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B7C473F534; Tue, 7 Jan 2020 02:19:27 -0800 (PST) Date: Tue, 7 Jan 2020 10:19:26 +0000 From: Andrew Murray To: Marcel Ziswiler Cc: Thierry Reding , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pci@vger.kernel.org, Manikanta Maddireddy , Thierry Reding , Bjorn Helgaas , Jonathan Hunter , Lorenzo Pieralisi Subject: Re: [PATCH v2] PCI: tegra: Fix afi_pex2_ctrl reg offset for Tegra30 Message-ID: <20200107101924.GU42593@e119886-lin.cambridge.arm.com> References: <20200107081402.213149-1-marcel@ziswiler.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200107081402.213149-1-marcel@ziswiler.com> User-Agent: Mutt/1.10.1+81 (426a6c1) (2018-08-26) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2020 at 09:14:02AM +0100, Marcel Ziswiler wrote: > Fix AFI_PEX2_CTRL reg offset for Tegra30 by moving it from the Tegra20 > SoC struct where it erroneously got added. This fixes the AFI_PEX2_CTRL > reg offset being uninitialised subsequently failing to bring up the > third PCIe port. > > Fixes: adb2653b3d2e ("PCI: tegra: Add AFI_PEX2_CTRL reg offset as part of SoC struct") > > Signed-off-by: Marcel Ziswiler > Acked-by: Thierry Reding Reviewed-by: Andrew Murray > > --- > > Changes in v2: > - Fix recipient list concerning CC: and To: lines as suggested by > Thierry. > - Fix subject line and commit message to adhere to standard formatting > rules as suggested by Thierry. > - Add Thierry's Acked-by tag. > - Add standard Fixes tag as suggested by Andrew. > > drivers/pci/controller/pci-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index 090b632965e2..ac93f5a0398e 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -2499,7 +2499,6 @@ static const struct tegra_pcie_soc tegra20_pcie = { > .num_ports = 2, > .ports = tegra20_pcie_ports, > .msi_base_shift = 0, > - .afi_pex2_ctrl = 0x128, > .pads_pll_ctl = PADS_PLL_CTL_TEGRA20, > .tx_ref_sel = PADS_PLL_CTL_TXCLKREF_DIV10, > .pads_refclk_cfg0 = 0xfa5cfa5c, > @@ -2528,6 +2527,7 @@ static const struct tegra_pcie_soc tegra30_pcie = { > .num_ports = 3, > .ports = tegra30_pcie_ports, > .msi_base_shift = 8, > + .afi_pex2_ctrl = 0x128, > .pads_pll_ctl = PADS_PLL_CTL_TEGRA30, > .tx_ref_sel = PADS_PLL_CTL_TXCLKREF_BUF_EN, > .pads_refclk_cfg0 = 0xfa5cfa5c, > -- > 2.24.1 >