Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <cfd3a908f7e899c8199a0e34bf9ec294f9e027d3.camel@suse.de>
Subject: Re: [PATCH v2] mmc: bcm2835: Use dma_request_chan() instead
 dma_request_slave_channel()
From:   Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>, ulf.hansson@linaro.org,
        f.fainelli@gmail.com, rjui@broadcom.com, sbranden@broadcom.com
Cc:     vkoul@kernel.org, linux-mmc@vger.kernel.org,
        linux-kernel@vger.kernel.org,
        bcm-kernel-feedback-list@broadcom.com,
        linux-rpi-kernel@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org
Date:   Tue, 07 Jan 2020 11:49:43 +0100
In-Reply-To: <20200107104040.14500-1-peter.ujfalusi@ti.com>
References: <20200107104040.14500-1-peter.ujfalusi@ti.com>
Content-Type: multipart/signed; micalg="pgp-sha256";
        protocol="application/pgp-signature"; boundary="=-N+V++2Edv1iq1XaEBcoq"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-N+V++2Edv1iq1XaEBcoq
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 2020-01-07 at 12:40 +0200, Peter Ujfalusi wrote:
> dma_request_slave_channel() is a wrapper on top of dma_request_chan()
> eating up the error code.
>=20
> By using dma_request_chan() directly the driver can support deferred
> probing against DMA.
>=20
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> Hi,
>=20
> Changes since v1:
> - jump to err: instead of returning in case of EPROBE_DEFER
>=20
> Regards,
> Peter

Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>

Thanks,
Nicolas

>=20
>  drivers/mmc/host/bcm2835.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/mmc/host/bcm2835.c b/drivers/mmc/host/bcm2835.c
> index 99f61fd2a658..c3d949847cbd 100644
> --- a/drivers/mmc/host/bcm2835.c
> +++ b/drivers/mmc/host/bcm2835.c
> @@ -1393,7 +1393,17 @@ static int bcm2835_probe(struct platform_device *p=
dev)
>  	host->dma_chan =3D NULL;
>  	host->dma_desc =3D NULL;
> =20
> -	host->dma_chan_rxtx =3D dma_request_slave_channel(dev, "rx-tx");
> +	host->dma_chan_rxtx =3D dma_request_chan(dev, "rx-tx");
> +	if (IS_ERR(host->dma_chan_rxtx)) {
> +		ret =3D PTR_ERR(host->dma_chan_rxtx);
> +		host->dma_chan_rxtx =3D NULL;
> +
> +		if (ret =3D=3D -EPROBE_DEFER)
> +			goto err;
> +
> +		/* Ignore errors to fall back to PIO mode */
> +	}
> +
> =20
>  	clk =3D devm_clk_get(dev, NULL);
>  	if (IS_ERR(clk)) {


--=-N+V++2Edv1iq1XaEBcoq
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQEzBAABCAAdFiEErOkkGDHCg2EbPcGjlfZmHno8x/4FAl4UYkcACgkQlfZmHno8
x/5e3wf/eUvwQW2b9ZB6S1muHMTUNQhpNJKwE77BmeyyDodnuNKbTzeR1TyJzEws
JIMPSXnOKwuF2qvNLnpZrFTsCVmBqAY0M3U2M2Q1lIsiuWpRW0CpiHVWlMV3spHx
553nQ3mxwWXTvt1mHlJ5I6YIqivfGZSoRU6c0JuGLNZanttjfapD6BDIAy0pepdb
Xviq1Qzo5GxpLiabSs5rBPnxzZFZUtpXoLZJZv5nSW43q5xLugFxWjAY41xxFK85
AD2V6mWKd+fQ4GXZGTaw1IaRPYDODJcskngQntKuoclCSkY2/3LKn+eu0DF7STFs
lLPQIkggT59U+JX3iT3AoS6xf8NRWA==
=KfEu
-----END PGP SIGNATURE-----

--=-N+V++2Edv1iq1XaEBcoq--