Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp138152ybl; Tue, 7 Jan 2020 03:39:05 -0800 (PST) X-Google-Smtp-Source: APXvYqxRVjbmTiPyJbmrZsPB6qXBOmFb8ukg83rXY364Gm6pSvkZsKJ++ywEfYgNAfIiIbB1MhIJ X-Received: by 2002:a9d:e83:: with SMTP id 3mr25850186otj.218.1578397145384; Tue, 07 Jan 2020 03:39:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578397145; cv=none; d=google.com; s=arc-20160816; b=GfOf2C37uz51AWkmBqyHq0tYzLNB7Df48SBkGXJDf7kdn2spMDqjhIr8Pt3J7Ia2dl fMLQPCVI25C8t5OckoPtLUmoVqA8pAib0hqDswCD3Lkxan0mZBKJR5TVUVEd4bRuzOXS vlhr/nEcfl/AyoobFno391R/z7jbatVo9k0w2zFw9xG6Mi1qbThbJ8+1MF9/jF/IFWti diZqcKIMiAiQ6tguQDLSQTzEuYmcsXKZnS8g8UgBEEItO+b3mnG/YwnxEV3nm5s2wawJ KQNBw5KLnluyXDYNAZQH6ay7Ak98dzg4vY4AOd8+ORAZSQMOhrIeuuC2OomPBcNiKHXS EvVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=DRchkeBbfpXpoPDU4rLABJfItAYPhwbN4UBzSTInVco=; b=RstFI2SG8lHN8nRG/6/26fD0JSLV/tR+tTjNR/ZibbBYPVcttM3P5+TnaXmN6LJcgK 2pEMK1ub57L16S14WU+AUjjkJ91bGp9rN6Ov7dQLfULzty6evJycIE+EZV2IxVSK7KvU +QpeWnQ6ujSE6PSpu/EtBfFlf4vBNCBR/2Q5YJoL7IdW0EeVc/OgAV2V5xpIBYxEAdaw J/f4OMNyB1xDj7ioAjasup6aU1wby05M22EvzfldqL15LFkcR/T2ieYGIqxA/Ge9hyNH 58uZCJM4/Ql2Q0nXx3JreCpAwnFadkLPNAjsGpA/hlslriFx+I/BPq4ldUr5lY73K5JZ fHxA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=PwUaLm7v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p6si23545639oig.88.2020.01.07.03.38.51; Tue, 07 Jan 2020 03:39:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=PwUaLm7v; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727880AbgAGLhJ (ORCPT + 99 others); Tue, 7 Jan 2020 06:37:09 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:52724 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727664AbgAGLhI (ORCPT ); Tue, 7 Jan 2020 06:37:08 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 007Bb3Ih031529; Tue, 7 Jan 2020 05:37:03 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1578397023; bh=DRchkeBbfpXpoPDU4rLABJfItAYPhwbN4UBzSTInVco=; h=From:To:CC:Subject:Date; b=PwUaLm7vhc1r8FlRTJWufFy66U8m0B793SmevJROLewAoDC/DlN8QXKvYRyYSWPaQ Dt4RMedAx46Z2f7Xtqvm68DiIVq4Me7uaBs+LujNRtXyHb/qQTEv7jRO1KttX2Tqbk L+bo8d5lZrrir4BxxtgN+fvwz2WgPUSVYrSlDSrc= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 007Bb2Ff065450; Tue, 7 Jan 2020 05:37:03 -0600 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Tue, 7 Jan 2020 05:37:01 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Tue, 7 Jan 2020 05:37:01 -0600 Received: from feketebors.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 007BawCS104100; Tue, 7 Jan 2020 05:36:59 -0600 From: Peter Ujfalusi To: CC: , , , , , Subject: [PATCH v3] iio: adc: at91-sama5d2_adc: Use dma_request_chan() instead dma_request_slave_channel() Date: Tue, 7 Jan 2020 13:37:29 +0200 Message-ID: <20200107113729.5505-1-peter.ujfalusi@ti.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org dma_request_slave_channel() is a wrapper on top of dma_request_chan() eating up the error code. The dma_request_chan() is the standard API to request slave channel, clients should be moved away from the legacy API to allow us to retire them. Signed-off-by: Peter Ujfalusi --- Hi, Changes since v2: - Commit message updated Changes since v1: - Subject prefix is corrected to "iio: adc: at91-sama5d2_adc:" Regards, Peter drivers/iio/adc/at91-sama5d2_adc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index e1850f3d5cf3..a5c7771227d5 100644 --- a/drivers/iio/adc/at91-sama5d2_adc.c +++ b/drivers/iio/adc/at91-sama5d2_adc.c @@ -1444,10 +1444,10 @@ static void at91_adc_dma_init(struct platform_device *pdev) if (st->dma_st.dma_chan) return; - st->dma_st.dma_chan = dma_request_slave_channel(&pdev->dev, "rx"); - - if (!st->dma_st.dma_chan) { + st->dma_st.dma_chan = dma_request_chan(&pdev->dev, "rx"); + if (IS_ERR(st->dma_st.dma_chan)) { dev_info(&pdev->dev, "can't get DMA channel\n"); + st->dma_st.dma_chan = NULL; goto dma_exit; } -- Peter Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki