Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200103155458.21707-1-wenyang@linux.alibaba.com>
In-Reply-To: <20200103155458.21707-1-wenyang@linux.alibaba.com>
From:   "Rafael J. Wysocki" <rafael@kernel.org>
Date:   Tue, 7 Jan 2020 12:43:41 +0100
Message-ID: <CAJZ5v0j_0iW5k2GJGZ=REYiR29W1BGmNi-7TiXz5jwZ80+FxpQ@mail.gmail.com>
Subject: Re: [PATCH] kernel/power/snapshot.c: improve arithmetic divisions
To:     Wen Yang <wenyang@linux.alibaba.com>
Cc:     "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
        Linux PM <linux-pm@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Jan 3, 2020 at 4:55 PM Wen Yang <wenyang@linux.alibaba.com> wrote:
>
> do_div() does a 64-by-32 division. Use div64_u64() instead of
> do_div() if the divisor is u64, to avoid truncation to 32-bit.
> This change also cleans up code a tad.
>
> Signed-off-by: Wen Yang <wenyang@linux.alibaba.com>
> Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>
> Cc: Len Brown <len.brown@intel.com>
> Cc: Pavel Machek <pavel@ucw.cz>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> ---
>  kernel/power/snapshot.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/kernel/power/snapshot.c b/kernel/power/snapshot.c
> index 26b9168..8a6eaf7 100644
> --- a/kernel/power/snapshot.c
> +++ b/kernel/power/snapshot.c
> @@ -1566,9 +1566,7 @@ static unsigned long preallocate_image_highmem(unsigned long nr_pages)
>   */
>  static unsigned long __fraction(u64 x, u64 multiplier, u64 base)
>  {
> -       x *= multiplier;
> -       do_div(x, base);
> -       return (unsigned long)x;
> +       return div64_u64(x * multiplier, base);
>  }
>
>  static unsigned long preallocate_highmem_fraction(unsigned long nr_pages,
> --

Applied as 5.6 material under a new subject ("PM: hibernate: improve
arithmetic division in preallocate_highmem_fraction()"), thanks!