Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp167498ybl; Tue, 7 Jan 2020 04:12:30 -0800 (PST) X-Google-Smtp-Source: APXvYqyb6rEDKqhu1ugTp22/VU2ifktcDi0hvsyXQI4l/yf/enAyBfBTnVJ7w2ZgpDgNELyNe0/W X-Received: by 2002:a05:6830:13da:: with SMTP id e26mr421276otq.97.1578399150088; Tue, 07 Jan 2020 04:12:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578399150; cv=none; d=google.com; s=arc-20160816; b=c1FJuq9Fqq6OJ6mQQ3ikL6G218oC7j4Y2+jyYa8VwwyI0Ft3cHkOvTk3xwnWNOaokC WCMvBVfmuDkiKVBQPNi/kxoifon7Takx5/p69P4S9GnW333OlwJi8OadxTQMW/qmyu7h gy0ghE/5WNmKei96HbIgRJdUOywFQEIrfXB46miONh6Wp2Itged3nehqNupn9lsjw6Uf rZszvyO8KTckX9//WMaD18LsFPdfR0nRszv52daxoupSevLVQ7bYGPrnHoBtDCnteHU5 U2V+1oxmskgdZ3FoPleurz9rNxHXrFe8+Yt/bZUv4iAufT763ojIKf3Zxbr1e1ay6Ol9 pDgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/VmLsf/IhJB82czf+h3j5D4doTfYGFw3X7YjLYzmZUw=; b=alM+kTHHKYF4rwPg24kdAWa5rXhwpycMkQ013QEcuqcJgFeCdUWnQZX4/5GXLfoktJ oxQLOY4NuobF/sPj9a6y7PTyzfJk2rHevsqidR2FhwutyELyHCpv2K0WvDSgX+7vWGh4 yQUKcJOzOE+uYlaQzdOlnUxOo8XNaxZDmgygnFqvhnUrkn/Kzs1slDOS3hzPnkYwhaeE XDTv+7Azm9jVHal8QWumHjluC2xgMvcgsyvclT4HxYmL4wx7NtHZZTMWC/8qun5PNZyr vFxIelW7Be5narowTdm1N0gPZciUIc4YDeFwj1pdpa5lah3mJ+f/MhXhObcW6uQbBxZK Tndw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j13si37498853otq.146.2020.01.07.04.12.16; Tue, 07 Jan 2020 04:12:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727927AbgAGMJF (ORCPT + 99 others); Tue, 7 Jan 2020 07:09:05 -0500 Received: from foss.arm.com ([217.140.110.172]:56798 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726937AbgAGMJE (ORCPT ); Tue, 7 Jan 2020 07:09:04 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4FA3231B; Tue, 7 Jan 2020 04:09:04 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id CC9BA3F534; Tue, 7 Jan 2020 04:09:03 -0800 (PST) Date: Tue, 7 Jan 2020 12:09:02 +0000 From: Mark Brown To: Sameer Pujar Cc: jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH] regmap: add iopoll-like atomic polling macro Message-ID: <20200107120902.GC4877@sirena.org.uk> References: <1578392889-16587-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GPJrCs/72TxItFYR" Content-Disposition: inline In-Reply-To: <1578392889-16587-1-git-send-email-spujar@nvidia.com> X-Cookie: Will Rogers never met you. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --GPJrCs/72TxItFYR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jan 07, 2020 at 03:58:09PM +0530, Sameer Pujar wrote: > This patch adds a macro 'regmap_read_poll_timeout_atomic' that works > similar to 'readx_poll_timeout_atomic' defined in linux/iopoll.h; This > is atomic version of already available 'regmap_read_poll_timeout' macro. In general regmap really can't be used in atomic contexts - we do have options to configure a regmap so it can be used there but they're not the default. It'd be better if the comment mentioned this and warned against use with normal regmaps so people are less likely to try to use this in an atomic context when the regmap doesn't support that. --GPJrCs/72TxItFYR Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4UdN0ACgkQJNaLcl1U h9DYeAf9GaS7jI51qX2g+IBgjs6DjJVcyUu7LnhBIzIIAb9aY3ggw4kxK5cXwz2Z TcbCCMz8vy4xdiW4DMTF/FZH7m1poO6cHqImuFDBDm21Jiutn4UOgXZyERRuGe0W QTGNOPukvUCjynzfuW9cYh9TxV+SbICDzAhOw/35cLoakSme8PfMdjCB2BjPzcvt nmiqo9aQu7MIvTM9ln1P8CDGykJhZpFr30i/Ney0gYKs+/OrOEqmMiIazWDFlSrK ZVlPTOWDPECaB3zznmiy+Amn9c33tQjtwGtwSUP5NEhslzLzCJ12/xgufXtyz6DA 72ABc7At57aP58stNmyes0JFsrd4hQ== =gQir -----END PGP SIGNATURE----- --GPJrCs/72TxItFYR--