Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp195319ybl; Tue, 7 Jan 2020 04:41:45 -0800 (PST) X-Google-Smtp-Source: APXvYqzzBUpGmnT+pfXkA8awG/aBFPWy61B4eKAT6ZBpBMq8+wLpkvXdrE+FuHdWRYjvvVy97VbV X-Received: by 2002:a9d:6a5a:: with SMTP id h26mr124751096otn.103.1578400905549; Tue, 07 Jan 2020 04:41:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578400905; cv=none; d=google.com; s=arc-20160816; b=VGYK1jLD0lJc+YC4JemjybH+JwiKnjL1UiKRP4PgQQDp6yVkpnXleFNvmxr/zTG/Ew Gq02XJHxD7fRtS/CCof2SArr+mKs0P3xkmGRxv2MuynBBIFsoyb9BdVSXKpmjZ4E4c/S WtVgWy/38oawD/YrdWNKNc/3WG2n2CoyjzzkUWQgTZhhJ9FQwM/1t1dnB8XXW5jhTA9u fDUnbbNcDy+lTrsN4m64Z6VRlXj7LygRyVfsI+Onv9r3+sOoITysayH4Y4QN6rLOgEfH A+Tc55Rw6kjYt5pIrqhcO85dnNW1Qn1LHUrkGNTfqGyuWokpS+N+Ljo4JXGLr48NwCIw 9ZOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :date:message-id:mime-version:references:in-reply-to:subject:cc:to :from; bh=AKbqWXt6tus+RjyhQVNrtBcDUbM9QcEwFDgkbLAeWGc=; b=uDb3FyntTEB3zAomIx1WhmHAo5jCxt9LEV0/S0gCBo5KVhSrf9QugjS/g4NO6h6WLb J2zvYIygIt7tRnHdaqu8fk8f+JEHeRGR5COY24R1sT2ImGV8UdttIaDKkzE/mL03A/Dc EhGUoswcagxKsbQTuUVrUMEng3/vjMVJOMeoUzC/V2LtAjOlAh9yr4saywEDpc9nEXF7 pGPmBZxWOV9hgAM9fBC8fQqS/AjR8YLrO/dBvxpo7xsA2h9qghTPcjE9Rj83psDxgnM5 RzInvDiY2vmSrBf5lLDRL1DpYPr8oMRINE5fQhW47ZATjkd5yGMBaSNaAM+Cbmc0sWjC tdNQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=M+Hb5JXo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e13si31486810otp.164.2020.01.07.04.41.28; Tue, 07 Jan 2020 04:41:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=M+Hb5JXo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728251AbgAGMj1 (ORCPT + 99 others); Tue, 7 Jan 2020 07:39:27 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:11744 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728247AbgAGMjZ (ORCPT ); Tue, 7 Jan 2020 07:39:25 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 07 Jan 2020 04:39:07 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 07 Jan 2020 04:39:24 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 07 Jan 2020 04:39:24 -0800 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 7 Jan 2020 12:39:24 +0000 Received: from [192.168.22.23] (10.124.1.5) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Tue, 7 Jan 2020 12:39:22 +0000 From: Thierry Reding To: Dmitry Osipenko CC: Thierry Reding , Jonathan Hunter , Laxman Dewangan , "Mikko Perttunen" , Wolfram Sang , , , Subject: Re: [PATCH v3 9/9] i2c: tegra: Check DMA completion status in addition to left time In-Reply-To: <20200106010423.5890-10-digetx@gmail.com> References: <20200106010423.5890-10-digetx@gmail.com> X-NVConfidentiality: public MIME-Version: 1.0 Message-ID: <72761d8598d248fbab872ad844b14aab@HQMAIL105.nvidia.com> Date: Tue, 7 Jan 2020 12:39:22 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1578400747; bh=AKbqWXt6tus+RjyhQVNrtBcDUbM9QcEwFDgkbLAeWGc=; h=X-PGP-Universal:From:To:CC:Subject:In-Reply-To:References: X-NVConfidentiality:MIME-Version:Message-ID:Date:Content-Type: Content-Transfer-Encoding; b=M+Hb5JXo5xPCFJvY6u72VG77v1ZutehPjDiEnyqQ4rP1Nf6hKHMJi34QoxLAhUK3+ 6sL7+1YLWPSMYUlcXsWVDSvw4mUQpAK5h/xWasBfKgezNSDxZrNYZOnjjy+kjBcYKH YiIEjxEKewypYO3/HWiDt1p9G64Nrvk3En1gcAo+8jDU6FVNcs9orkuVmM52cYReT9 bnB2ovNFkYZEmLWOtMT+yMAVOjSygnZmeUmDoEWbg7hHcJjg/D9OM0yGOneeJgnghz pA7zB+Xvw2hbXE4YQ31Q9UXB0xMM1u4qhKnZcbYIDYqBinx0OhH0LUW7zlzUW8VzWw 2QZwR8cNm7NtA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Jan 2020 04:04:23 +0300, Dmitry Osipenko wrote: > It is more robust to check completion status in addition to the left time > in a case of DMA transfer because transfer's completion happens in two > phases [one is ISR, other is tasklet] and thus it is possible that DMA is > completed while I2C completion awaiting times out because of the deferred > notification done by the DMA driver. The DMA completion status becomes > 100% actual after DMA synchronization. This fixes spurious DMA timeouts > when system is under load. > > Signed-off-by: Dmitry Osipenko > --- > drivers/i2c/busses/i2c-tegra.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Tested-by: Thierry Reding