Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Sriram Dash" <sriram.dash@samsung.com>
To:     "'Jose Abreu'" <Jose.Abreu@synopsys.com>, <netdev@vger.kernel.org>
Cc:     "'Joao Pinto'" <Joao.Pinto@synopsys.com>,
        "'Giuseppe Cavallaro'" <peppe.cavallaro@st.com>,
        "'Alexandre Torgue'" <alexandre.torgue@st.com>,
        "'David S. Miller'" <davem@davemloft.net>,
        "'Maxime Coquelin'" <mcoquelin.stm32@gmail.com>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>,
        "'Heiko Stuebner'" <heiko@sntech.de>,
        "'kernelci . org bot'" <bot@kernelci.org>,
        "'Florian Fainelli'" <f.fainelli@gmail.com>
In-Reply-To: <5764e60da6d3af7e76c30f63b07f1a12b4787918.1578400471.git.Jose.Abreu@synopsys.com>
Subject: RE: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
Date:   Tue, 7 Jan 2020 18:21:52 +0530
Message-ID: <014201d5c559$3e6204b0$bb260e10$@samsung.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Language: en-in
Thread-Index: AQFZUtiDrXKRSclDK/XtxWw9Crh9QgFfdnd3qM0QNJA=
Content-Type: text/plain; charset="utf-8"
CMS-TYPE: 105P
References: <CGME20200107123550epcas5p2d1914646e71e0ff0095b4a14eb5e1551@epcas5p2.samsung.com>
        <5764e60da6d3af7e76c30f63b07f1a12b4787918.1578400471.git.Jose.Abreu@synopsys.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> From: Jose Abreu <Jose.Abreu@synopsys.com>
> Subject: [PATCH net] net: stmmac: Fixed link does not need MDIO Bus
> 
> When using fixed link we don't need the MDIO bus support.
> 
> Reported-by: Heiko Stuebner <heiko@sntech.de>
> Reported-by: kernelci.org bot <bot@kernelci.org>
> Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms
> without PHY")
> Signed-off-by: Jose Abreu <Jose.Abreu@synopsys.com>

Acked-by: Sriram Dash <Sriram.dash@samsung.com>

> 
> ---
> Cc: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> Cc: Alexandre Torgue <alexandre.torgue@st.com>
> Cc: Jose Abreu <joabreu@synopsys.com>
> Cc: "David S. Miller" <davem@davemloft.net>
> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>
> Cc: netdev@vger.kernel.org
> Cc: linux-stm32@st-md-mailman.stormreply.com
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: kernelci.org bot <bot@kernelci.org>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: Sriram Dash <sriram.dash@samsung.com>
> ---
>  drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> index cc8d7e7bf9ac..4775f49d7f3b 100644
> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
> @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device
> *pdev,  static int stmmac_dt_phy(struct plat_stmmacenet_data *plat,
>  			 struct device_node *np, struct device *dev)  {
> -	bool mdio = false;
> +	bool mdio = !of_phy_is_fixed_link(np);
>  	static const struct of_device_id need_mdio_ids[] = {
>  		{ .compatible = "snps,dwc-qos-ethernet-4.10" },
>  		{},
> --
> 2.7.4