Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     airlied@linux.ie, daniel@ffwll.ch, jani.nikula@linux.intel.com,
        joonas.lahtinen@linux.intel.com, matthew.auld@intel.com,
        rodrigo.vivi@intel.com, tvrtko.ursulin@intel.com,
        ville.syrjala@linux.intel.com, yuehaibing@huawei.com
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <20200107135014.36472-1-yuehaibing@huawei.com>
Cc:     intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
References: <20200107135014.36472-1-yuehaibing@huawei.com>
Message-ID: <157840520192.2273.1930989415602076960@skylake-alporthouse-com>
User-Agent: alot/0.6
Subject: Re: [PATCH -next] drm/i915: Add missing include file <linux/math64.h>
Date:   Tue, 07 Jan 2020 13:53:21 +0000
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting YueHaibing (2020-01-07 13:50:14)
> Fix build error:
> ./drivers/gpu/drm/i915/selftests/i915_random.h: In function i915_prandom_u32_max_state:
> ./drivers/gpu/drm/i915/selftests/i915_random.h:48:23: error:
>  implicit declaration of function mul_u32_u32; did you mean mul_u64_u32_div? [-Werror=implicit-function-declaration]
>   return upper_32_bits(mul_u32_u32(prandom_u32_state(state), ep_ro));
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Fixes: 7ce5b6850b47 ("drm/i915/selftests: Use mul_u32_u32() for 32b x 32b -> 64b result")

While technically true, that doesn't explain why it only just started
appearing on -next.
-Chris