Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp388578ybl; Tue, 7 Jan 2020 07:52:29 -0800 (PST) X-Google-Smtp-Source: APXvYqzgwDIkAOf+Id1un/KWlCqvjIDg9Agnzc2fC7dyA0L3x47tKvhlk1HA4QqP+eGrId32TXij X-Received: by 2002:a9d:6b06:: with SMTP id g6mr397731otp.93.1578412349074; Tue, 07 Jan 2020 07:52:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578412349; cv=none; d=google.com; s=arc-20160816; b=yvWDh2qcPFHl5C6I/t1mukpSIUP8CIJaLaheLdI1bwbwuL8T9rVq8LRJv35gUHwGcv hy7xilSbWlCwY1MwtBz2vaokXIJic80FzIyTjwbQrAnhRTsBjaDepq8zSo8pnQV+aKTZ aN1YXAx2jwYHcDeJ+71VDVuHQc0nXoJW3MNTa3R8jG6EK1u4oORx/IaBxhn92VXXuTUe T435T41cp5fPEUlk11gMqldt2GUtJK4ihed0NRaFogBLLaNYohV0STUpgtpKU+q5wQjL AZTXth4+TTWgbnm0bW+knW3E75kpuNsRyEZhMYttSpKxvOOCAP1gn0onhHvRh94U82Ra UzmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=J6LXMJUE1RUraKI8sOLtnlOpChltycjVhd5XuyF/q5Q=; b=sAf+wIWtYdheLGtXdnHXv32lVPSreK6AVWpyPJLPsr9akWSfICgTctPKaMi21rn8lp rkmvyqzAC9wyq+/YUU7eLLQVm2BzUoLAYlzcaQ622/EsX/L4Uyex8ovh57Ukj9BHe5AB Jqz8iq/FsbC/NnTGFZWkuPznp1DRSqJsMxb67j6xzmHVOdhRpPhciSYclVwuonAYpNd2 lJsiBNtxlewEPzteZQK5fIWKETdw773d1kf9HzoP/Mth0XSfeAi3PigJ+uekFn9TZAG4 bjvqPoddrZjeRnffB8K2aftVFhvMd9+9f0vncW4Q67arJtnJdf5xOFieT0IVluSuLX5W W6zw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="q/nQ+GgR"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x207si132902oif.30.2020.01.07.07.52.16; Tue, 07 Jan 2020 07:52:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b="q/nQ+GgR"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728440AbgAGPvO (ORCPT + 99 others); Tue, 7 Jan 2020 10:51:14 -0500 Received: from mail-qk1-f194.google.com ([209.85.222.194]:41622 "EHLO mail-qk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728406AbgAGPvN (ORCPT ); Tue, 7 Jan 2020 10:51:13 -0500 Received: by mail-qk1-f194.google.com with SMTP id x129so43036265qke.8 for ; Tue, 07 Jan 2020 07:51:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=J6LXMJUE1RUraKI8sOLtnlOpChltycjVhd5XuyF/q5Q=; b=q/nQ+GgRjArznKrQtHLZOTr6ff4gY7w4rh2bntrSCShHJWzUz7Zt/1ZrZEQvJx3YdU Ig0XcK7tB8xrK36EyTyF1sXN7gJOuMu3PnrVKXefm0QYblHfxD2ilqIZPUCP0smQiXuK vc0l+6ceMUifn18DgjznmXga4M7kvbkeKKdoVJO2sBuh3M7SlVBoOLeY0tpB4MyrcQVh G9wiuM3TLe7Tl/pJiPVHB929ysBIOm4I7Oomun9NeblsZ5DnZOElKEKQxIieCw3vSELB TekpMYnzH7oNPR/JC9YqLPSf9Itt3HYjDrUtpm0oly+DongVRbt4fMe0bIyoTpELXKol vHMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=J6LXMJUE1RUraKI8sOLtnlOpChltycjVhd5XuyF/q5Q=; b=tnR1EDx/+WGwFE7MFgexMqc05Oh/UZhfDvaz5oXfZeGc3vNuBg4EYSHZ+pVjFtkWtL fgBp2OckBD212uCpsmohHu3uOmxrWWxFYiJ43SJDm9eezPFJlUim397GWqLvuxPisYOM 5PRCte4CXeoW21NF/C287eI5pSHj8rgEceoxjaGkEcu/wff4Dkef/l+bPIi4NyGc4JH1 OTtjzz0oquMMzMq02b1P7NUVtMtCFXW4K75nQeHIdsUSate2w5hxoebzlsNzEL3JWHqS Zo7vaMXkGeThs4g9T8bRhTaLfv+TW0Y3RT/h0sgQRo/lr4VoV2fxPRErCt8YTU39V2XU 16aQ== X-Gm-Message-State: APjAAAWYg5bJAW7C7hdO0E5oKNYa1fWRKgTpBI0ixfj1ybBvLL6WaeRN O/rwCsfthNW4KhF+BWouPEQ= X-Received: by 2002:a05:620a:12d5:: with SMTP id e21mr88823093qkl.44.1578412272430; Tue, 07 Jan 2020 07:51:12 -0800 (PST) Received: from localhost ([2620:10d:c091:500::2:4305]) by smtp.gmail.com with ESMTPSA id b81sm22507306qkc.135.2020.01.07.07.51.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2020 07:51:11 -0800 (PST) Date: Tue, 7 Jan 2020 07:51:10 -0800 From: Tejun Heo To: mateusznosek0@gmail.com Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH] fs/kernfs/dir.c: Clean code by removing always true condition Message-ID: <20200107155110.GA2677547@devbig004.ftw2.facebook.com> References: <20191230191628.21099-1-mateusznosek0@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191230191628.21099-1-mateusznosek0@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 30, 2019 at 08:16:28PM +0100, mateusznosek0@gmail.com wrote: > From: Mateusz Nosek > > Previously there was an additional check if variable pos is not null. > However, this check happens after entering while loop and only then, > which can happen only if pos is not null. > Therefore the additional check is redundant and can be removed. > > Signed-off-by: Mateusz Nosek Acked-by: Tejun Heo Greg, can you please route this one? Thanks. -- tejun