Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp459449ybl; Tue, 7 Jan 2020 09:05:13 -0800 (PST) X-Google-Smtp-Source: APXvYqy9GWp7YroJGNqvmipr/fNnra3b3FjxE53/NEyZrJ9ajCnLI+zTLsx6Zy4xU8hsCiucUv2u X-Received: by 2002:aca:490e:: with SMTP id w14mr431043oia.67.1578416713829; Tue, 07 Jan 2020 09:05:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578416713; cv=none; d=google.com; s=arc-20160816; b=MKJMSTeHM6Q2O6gFolkGn6AKHCpgQwbwOwplHpxgulY3Jmp8wjkiZVcMbuDnO2Rl1D AO4C0U89KeWff5vjOzgFMv3Xd2wigSHU0q8d6ubjncjhdeJQ5ubm+aFhCIVvAaTtTvre WqITkwt30k1xKg3J2N/ODgwW9lbdInbUPsT+bP4tVS6siCe5vXmLZBdU+KpBkcVDiqWK gFB54bdpeM5d+Z4L7pcKsxSRD0OMhhBiouIXpphtfLQYGwTUjs+joSrxRQD09ZZeu1L2 AFapa2HTPo48/9tyo9UIzGImbtoCP3UxUJ4KT7jA9xrtwnH+0Kdjsd7fGpumAM+NPjgF vO0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=yuCPGN5ltIi9ToyvfT1B3Z6meGbkDm5bTI9RM16HMkE=; b=P7wonq/IBqjNk9q75AY/TiL07Xe31dk6SkgiKOTnLzvGO5r/wd6u7F+ngdA8yFt50o TM1jDYIF7USiQIyhOAdTB4eXWOAwtacrvK5dn0S71H8B3z1T8PAuEDPQ5z38+tpVk/tA jYXFHeqL37FiL6xMGQC9JLMriaun+8Nn64q8qw8BbLEr5djNP8FBT2US39ymw3qq5rGl MSFMAxbxXztY6qE0wziQ271mIcwX4ozFihRpjzRl1nOjhUbxGCuVnwlf4Bj9PYsvOvpk TSGaX+1pbfuE3r55DZea55pfVT3S2vMCXpFf7Mo8oWcf7d5kBEHqrCPz4JeMlfggGfww 9oEg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=APnBX3xi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s64si243804oig.147.2020.01.07.09.05.00; Tue, 07 Jan 2020 09:05:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=APnBX3xi; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728440AbgAGRDL (ORCPT + 99 others); Tue, 7 Jan 2020 12:03:11 -0500 Received: from mail-io1-f44.google.com ([209.85.166.44]:42956 "EHLO mail-io1-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728427AbgAGRDK (ORCPT ); Tue, 7 Jan 2020 12:03:10 -0500 Received: by mail-io1-f44.google.com with SMTP id n11so29032iom.9 for ; Tue, 07 Jan 2020 09:03:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yuCPGN5ltIi9ToyvfT1B3Z6meGbkDm5bTI9RM16HMkE=; b=APnBX3ximAuUIBEX8AS2/wvamE1ubhqqBZ35sIxAgsPOFrL+BKe4onVJgFGlUw8I1c SdoZd7YXYjIyCgQp+yjME3Hx3vmy62nST5v7xHnhMOfaELWASv3RbpgKBjCHHlb2Sb+H tFZzexpa4gk2JeTo4geqQrpugmuU+26zTI/lbgFiyVWD/RtYH/PHF9tjEGxNvDtAqNPn 8PXKQ7IvcaTinwdDieVmLdnUdpPaywsYtaxpGxgfw/7Kxd+JgN3JB8n7vTstfTPRf2J2 wZJlKDhIwPGbSp65yY5mIV7TpNwB2vCPp/WSsKzuYR5CD3igyPVw7XlylS6fqqNXsSy8 2x8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yuCPGN5ltIi9ToyvfT1B3Z6meGbkDm5bTI9RM16HMkE=; b=Kije+rXUM0BSAiM/o3xJRjiFwmz+Xjo1afm4xtGuBAxLF55nNxeOwjew57NTS7fvso sDODTE9OpzRZh3y8Sv+Dy862p4/YtaO3xFxb5e4X2JJOwSt1ssAijYOhc3QbT3zCxpph qQp1J+WARrcxjieM5rBU7LnW6w6gLy+6dcXhpozzQfEI7sS6hPWmmO/j9vJmRNJ4Ntx7 rPsZKJY3JlyxN+p12KnJvEpu8iOPOMEKHmSWLLbiPWuDkcpKMy7ZRLejR0byP/3MfUa8 D5gIX1kAbDZy8HvEO8owEcJjbip+cJUj9E+DSnmMAGNQlL25WhioB2aLMKQM31vZhcws SskQ== X-Gm-Message-State: APjAAAWIx9tHtkbN0rAKn9vRdi39BZEWvygkChS+eP60N2yRYEC3GrsM p/6BX2fkh58BUK5u1GVuxMQH6QV4RJA= X-Received: by 2002:a6b:7201:: with SMTP id n1mr64850957ioc.37.1578416589140; Tue, 07 Jan 2020 09:03:09 -0800 (PST) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id 75sm48079ila.61.2020.01.07.09.03.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jan 2020 09:03:08 -0800 (PST) Subject: Re: [PATCH -next] io_uring: Remove unnecessary null check To: YueHaibing , viro@zeniv.linux.org.uk Cc: linux-fsdevel@vger.kernel.org, io-uring@vger.kernel.org, linux-kernel@vger.kernel.org References: <20200107142244.41260-1-yuehaibing@huawei.com> From: Jens Axboe Message-ID: <4373ff3f-686c-8e82-af5c-8225ae16da41@kernel.dk> Date: Tue, 7 Jan 2020 10:03:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200107142244.41260-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/7/20 7:22 AM, YueHaibing wrote: > Null check kfree is redundant, so remove it. > This is detected by coccinelle. Applied, thanks. -- Jens Axboe