Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp497631ybl; Tue, 7 Jan 2020 09:44:35 -0800 (PST) X-Google-Smtp-Source: APXvYqzEdaxn+ypO+bvqE7gnNpstnBuVSa+N5uA+tgGwqj9Az3JgyNH8A9TU7ZZMg1X58Lf2aIEg X-Received: by 2002:a9d:6396:: with SMTP id w22mr972172otk.364.1578419075416; Tue, 07 Jan 2020 09:44:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578419075; cv=none; d=google.com; s=arc-20160816; b=JaewyxlX4+MQ2jMAimDnuguns0m2NUv2XKuCR9mlEXQGCfhIqautXtDINPZtNYjbSP vU5RSVnt9DHKKR8z6QrTuwUD/AMEWjALzRbvFI4VExlE20p3PlvqFynJj8BWcGCyroY3 yOIN0wYQGnqdqzLbIFdYPSkdT4V89BU+L3XLhe48o0y4GxQuhWrobar8hMumARaPe18a EjE/2rZJbLulnChhk/xBCnRXJGetcaAOKvEk+YEKuQkURvG2TJqsOj6t1JAmENa+Pz07 0s7aYax/acxUhQ4l9VKFAd4JQL0VKNTLZQG9+ZHoUEOTKZwKqr93iLiIWWz7U4cJQvu+ sASg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:in-reply-to :content-disposition:mime-version:references:subject:cc:to:from:date; bh=0MqRT+az8++C0KadiFZgpT9BNPi+aE7xq64bR4bo0SA=; b=X5Y3/0ZBRgUN7uNxC5bOEK0Q3TRGJdh7CEnM+y78w1OVrOE5I4lgLtkGJG2n2CTsVa zwYG2SgXyUMBJeDbTrGpHw8kLEFv10pdsBwXwT2WjqbsBZRkRgnQzhQiv1kpuSe7Sseq QEmSVSsvAOrVDSZSsa9/wnsaH0vd0T/jLcL5rQjHqO+m8d7mZ5j55kecHlVLJSonknMf Cl5xnG0LJU20cX7J9aw3Fk1SA/EFcM85ZsmmM3hDw6WVEjHfhJ+IIIrkeq3ejCUrNQ+a 9NYdya/vbYZ8Ht/TIswh9BtLUijbbeqnHmIKOz52T2DYFhe9dxEKxsruOPrVOf8kRYBR a7tg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 101si203745otm.168.2020.01.07.09.44.22; Tue, 07 Jan 2020 09:44:35 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728494AbgAGRnE (ORCPT + 99 others); Tue, 7 Jan 2020 12:43:04 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:25214 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728344AbgAGRnE (ORCPT ); Tue, 7 Jan 2020 12:43:04 -0500 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 007HeVsZ091947 for ; Tue, 7 Jan 2020 12:43:03 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2xb8p0j8pe-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 07 Jan 2020 12:43:03 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 7 Jan 2020 17:43:00 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 7 Jan 2020 17:42:58 -0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 007Hgv1O32178408 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 7 Jan 2020 17:42:57 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E77094C044; Tue, 7 Jan 2020 17:42:56 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6F66E4C040; Tue, 7 Jan 2020 17:42:56 +0000 (GMT) Received: from osiris (unknown [9.145.85.21]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 7 Jan 2020 17:42:56 +0000 (GMT) Date: Tue, 7 Jan 2020 18:42:55 +0100 From: Heiko Carstens To: Anshuman Khandual Cc: linux-mm@kvack.org, Vasily Gorbik , Christian Borntraeger , Martin Schwidefsky , Collin Walling , Gerald Schaefer , Philipp Rudo , Mike Rapoport , Andrew Morton , linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/memblock: Define memblock_physmem_add() References: <1578283835-21969-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1578283835-21969-1-git-send-email-anshuman.khandual@arm.com> X-TM-AS-GCONF: 00 x-cbid: 20010717-0020-0000-0000-0000039E955B X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 20010717-0021-0000-0000-000021F5F24D Message-Id: <20200107174255.GB4684@osiris> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.138,18.0.572 definitions=2020-01-07_06:2020-01-07,2020-01-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 impostorscore=0 mlxscore=0 clxscore=1011 phishscore=0 spamscore=0 priorityscore=1501 suspectscore=1 bulkscore=0 adultscore=0 mlxlogscore=906 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-2001070140 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 06, 2020 at 09:40:35AM +0530, Anshuman Khandual wrote: > On s390 platform memblock.physmem array is being built by directly calling > into memblock_add_range() which is a low level function not intended to be > used outside of memblock. Hence lets conditionally add helper functions for > physmem array when HAVE_MEMBLOCK_PHYS_MAP is enabled. Also use MAX_NUMNODES > instead of 0 as node ID similar to memblock_add() and memblock_reserve(). > Make memblock_add_range() a static function as it is no longer getting used > outside of memblock. > > Cc: Heiko Carstens > Cc: Vasily Gorbik > Cc: Christian Borntraeger > Cc: Martin Schwidefsky > Cc: Collin Walling > Cc: Gerald Schaefer > Cc: Philipp Rudo > Cc: Mike Rapoport > Cc: Andrew Morton > Cc: linux-s390@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Anshuman Khandual > --- > Only build tested for s390, will appreciate if some one can give it a try > on a real system. Acked-by: Heiko Carstens