Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200107130903.14421-1-benjamin.gaignard@st.com>
 <20200107130903.14421-3-benjamin.gaignard@st.com> <99576d0367241bff637e82dddca839c40f672d86.camel@hadess.net>
In-Reply-To: <99576d0367241bff637e82dddca839c40f672d86.camel@hadess.net>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 7 Jan 2020 12:02:52 -0600
Message-ID: <CAL_JsqLGJehgW6c=GbyFSV8hL+WsUEkRzEBO0_kEka-d2nQ8pw@mail.gmail.com>
Subject: Re: [PATCH 2/2] dt-bindings: touchscreen: Convert Goodix touchscreen
 to json-schema
To:     Bastien Nocera <hadess@hadess.net>
Cc:     Benjamin Gaignard <benjamin.gaignard@st.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Linux Input <linux-input@vger.kernel.org>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Yannick Fertre <yannick.fertre@st.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 7, 2020 at 7:38 AM Bastien Nocera <hadess@hadess.net> wrote:
>
> On Tue, 2020-01-07 at 14:09 +0100, Benjamin Gaignard wrote:
> > Convert the Goodix binding to DT schema format using json-schema
>
> I don't have an opinion on the migration itself, but this really should
> not lose any of the descriptions that were in the old text file.

To some extent, yes. Any information specific to the device should be.
Anything generic can be dropped. I see 2 cases that should be kept:

> > - - reg                       : I2C address of the chip. Should be
> > 0x5d or 0x14

'I2C address of the chip' can be dropped as that's every 'reg'
property for I2C devices. The addresses can be expressed as
constraints.

> > - - irq-gpios         : GPIO pin used for IRQ. The driver uses the
> > -                       interrupt gpio pin as output to reset the
> > device.

Also useful info.

Rob