Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp17419ybl; Tue, 7 Jan 2020 13:12:42 -0800 (PST) X-Google-Smtp-Source: APXvYqxbAfEs5u+hebf2sagJSlnrdrFj8ChHuoqRRc21BGJetLTSFngya801f4xE9jHv44q/ba6y X-Received: by 2002:aca:c38c:: with SMTP id t134mr307035oif.175.1578431562751; Tue, 07 Jan 2020 13:12:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578431562; cv=none; d=google.com; s=arc-20160816; b=nwywHLR4l8MMcEFoOFI6FBAuP4AQsRPAPj711b2cM1lgICnfRItyQ1b+mxNUf92UuK ijL4xkMOZYRwXZGRHi8zKVzOfsOfylh4rxOZ43FI97CvFlXYjt5WRewrKlqXShw4om8E 0ZXxMnIItlWKF1SN/vJbkrEzcX0qYp3/t7G/B4Rvw+03TFbZEMkDk9yEulkaFYS/3TWG OmlOCSfzRXZMNXC9FIsGeVwuURsgYWd7+ppk85U6p+E8+oFtNAz+uBMmHHhUifQPti5G jy6e/DUI/DPJSpJ1IQbQWl2R1gKpWWwmNBI5kz/ZXtR1N1QZMAMjyTNooMECAFPZugpz NCbg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=JxB51lp/kVXVzHI9mSOg8vCOVKHuIxswJf+zTKBOBN4=; b=mCutLj+MKBL1/g1Ao3L2FA7bGYnqI9tZtlqInbB8HUAgZDxoY5w6uX0L/rSCTUGpev 96eNzwpBmjSIoufW9Hntpt6p0wxijTfvR7rFlPRWCAje7FlHcidGNpz73P1guqLFFLMM F5klTXoHyA2Fn2jHXacAiblyFYkQSFz0yw9BBm0Uvc/Qmh5rZUp8SE+MWxPQvvIGfDdN o4Ym5ROKfcBNllvXDUHQvP7FC+vlmGb/91Xki0z+j9OYRu5RglwccVTBFhnk0BvudBYO GL4/AylI0SddBg1kPYmqGexDVK3D/1NCnwuSDB/oNNjioW1N47unm+ZXjGsyBHu6qjYn HRHQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dtbXSp1W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x3si603480oic.251.2020.01.07.13.12.30; Tue, 07 Jan 2020 13:12:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=dtbXSp1W; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730147AbgAGVLr (ORCPT + 99 others); Tue, 7 Jan 2020 16:11:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:40714 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730133AbgAGVLn (ORCPT ); Tue, 7 Jan 2020 16:11:43 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 765872072A; Tue, 7 Jan 2020 21:11:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431502; bh=FhiT8EaHccPqvOpQJLyOpYXWGn+VUnFPf/RKRsJpRuM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=dtbXSp1WuBMrfdg1Xuo17aOudNG6KWpxH3PnFFg/Gwgl0KIW/FSgm1gTSlqqpA4LJ LvQ7PjPvfFd48o3O4Qy+UI8WpgdT7FCK+eRTlSI7cCp5Jf36yDkiEFjKQ/CBkCf7+5 eEeugD+LG/J4/KFGDCzdIe6PNK2zaZpMfSokJ294= Date: Tue, 7 Jan 2020 22:03:25 +0100 From: Greg KH To: Tejun Heo Cc: mateusznosek0@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/kernfs/dir.c: Clean code by removing always true condition Message-ID: <20200107210325.GA2255571@kroah.com> References: <20191230191628.21099-1-mateusznosek0@gmail.com> <20200107155110.GA2677547@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200107155110.GA2677547@devbig004.ftw2.facebook.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 07, 2020 at 07:51:10AM -0800, Tejun Heo wrote: > On Mon, Dec 30, 2019 at 08:16:28PM +0100, mateusznosek0@gmail.com wrote: > > From: Mateusz Nosek > > > > Previously there was an additional check if variable pos is not null. > > However, this check happens after entering while loop and only then, > > which can happen only if pos is not null. > > Therefore the additional check is redundant and can be removed. > > > > Signed-off-by: Mateusz Nosek > > Acked-by: Tejun Heo > > Greg, can you please route this one? Sure, will do, thanks. greg k-h