Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp19629ybl; Tue, 7 Jan 2020 13:15:11 -0800 (PST) X-Google-Smtp-Source: APXvYqzIi3x/qLoJd+T8b5lHGSz1HtvjY2E//OoqyrH4TGyl1oaA8kJemG0H8gewbGJniu+IysfW X-Received: by 2002:a05:6808:6c5:: with SMTP id m5mr355390oih.106.1578431711397; Tue, 07 Jan 2020 13:15:11 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578431711; cv=none; d=google.com; s=arc-20160816; b=OwLBeRdLq/qXpNuAw4iOqgqXJWiaVl+wIGsWSEL75NImEtqtk5R4UhwknnfA6dmQ9o ODK2IWxufx1yrC9QgNw3IF0fJMzTfNnGvY9SNhPC/xuuO8yFp4V+Ww/s+uyXUWpGgZsq xxxmSkMhe4eIhvJ4+dgnl1zxBoc7onht3Z614wlYW08z5YWo5ZMr9n/wiwhnuc1pT/9c Wkuajf3p1+aIG0/VgUbdvCQNKM/b4m6QazsSgKwaLUwqyp4hqypyJkYXxEtUt8eOsPWK xpRnvqX5/6OmVyYgMSIaKVX90LdPA3zbSpaA9wcRldHhTqJ8WvuIlN1Qo5LqIwweOZfk qJ6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=bAo+3XycUThN1R+A2dWoFRzlRueGUDYl8emiJoQhBt4=; b=txttOmipd7SY/BZ0HuNZrLHJdXcq/XnpMvB3W4GLtd6msH3+dwqmq+p3f7a8BU0e1d PFY62bA6SQYUsSqeE+YkV8WNAiCi7Vxj6Sg4w7PfDBamAqKtV46udKI6MFfAoJDenRgW Or3rN36jzqWcOSRzrCPE5fPbiX0CkBVzyzjp2pOAetumC76w4Dg7Y9XL+WOJ1c+Cu20w HTlTESi5xg2dd6phQKjpHEgUoy0qNH3mx2HvMCWK/RiZ1ykPeB0mksPhnujlkCk3AHsq KYhYtc6ihPCXor6RevSEWLtIPi59Jc7X94jtzrIDFd6Ml1wMAASrQupYGe/zZCiKcNiV BdOQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MqrUavia; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p20si574355otk.73.2020.01.07.13.14.58; Tue, 07 Jan 2020 13:15:11 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=MqrUavia; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729910AbgAGVOR (ORCPT + 99 others); Tue, 7 Jan 2020 16:14:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:35028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729838AbgAGVJc (ORCPT ); Tue, 7 Jan 2020 16:09:32 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2F5522077B; Tue, 7 Jan 2020 21:09:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431371; bh=uNlT/xetQ6RFCrhigblwgQYoApwioiyY31qevp3rOS8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MqrUavia63JqYF8DaqnQIHsYC1T7JTfc0e8hFtKpRTodS3JIn/4wMoY/8LdhoaPrl KeK5tov6v77+lqCeOB7QbSaEHxSDa6VYMDXEKtU6Dx6T6IM60J5yPuZtgrKk6vHByN E5uZGBqp3pmY2XnGPCYPMuzdd5R65LumYtzsqhAw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.14 08/74] scsi: iscsi: qla4xxx: fix double free in probe Date: Tue, 7 Jan 2020 21:54:33 +0100 Message-Id: <20200107205140.842196015@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205135.369001641@linuxfoundation.org> References: <20200107205135.369001641@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit fee92f25777789d73e1936b91472e9c4644457c8 ] On this error path we call qla4xxx_mem_free() and then the caller also calls qla4xxx_free_adapter() which calls qla4xxx_mem_free(). It leads to a couple double frees: drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->chap_dma_pool' double freed drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->fw_ddb_dma_pool' double freed Fixes: afaf5a2d341d ("[SCSI] Initial Commit of qla4xxx") Link: https://lore.kernel.org/r/20191203094421.hw7ex7qr3j2rbsmx@kili.mountain Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 4421f9bdfcf7..b0ad60565fe9 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -4285,7 +4285,6 @@ static int qla4xxx_mem_alloc(struct scsi_qla_host *ha) return QLA_SUCCESS; mem_alloc_error_exit: - qla4xxx_mem_free(ha); return QLA_ERROR; } -- 2.20.1