Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp19922ybl; Tue, 7 Jan 2020 13:15:32 -0800 (PST) X-Google-Smtp-Source: APXvYqzuPNV8DzmKNEoJqHRG5ohk29MHA8Wm10ywTlE0w++O+21fTUW51B78s/YAXdE25MCHnmpH X-Received: by 2002:a9d:3676:: with SMTP id w109mr1779042otb.35.1578431731986; Tue, 07 Jan 2020 13:15:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578431731; cv=none; d=google.com; s=arc-20160816; b=xt2qtWQ4XMepDMSgztePcqt+MP5Q/5ekAlTuLpUt7ST11oBJEztp8wwoMxGxgb321C UQt6E8GQ0/hgUgsB3HjFY4OiRLVYZNlpVJdiZI8f9x3GK5qYs801dKt5WckGTwb4BfJH icKymdD4MktwiRTn23pB7JktZt3Ks2Q859GEqm4EQojbDMTAT0BBXpTNasPz53ncZtId 0CNKrvsC9dOmsiaNnamDeliAThnOwo9iD6pbXoMyMpyb5/cTEQXQ1ICb9U6nKm0wKOyR +2XTdPYWRXPRraFR1eFgoaNN2wrJ/VRPaL1YY6RSqCYmRv8/51tFuKFk5il2HmHdIrjn NU+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=aeUtNtpP8cG9JNl/pSxNkBNJ+H1TYnAZHxlpVZeeQpU=; b=zWFUdrdQqaUEk2peKGIIl+f/pAvRoNbcb8+6U3g1RZGU6UtJyRPQpLI9HxXZQY9nXL IkXR05KeB17FreRNtooxWtjvoZTmXVPAm5RhQ+34+fe48nisQ+8AWLKvfEJaCsTfQHEG 5abNLViF2Z8G8NIMZmDNTU5UHyNSc+8x/a7XmhedyaNWhaqMKsekEtEbgR/ow0GI9gKc ABzZ7y/o+1O4WDRP8qgMpcOxyoCbiSHJ0SXYuapGHozcA8UhO78ZRuiPF5OFEF4uhZ23 tKaDrZ7NmfKZLMShcMUDp+gqElhkjuR7PAn86ca7N0HvFUVHH9cWfzfNqcu4w5zOJLYH PjQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S9nhVvwC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q3si526372otc.243.2020.01.07.13.15.19; Tue, 07 Jan 2020 13:15:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=S9nhVvwC; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730049AbgAGVOl (ORCPT + 99 others); Tue, 7 Jan 2020 16:14:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:34012 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729779AbgAGVJD (ORCPT ); Tue, 7 Jan 2020 16:09:03 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5004E2072A; Tue, 7 Jan 2020 21:09:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431342; bh=dMVZ4aWwUeqBhRzVPWyYVadpRe0c+Cpdjjsi9YAos4w=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=S9nhVvwCXiLyxkMUfvqqc11F/PH727wJmteflcPBIg9uVWqwLjOosouwd+Eny0J1Q CAuyAedlcR8XY8CqUDD2UMJXi+JfbQZGZFxbvMwsk9CwtV9LnxMMmeehCKIhYpl0Ud 0/DYuKsAG9kjmVImTX/XfBOqqD3M2StH2Iw8Di40= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicholas Tsirakis , Juergen Gross , Boris Ostrovsky , Sasha Levin Subject: [PATCH 4.14 18/74] xen/balloon: fix ballooned page accounting without hotplug enabled Date: Tue, 7 Jan 2020 21:54:43 +0100 Message-Id: <20200107205148.640690645@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205135.369001641@linuxfoundation.org> References: <20200107205135.369001641@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juergen Gross [ Upstream commit c673ec61ade89bf2f417960f986bc25671762efb ] When CONFIG_XEN_BALLOON_MEMORY_HOTPLUG is not defined reserve_additional_memory() will set balloon_stats.target_pages to a wrong value in case there are still some ballooned pages allocated via alloc_xenballooned_pages(). This will result in balloon_process() no longer be triggered when ballooned pages are freed in batches. Reported-by: Nicholas Tsirakis Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/balloon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index 71a6deeb4e71..3f9260af701f 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -401,7 +401,8 @@ static struct notifier_block xen_memory_nb = { #else static enum bp_state reserve_additional_memory(void) { - balloon_stats.target_pages = balloon_stats.current_pages; + balloon_stats.target_pages = balloon_stats.current_pages + + balloon_stats.target_unpopulated; return BP_ECANCELED; } #endif /* CONFIG_XEN_BALLOON_MEMORY_HOTPLUG */ -- 2.20.1