Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp25416ybl; Tue, 7 Jan 2020 13:22:05 -0800 (PST) X-Google-Smtp-Source: APXvYqyMUaQYNaLCd+lAuAu3jhv8kGG/fT/XkGCUF/LfTzWawxCaoC6coWHH4P+VSWZX9DjHf7QR X-Received: by 2002:a05:6830:121a:: with SMTP id r26mr1672883otp.225.1578432125553; Tue, 07 Jan 2020 13:22:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578432125; cv=none; d=google.com; s=arc-20160816; b=A8iMNfkRy3Bht+5kEf2TN00aTrglCIZc8g1E32rmKA5YEzLH4xXNVTg2P+aSQQqhah a31Y6SmA22K8JZMvYdqTxEMMP+oIv9N8PQMtlisSPTg7ehtbdFl1tdw1LkGlmdo4dsOd gIMfP+gDGgIrR/aQ9ctK3JnsTASIIoo4HWCsQtgrtt6OfBslHPHdkKauHlcNIYSEtNj4 hQVOV6NBRekjWKjMkYOG7rc6DhvolNaG+myI+BIDoJfcDDICYuP77xjfMfMAb8QtmAdG FpFDMtl2IePZf/k4CEMPhVhtmILlE0bLeP8rwnzWRtHPyaEll+6sN/gWQFxET4RTnVyR 6u5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9TVLVtFWgS70Kc4z7MODk0WUnFZL0U6N8tLud/XDe7g=; b=FGgL3ROnyD12Uv5lOHgdiH2gsEHUSeOjoJA1s1h/wVI3Psv/PWtbouPKjCUlee+04/ cDar7Vo7LfcWz8rbrKI78xQDm6Grr9V3tLOSsmMVfoP9Y8eb49y+lYSBlYNir+bqV7z1 64G4Ovy9Nqa5Xj+VkSFRVkXyZ4BD/IluFrah2sDtaQWDdqZbbOGrzU5qQGdFmikL2uWl /LQmc8Ci9O5v+vGxf4dviiFcz5kw+A7tnu3k1KL2TUn9yPYbXn7ZZHX2HqB5lCjMECEg vPL3Ww9bjfgKoU4831x/uQYOUFFgQcngu9U4zaDrhQhOV5n+b5l/ojmgEVhd/xcBmIsA IW3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HtUQ6grt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v6si609142ota.19.2020.01.07.13.21.52; Tue, 07 Jan 2020 13:22:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HtUQ6grt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729043AbgAGVEb (ORCPT + 99 others); Tue, 7 Jan 2020 16:04:31 -0500 Received: from mail.kernel.org ([198.145.29.99]:48784 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727543AbgAGVE2 (ORCPT ); Tue, 7 Jan 2020 16:04:28 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CB3A42081E; Tue, 7 Jan 2020 21:04:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578431068; bh=fD30xHA+J0qZBkzzvE0CUtKOV2ktSYvGLN96VwbX1Lw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HtUQ6grtzEZ6TF9bJHZERjcTrlfwBtPj065HoP0twP4TxSIPHin+gMjJ7QKdbFILt O4mboogY9cFBKAZkyuQ35l3moRna8ouvSc+5VMUEYbuRGPa82Riz+GSzmc4MBK0wq5 1ZlhYdt3VZ/Y98nwV7cO6WhZ4iOyp0KSlveHj0wk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , "Martin K. Petersen" , Sasha Levin Subject: [PATCH 4.19 021/115] scsi: iscsi: qla4xxx: fix double free in probe Date: Tue, 7 Jan 2020 21:53:51 +0100 Message-Id: <20200107205254.302233135@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205240.283674026@linuxfoundation.org> References: <20200107205240.283674026@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Dan Carpenter [ Upstream commit fee92f25777789d73e1936b91472e9c4644457c8 ] On this error path we call qla4xxx_mem_free() and then the caller also calls qla4xxx_free_adapter() which calls qla4xxx_mem_free(). It leads to a couple double frees: drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->chap_dma_pool' double freed drivers/scsi/qla4xxx/ql4_os.c:8856 qla4xxx_probe_adapter() warn: 'ha->fw_ddb_dma_pool' double freed Fixes: afaf5a2d341d ("[SCSI] Initial Commit of qla4xxx") Link: https://lore.kernel.org/r/20191203094421.hw7ex7qr3j2rbsmx@kili.mountain Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen Signed-off-by: Sasha Levin --- drivers/scsi/qla4xxx/ql4_os.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 25c8ce54a976..f8acf101af3d 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -4280,7 +4280,6 @@ static int qla4xxx_mem_alloc(struct scsi_qla_host *ha) return QLA_SUCCESS; mem_alloc_error_exit: - qla4xxx_mem_free(ha); return QLA_ERROR; } -- 2.20.1