Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp28891ybl; Tue, 7 Jan 2020 13:26:59 -0800 (PST) X-Google-Smtp-Source: APXvYqw3bG4YdJhvcLxzvK5GZH4FLvGExEUVt9VvSO1gAAE7fWOV83UrxTVZEM2Sup1t4f+aLWL2 X-Received: by 2002:aca:f354:: with SMTP id r81mr399909oih.90.1578432419719; Tue, 07 Jan 2020 13:26:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578432419; cv=none; d=google.com; s=arc-20160816; b=so1Rm+DxhRXuxs4+5wXyAA3D8BK+q5FsOHwjQAyazpIip0NNEltFFtTYk3g5wJsK5M F0//TepiT84a3r2aSSsdLIDvTgFRm4Ab7gXV/+GbnRcX1l337Yez+EbVXaLl9TdpRRcB joxZ/Saon3MH8VYRFBvkJuU8QP3R4qQ00tD7PpvbMZKPQtICyRuEojR5vUU3oTtju7C9 Cf76ULmYX641Msf0BaZyjLmn3SSqL2tUVjB0p8NU1RusYuRC8WtGfa3BOq1O2QnH3giJ qchRs9JFlnpg+3ZMrypA9kWQSDiTDxyJQCrQJJ0Fsa9e6VjlIdVO8lBlMTdcmfLofvP1 bKVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=g8qUDOjs9yAR76+Os4eIujidJ3i6oFvqZzJ9B/2e/PU=; b=KQpwlAcOu6kD7KJ6ILZoiP2NkMe2H/f/o4DFGdKF6Yf5ejZt4cJBGz0ltuJDHuw/cS 04pArCKT7W8tvJWLM3vr42SsriyhcSXWezU8mBJsAkk8vZFEaoXSfMmESIzJbRdW0Xqk mjE9pO5lJLWDcv1Y2fke+Fn1BvEuIYs+zuNPfZXqO3bO4TqpEtllGFI0S6wUH1SO/X4c QORFws6GU8o30bp7ZunzDUdBHHZbKmDVoIQ5Vfb5OJTiLSkt8ukevDEPo+NI4I0W4dJz I+6vDLPRZSJVmDllPfnuNfDrB/ocluvSXr9Zh7TlzDTR3I38t3odHNHhqtxuuuXz09Js F4UA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W55IdET7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i6si643145otj.24.2020.01.07.13.26.47; Tue, 07 Jan 2020 13:26:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=W55IdET7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728132AbgAGU7a (ORCPT + 99 others); Tue, 7 Jan 2020 15:59:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:60496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728124AbgAGU71 (ORCPT ); Tue, 7 Jan 2020 15:59:27 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D3A5E2087F; Tue, 7 Jan 2020 20:59:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578430766; bh=UZpOsYdE1Ppqt+5umPPoViX1SlL2qvGaTV670/xBn00=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=W55IdET7+x15nMpXs3o4C7RcCW4xsjuTijH0zOj5IpNzE9S5ezQkLkJ33RVr8adFX h1Ec7HNMCmTrffsamBfHn6UOUpCw9yJguxD+YN2XbS1cF5gRXCZXZ6b3KTmsHjw+Cb qbBLOoG/dICwuvF+YKdfc38h49x+aE4HZ0018294= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Nicholas Tsirakis , Juergen Gross , Boris Ostrovsky , Sasha Levin Subject: [PATCH 5.4 051/191] xen/balloon: fix ballooned page accounting without hotplug enabled Date: Tue, 7 Jan 2020 21:52:51 +0100 Message-Id: <20200107205335.733442762@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200107205332.984228665@linuxfoundation.org> References: <20200107205332.984228665@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Juergen Gross [ Upstream commit c673ec61ade89bf2f417960f986bc25671762efb ] When CONFIG_XEN_BALLOON_MEMORY_HOTPLUG is not defined reserve_additional_memory() will set balloon_stats.target_pages to a wrong value in case there are still some ballooned pages allocated via alloc_xenballooned_pages(). This will result in balloon_process() no longer be triggered when ballooned pages are freed in batches. Reported-by: Nicholas Tsirakis Signed-off-by: Juergen Gross Reviewed-by: Boris Ostrovsky Signed-off-by: Juergen Gross Signed-off-by: Sasha Levin --- drivers/xen/balloon.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c index 5bae515c8e25..bed90d612e48 100644 --- a/drivers/xen/balloon.c +++ b/drivers/xen/balloon.c @@ -395,7 +395,8 @@ static struct notifier_block xen_memory_nb = { #else static enum bp_state reserve_additional_memory(void) { - balloon_stats.target_pages = balloon_stats.current_pages; + balloon_stats.target_pages = balloon_stats.current_pages + + balloon_stats.target_unpopulated; return BP_ECANCELED; } #endif /* CONFIG_XEN_BALLOON_MEMORY_HOTPLUG */ -- 2.20.1