Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200107200659.3538375-1-arnd@arndb.de> <20200107124417.5239a6cf@cakuba.netronome.com>
In-Reply-To: <20200107124417.5239a6cf@cakuba.netronome.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 7 Jan 2020 23:01:50 +0100
Message-ID: <CAK8P3a27tFJpMeEuJDQWCHvGyETjM+XbPKenQwroxjc8Qpw=TQ@mail.gmail.com>
Subject: Re: [PATCH] netronome: fix ipv6 link error
To:     Jakub Kicinski <jakub.kicinski@netronome.com>
Cc:     "David S. Miller" <davem@davemloft.net>,
        Simon Horman <simon.horman@netronome.com>,
        John Hurley <john.hurley@netronome.com>,
        Jiri Pirko <jiri@mellanox.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        oss-drivers@netronome.com, Networking <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 7, 2020 at 9:44 PM Jakub Kicinski
<jakub.kicinski@netronome.com> wrote:
>
> On Tue,  7 Jan 2020 21:06:40 +0100, Arnd Bergmann wrote:
> > When the driver is built-in but ipv6 is a module, the flower
> > support produces a link error:
> >
> > drivers/net/ethernet/netronome/nfp/flower/tunnel_conf.o: In function `nfp_tunnel_keep_alive_v6':
> > tunnel_conf.c:(.text+0x2aa8): undefined reference to `nd_tbl'
>
> Damn, I guess the v2 of that patch set did not solve _all_ v6 linking
> issues :/ Thanks for the patch.
>
> > Add a Kconfig dependency to avoid that configuration.
> >
> > Fixes: 9ea9bfa12240 ("nfp: flower: support ipv6 tunnel keep-alive messages from fw")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > ---
> >  drivers/net/ethernet/netronome/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/ethernet/netronome/Kconfig b/drivers/net/ethernet/netronome/Kconfig
> > index bac5be4d4f43..dcb02ce28460 100644
> > --- a/drivers/net/ethernet/netronome/Kconfig
> > +++ b/drivers/net/ethernet/netronome/Kconfig
> > @@ -31,6 +31,7 @@ config NFP_APP_FLOWER
> >       bool "NFP4000/NFP6000 TC Flower offload support"
> >       depends on NFP
> >       depends on NET_SWITCHDEV
> > +     depends on IPV6 != m || NFP =m
>
> Could we perhaps do the more standard:
>
>         depends on IPV6 || IPV6=n

That would have to be on CONFIG_NFP instead of CONFIG_NFP_APP_FLOWER
then, making the entire driver a module if IPV6=m but always allowing
CONFIG_NFP_APP_FLOWER.

> The whitespace around = and != seems a little random as is..

Yep, my mistake. I can send a fixed version, please let me know which
version you want, or fix it up yourself if you find that easier.

     Arnd