Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200107220938.2412463-1-arnd@arndb.de>
In-Reply-To: <20200107220938.2412463-1-arnd@arndb.de>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Tue, 7 Jan 2020 17:04:11 -0600
Message-ID: <CAL_JsqJ0bVEkDfUw9+8gf=EVN=xjH4F1uyrmtWQfgc80FsTvew@mail.gmail.com>
Subject: Re: [PATCH] of: add dummy of_platform_device_destroy
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Frank Rowand <frowand.list@gmail.com>, Jyri Sarha <jsarha@ti.com>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 7, 2020 at 4:09 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> The new phy-j721e-wiz driver causes a link failure without CONFIG_OF:
>
> drivers/phy/ti/phy-j721e-wiz.o: In function `wiz_remove':
> phy-j721e-wiz.c:(.text+0x40): undefined reference to `of_platform_device_destroy'
>
> Add a dummy version of this function to avoid having to add Kconfig
> dependencies for the driver.
>
> Fixes: 42440de5438a ("phy: ti: j721e-wiz: Add support for WIZ module present in TI J721E SoC")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  include/linux/of_platform.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/of_platform.h b/include/linux/of_platform.h
> index 84a966623e78..2551c263e57d 100644
> --- a/include/linux/of_platform.h
> +++ b/include/linux/of_platform.h
> @@ -54,11 +54,16 @@ extern struct platform_device *of_device_alloc(struct device_node *np,
>                                          struct device *parent);
>  #ifdef CONFIG_OF
>  extern struct platform_device *of_find_device_by_node(struct device_node *np);
> +extern int of_platform_device_destroy(struct device *dev, void *data);

This is already declared, so don't you want to remove the existing one.

>  #else
>  static inline struct platform_device *of_find_device_by_node(struct device_node *np)
>  {
>         return NULL;
>  }
> +static inline int of_platform_device_destroy(struct device *dev, void *data)
> +{
> +       return 0;
> +}

I'm curious why this is needed, but of_platform_device_create() is not?

>  #endif
>
>  /* Platform devices and busses creation */
> --
> 2.20.0
>