Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp121433ybl; Tue, 7 Jan 2020 15:25:38 -0800 (PST) X-Google-Smtp-Source: APXvYqwRunpiEvCDOHWU5wVZMUsvgViReSFGnpuXfvDO49ywRdPqT8TXHceV6Yu4zF9/xm3+9/jd X-Received: by 2002:a9d:470a:: with SMTP id a10mr2113317otf.370.1578439538560; Tue, 07 Jan 2020 15:25:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578439538; cv=none; d=google.com; s=arc-20160816; b=uT5/p5eXfCIP1kRxFG82a6+TpNNr5mENanfepan7CQhViG3rX4wovqmH0gbc8+g8J4 bMdeq1/anIS0hvgvuQsdRu0K1IOCXQcPR41uDNrgk8f/tipvm89zdsMnq2A+pP/+A9xS ZcGd6Ks92NnPQ+HwkT51M2nsa1e3fT0t4aMghatEN9ZIOit3sc/QRuOz8RiRo4N7E8si ZQe21FKq7ebY4oYEaK8NJshTrE2VVDNuO0WVQOnUZYEdUhgAtTIdXw1HlZlstmBCHFaY G7m95ZomZ3IPjvjQSwf5pj8utbr3/ZapMaUHb99u+Ss04XGvmf0InITQ2WjWCOG5kec1 4NYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=e2p4I4E03TmL+2Xuk2GVqDHJ7D/1Z7Gw2tSyy85weFM=; b=MtNUf7KlVTPG+vCdfgavlokeFTF+bqwhyqb97dQfbOyaZ1xuIovl3lRMJX9wFQNFvQ dFWyk4RP9a9x3ElS2r79nfgWyR2wSubhd9CMFq+oux6SpOo5KqeqX/WvqqOhbPvGyltp abqfx1A71cTf3bD74emnabVRdCVPWj/Oivnis/+d2SVCqtSQ3thrNlphCER1RHxNVAEZ 4vgaHBSZEPGEEbZAEsM2FyVosNk2jusUpJXQgScJORqiwhy7BqU852v9ucxvCwrjykdQ Gz3RupWeMF1HiLIjvF/IlSPlS/Fi+WcVm0rMzYSaTxC/8yasKen4slzsFCc/a3NvbeK7 mIgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=KvF67BoM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j20si703585otp.147.2020.01.07.15.25.26; Tue, 07 Jan 2020 15:25:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=KvF67BoM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727731AbgAGXYX (ORCPT + 99 others); Tue, 7 Jan 2020 18:24:23 -0500 Received: from hqnvemgate24.nvidia.com ([216.228.121.143]:13296 "EHLO hqnvemgate24.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727225AbgAGXYV (ORCPT ); Tue, 7 Jan 2020 18:24:21 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate24.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 07 Jan 2020 15:23:31 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 07 Jan 2020 15:24:19 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 07 Jan 2020 15:24:19 -0800 Received: from [10.2.175.47] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 7 Jan 2020 23:24:18 +0000 Subject: Re: [PATCH v6 00/19] Move PMC clocks into Tegra PMC driver To: Dmitry Osipenko , , , , , , , , , , , CC: , , , , , , , , , , References: <1578370458-3686-1-git-send-email-skomatineni@nvidia.com> <4f52bc6e-3e97-f5fb-ce20-be7b55e688ee@gmail.com> From: Sowjanya Komatineni Message-ID: Date: Tue, 7 Jan 2020 15:24:16 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <4f52bc6e-3e97-f5fb-ce20-be7b55e688ee@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: quoted-printable Content-Language: en-US DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1578439411; bh=e2p4I4E03TmL+2Xuk2GVqDHJ7D/1Z7Gw2tSyy85weFM=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=KvF67BoMVREk12W7XQkYwhkK+3geV+GjXIdaGuwgUInqM7wfP2BWI+CVuYEnVOcxa aOmonXDGIFzOqboMpuw8TA2MHfxhnwYnzICU4GgbRTP0huIzGHtEuhuTzWSy+tRqiT nVP2GlQI3NOmWuTNOraL2GonkTGN5USryNQoY/qspBVrYbrPKEAhLFBg9dGrC23DRs lisrVp5Jub0LcPJ/jufju4yiQcYGehQSNnOcZZ9bIAYySsE6+LzXau5SM+SvfKTJoY Ml3joWT2L6WHd2zkTeuqLdQLfuGHnebvcCCs64SoD7AwvllG/DuuHqIYcF0OoTkZFr rF01GBUvrCooA== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/7/20 3:01 PM, Dmitry Osipenko wrote: > Hello Sowjanya, > > 07.01.2020 07:13, Sowjanya Komatineni =D0=BF=D0=B8=D1=88=D0=B5=D1=82: >> This patch series moves Tegra PMC clocks from clock driver to pmc driver >> along with the device trees changes and audio driver which uses one of >> the pmc clock for audio mclk. >> >> Tegra PMC has clk_out_1, clk_out_2, clk_out_3 and blink controls which >> are currently registered by Tegra clock driver using clk_regiser_mux and >> clk_register_gate which performs direct Tegra PMC register access. >> >> When Tegra PMC is in secure mode, any access from non-secure world will >> not go through. >> >> This patch series adds these Tegra PMC clocks and blink controls to Tegr= a >> PMC driver with PMC as clock provider and removes them from Tegra clock >> driver. >> >> PMC clock clk_out_1 is dedicated for audio mclk from Tegra30 thru Tegra2= 10 >> and clock driver does inital parent configuration for it and enables the= m. >> But this clock should be taken care by audio driver as there is no need >> to have this clock pre enabled. >> >> So, this series also includes patch that updates ASoC driver to take >> care of parent configuration for mclk if device tree don't specify >> initial parent configuration using assigned-clock-parents and controls >> audio mclk enable/disable during ASoC machine startup and shutdown. >> >> DTs are also updated to use clk_out_1 as audio mclk rather than extern1. >> >> This series also includes a patch for mclk fallback to extern1 when >> retrieving mclk fails to have this backward compatible of new DT with >> old kernels. >> >> [v6]: Changes between v5 and v6 are >> - v5 feedback >> - Added ASoC machine startup and shutdown callbacks to control audio >> mclk enable/disable and removed default mclk enable from clock driver= . >> - Updated tegra_asoc_utils_set_rate to disable mclk only during PLLA >> rate change and removed disabling PLLA as its already taken care by >> pll clock driver. >> - Removed tegra_asoc_utils_set_rate call from utils_init as set_rate >> is set during machine hw_params and during utils_init mclk is >> already in disabled state and this causes warning during mclk disable >> in utils_set_rate. >> >> [v5]: Changes between v4 and v5 are >> - v4 feedback >> - updated dt-binding pmc YAML schema with more description on power >> gate nodes and pad configuration state nodes. >> - update tegra_asoc_utils_set_rate to disable audio mclk only if >> its in enable state. >> >> [v4]: Changes between v3 and v4 are >> - v3 Feedback >> - Updated clocks clk_m_div2 and clk_m_div4 as osc_div2 and osc_div4. >> Tegra don't have clk_m_div2, clk_m_div4 and they should actually >> be osc_div2 and osc_div4 clocks from osc pads. >> - Fixed PMC clock parents to use osc, osc_div2, osc_div4. >> - Register each PMC clock as single clock rather than separate >> mux and gate clocks. >> - Update ASoC utils to use resource managed APIs rather than >> using clk_get and clk_put. >> - Updated device tree and ASoC driver to use clk_out_1 instead of >> clk_out_1_mux as PMC clocks are registered as single clock. >> - Update clock driver init_table to not enable audio related clocks >> as ASoC utils will do audio clock enables. >> >> [v3]: Changes between v2 and v3 are >> - Removes set parent of clk_out_1_mux to extern1 and enabling >> extern1 from the clock driver. >> - Doesn't enable clk_out_1 and blink by default in pmc driver >> - Updates ASoC driver to take care of audio mclk parent >> configuration incase if device tree don't specify assigned >> clock parent properties and enables mclk using both clk_out_1 >> and extern1. >> - updates all device trees using extern1 as mclk in sound node >> to use clk_out_1 from pmc. >> - patch for YAML format pmc dt-binding >> - Includes v2 feedback >> >> [v2]: Changes between v1 and v2 are >> - v2 includes patches for adding clk_out_1, clk_out_2, clk_out_3, >> blink controls to Tegra PMC driver and removing clk-tegra-pmc. >> - feedback related to pmc clocks in Tegra PMC driver from v1 >> - Removed patches for WB0 PLLM overrides and PLLE IDDQ PMC programming >> by the clock driver using helper functions from Tegra PMC. >> >> Note: >> To use helper functions from PMC driver, PMC early init need to >> happen prior to using helper functions and these helper functions are >> for PLLM Override and PLLE IDDQ programming in PMC during PLLM/PLLE >> clock registration which happen in clock_init prior to Tegra PMC >> probe. >> Moving PLLM/PLLE clocks registration to happen after Tegra PMC >> impacts other clocks EMC, MC and corresponding tegra_emc_init and >> tegra_mc_init. >> This implementation of configuring PMC registers thru helper >> functions in clock driver needs proper changes across PMC, Clock, >> EMC and MC inits to have it work across all Tegra platforms. >> >> Currently PLLM Override is not enabled in the bootloader so proper >> patches for this fix will be taken care separately. >> >> [v1]: v1 includes patches for below fixes. >> - adding clk_out_1, clk_out_2, clk_out_3, blink controls to Tegra PMC >> driver and removing clk-tegra-pmc. >> - updated clock provider from tegra_car to pmc in the device tree >> tegra210-smaug.dts that uses clk_out_2. >> - Added helper functions in PMC driver for WB0 PLLM overrides and PLLE >> IDDQ programming to use by clock driver and updated clock driver to >> use these helper functions and removed direct PMC access from clock >> driver and all pmc base address references in clock driver. >> >> >> >> >> Sowjanya Komatineni (19): >> dt-bindings: clock: tegra: Change CLK_M_DIV to OSC_DIV clocks >> clk: tegra: Change CLK_M_DIV clocks to OSC_DIV clocks >> clk: tegra: Fix Tegra PMC clock out parents >> dt-bindings: tegra: Convert Tegra PMC bindings to YAML >> dt-bindings: soc: tegra-pmc: Add Tegra PMC clock bindings >> soc: tegra: Add Tegra PMC clocks registration into PMC driver >> dt-bindings: soc: tegra-pmc: Add id for Tegra PMC 32KHz blink clock >> soc: tegra: Add support for 32KHz blink clock >> clk: tegra: Remove tegra_pmc_clk_init along with clk ids >> dt-bindings: clock: tegra: Remove pmc clock ids from clock dt-binding= s >> ASoC: tegra: Use device managed resource APIs to get the clock >> ASoC: tegra: Add audio mclk configuration >> ASoC: tegra: Add fallback implementation for audio mclk >> clk: tegra: Remove audio related clock enables from init_table >> ARM: dts: tegra: Add clock-cells property to pmc >> arm64: tegra: Add clock-cells property to Tegra PMC node >> ARM: tegra: Update sound node clocks in device tree >> arm64: tegra: smaug: Change clk_out_2 provider to pmc >> ASoC: nau8825: change Tegra clk_out_2 provider from tegra_car to pmc >> >> .../bindings/arm/tegra/nvidia,tegra20-pmc.txt | 300 -------------= ---- >> .../bindings/arm/tegra/nvidia,tegra20-pmc.yaml | 354 +++++++++++++= ++++++++ >> .../devicetree/bindings/sound/nau8825.txt | 2 +- >> arch/arm/boot/dts/tegra114-dalmore.dts | 8 +- >> arch/arm/boot/dts/tegra114.dtsi | 4 +- >> arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 8 +- >> arch/arm/boot/dts/tegra124-apalis.dtsi | 8 +- >> arch/arm/boot/dts/tegra124-jetson-tk1.dts | 8 +- >> arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +- >> arch/arm/boot/dts/tegra124-venice2.dts | 8 +- >> arch/arm/boot/dts/tegra124.dtsi | 4 +- >> arch/arm/boot/dts/tegra20.dtsi | 4 +- >> arch/arm/boot/dts/tegra30-apalis-v1.1.dtsi | 8 +- >> arch/arm/boot/dts/tegra30-apalis.dtsi | 8 +- >> arch/arm/boot/dts/tegra30-beaver.dts | 8 +- >> arch/arm/boot/dts/tegra30-cardhu.dtsi | 8 +- >> arch/arm/boot/dts/tegra30-colibri.dtsi | 8 +- >> arch/arm/boot/dts/tegra30.dtsi | 4 +- >> arch/arm64/boot/dts/nvidia/tegra132.dtsi | 4 +- >> arch/arm64/boot/dts/nvidia/tegra210-smaug.dts | 2 +- >> arch/arm64/boot/dts/nvidia/tegra210.dtsi | 6 +- >> drivers/clk/tegra/Makefile | 1 - >> drivers/clk/tegra/clk-id.h | 11 +- >> drivers/clk/tegra/clk-tegra-fixed.c | 32 +- >> drivers/clk/tegra/clk-tegra-pmc.c | 122 ------- >> drivers/clk/tegra/clk-tegra114.c | 41 +-- >> drivers/clk/tegra/clk-tegra124.c | 46 +-- >> drivers/clk/tegra/clk-tegra20.c | 9 +- >> drivers/clk/tegra/clk-tegra210.c | 30 +- >> drivers/clk/tegra/clk-tegra30.c | 31 +- >> drivers/clk/tegra/clk.h | 1 - >> drivers/soc/tegra/pmc.c | 352 +++++++++++++= +++++++ >> include/dt-bindings/clock/tegra114-car.h | 18 +- >> include/dt-bindings/clock/tegra124-car-common.h | 18 +- >> include/dt-bindings/clock/tegra20-car.h | 2 +- >> include/dt-bindings/clock/tegra210-car.h | 18 +- >> include/dt-bindings/clock/tegra30-car.h | 18 +- >> include/dt-bindings/soc/tegra-pmc.h | 16 + >> sound/soc/tegra/tegra_alc5632.c | 28 +- >> sound/soc/tegra/tegra_asoc_utils.c | 125 ++++---- >> sound/soc/tegra/tegra_asoc_utils.h | 3 +- >> sound/soc/tegra/tegra_max98090.c | 43 ++- >> sound/soc/tegra/tegra_rt5640.c | 43 ++- >> sound/soc/tegra/tegra_rt5677.c | 28 +- >> sound/soc/tegra/tegra_sgtl5000.c | 28 +- >> sound/soc/tegra/tegra_wm8753.c | 43 ++- >> sound/soc/tegra/tegra_wm8903.c | 43 ++- >> sound/soc/tegra/tegra_wm9712.c | 8 +- >> sound/soc/tegra/trimslice.c | 39 ++- >> 49 files changed, 1192 insertions(+), 777 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,= tegra20-pmc.txt >> create mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,= tegra20-pmc.yaml >> delete mode 100644 drivers/clk/tegra/clk-tegra-pmc.c >> create mode 100644 include/dt-bindings/soc/tegra-pmc.h >> > I briefly looked through the patches and tested them in all possible > configurations. For now everything looks and works well. > > You could add this to all patches: > > Tested-by: Dmitry Osipenko > Reviewed-by: Dmitry Osipenko Thanks Dmitry