Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp220513ybl; Tue, 7 Jan 2020 17:40:56 -0800 (PST) X-Google-Smtp-Source: APXvYqzHf8F1AWT3CAnFhsvsp+cKdtaZYxex9G7OtLaOO4yr4dpIXKOqzVWQU7jIztOLbvYSHWtP X-Received: by 2002:a9d:68cb:: with SMTP id i11mr2390182oto.210.1578447656102; Tue, 07 Jan 2020 17:40:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578447656; cv=none; d=google.com; s=arc-20160816; b=aS9aFZa5VIi49myuoxJ+7cG2VqaqIso/6KJfwF/0fRQBdLUxSQquvuUNSdppiTJd5z S7cpJdCmbw9kY18vLXCdI1rdMEXLng8Cvl/eb66pghgd/APrmDOXp9lvQegDI2n0cpsR CSfauzWHpBKvXcz2ddJh2mv+aGbR65PUeo10c0ekIBULbjHroFsD80kGexgwjctd9HxC 046hmqjokQ4W805eWv0CfV+O1Wefb0lvqQ1URWKXwTST32MXH7XJbEeTJRIMolUkQGaT fsU9kSmTD63xxgixzC+H0fvZjScpnk3X2sUo0YKYi5hUrmeW0CkXFb9uRkXCMeNqBksT KXmg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=e8n00SzYbunU3XpsIx9o7Wp8bKRn/cHr9A8w/z5L3Y0=; b=UnCpIxxiDjVotxcPABA1j1KLg9b8yDKaHeeto1p/7hhgDnwhss2LzLdkzi0a7ty0HW /OTv54n1vvDBFiPhLOIoKZiH+GxjM6jwMnY9OxJbIWM5T4o0yJgpXmzdsZrC21034BvL UeNVBBNCW8J+8ZKNjhrrHGVyX8XV1ACVwE6fq3CDTz7bBQuIDIxmmo0AxTC3PPd2nknB GIIdFJoNz+laLRWSEaw3EoFgKZGD1LJsxnsMw38KflrPaT9iRq1wPCJAxCV5UdKxEjbN RvEbHFt4oDk/KBGNQ589E0mGG+L2dR4q44zZsgVFowePRDCSfgOl0/3BLziueBujw1on AgNA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r6si978627otq.95.2020.01.07.17.40.44; Tue, 07 Jan 2020 17:40:56 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727027AbgAHBkD (ORCPT + 99 others); Tue, 7 Jan 2020 20:40:03 -0500 Received: from mx2.suse.de ([195.135.220.15]:52738 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726313AbgAHBkC (ORCPT ); Tue, 7 Jan 2020 20:40:02 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 516CBAFB0; Wed, 8 Jan 2020 01:40:01 +0000 (UTC) From: Davidlohr Bueso To: dave@stgolabs.net Cc: bigeasy@linutronix.de, bristot@redhat.com, jack@suse.com, juri.lelli@redhat.com, linux-kernel@vger.kernel.org, longman@redhat.com, mingo@kernel.org, oleg@redhat.com, peterz@infradead.org, tglx@linutronix.de, will@kernel.org, williams@redhat.com, Davidlohr Bueso Subject: [PATCH] locking/percpu-rwsem: Add might_sleep() for writer locking Date: Tue, 7 Jan 2020 17:33:05 -0800 Message-Id: <20200108013305.7732-2-dave@stgolabs.net> X-Mailer: git-send-email 2.16.4 In-Reply-To: <20200108013305.7732-1-dave@stgolabs.net> References: <20191115203906.fbo6t7d2n6xk3saw@linux-p48b> <20200108013305.7732-1-dave@stgolabs.net> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org We are missing this annotation in percpu_down_write(). Correct this. Signed-off-by: Davidlohr Bueso --- Applies against your queue tree. kernel/locking/percpu-rwsem.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/locking/percpu-rwsem.c b/kernel/locking/percpu-rwsem.c index 4cbeeada8d09..08db2abfa00d 100644 --- a/kernel/locking/percpu-rwsem.c +++ b/kernel/locking/percpu-rwsem.c @@ -212,6 +212,7 @@ static bool readers_active_check(struct percpu_rw_semaphore *sem) void percpu_down_write(struct percpu_rw_semaphore *sem) { + might_sleep(); rwsem_acquire(&sem->dep_map, 0, 0, _RET_IP_); /* Notify readers to take the slow path. */ -- 2.16.4