Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 07 Jan 2020 18:58:13 -0800
Message-ID: <87zheyu01m.wl-ashutosh.dixit@intel.com>
From:   "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To:     Xu Wang <vulab@iscas.ac.cn>
CC:     <sudeep.dutt@intel.com>, <gregkh@linuxfoundation.org>,
        <arnd@arndb.de>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mic: Remove unneeded NULL check
In-Reply-To: <1578391235-603-1-git-send-email-vulab@iscas.ac.cn>
References: <1578391235-603-1-git-send-email-vulab@iscas.ac.cn>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue)
 FLIM/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL/10.8 EasyPG/1.0.0 Emacs/26
 (x86_64-pc-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

On Tue, 07 Jan 2020 02:00:35 -0800, Xu Wang wrote:
>
> debugfs_remove_recursive will do NULL check, so remove
> the redundant null check.
>
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>
> ---
>  drivers/misc/mic/card/mic_debugfs.c  | 3 ---
>  drivers/misc/mic/cosm/cosm_debugfs.c | 3 ---
>  drivers/misc/mic/host/mic_debugfs.c  | 3 ---
>  3 files changed, 9 deletions(-)
>
> diff --git a/drivers/misc/mic/card/mic_debugfs.c b/drivers/misc/mic/card/mic_debugfs.c
> index 3ee3d24..b586088 100644
> --- a/drivers/misc/mic/card/mic_debugfs.c
> +++ b/drivers/misc/mic/card/mic_debugfs.c
> @@ -65,9 +65,6 @@ void __init mic_create_card_debug_dir(struct mic_driver *mdrv)
>   */
>  void mic_delete_card_debug_dir(struct mic_driver *mdrv)
>  {
> -	if (!mdrv->dbg_dir)
> -		return;
> -
>	debugfs_remove_recursive(mdrv->dbg_dir);
>  }
>
> diff --git a/drivers/misc/mic/cosm/cosm_debugfs.c b/drivers/misc/mic/cosm/cosm_debugfs.c
> index 2fc9f4b..68a731f 100644
> --- a/drivers/misc/mic/cosm/cosm_debugfs.c
> +++ b/drivers/misc/mic/cosm/cosm_debugfs.c
> @@ -102,9 +102,6 @@ void cosm_create_debug_dir(struct cosm_device *cdev)
>
>  void cosm_delete_debug_dir(struct cosm_device *cdev)
>  {
> -	if (!cdev->dbg_dir)
> -		return;
> -
>	debugfs_remove_recursive(cdev->dbg_dir);
>  }
>
> diff --git a/drivers/misc/mic/host/mic_debugfs.c b/drivers/misc/mic/host/mic_debugfs.c
> index 8a8e416..ab0db7a 100644
> --- a/drivers/misc/mic/host/mic_debugfs.c
> +++ b/drivers/misc/mic/host/mic_debugfs.c
> @@ -129,9 +129,6 @@ void mic_create_debug_dir(struct mic_device *mdev)
>   */
>  void mic_delete_debug_dir(struct mic_device *mdev)
>  {
> -	if (!mdev->dbg_dir)
> -		return;
> -
>	debugfs_remove_recursive(mdev->dbg_dir);
>  }
>
> --
> 2.7.4
>