Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <5e157ea4.1c69fb81.8361e.6698@mx.google.com>
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <1578431066-19600-18-git-send-email-eberman@codeaurora.org>
References: <1578431066-19600-1-git-send-email-eberman@codeaurora.org> <1578431066-19600-18-git-send-email-eberman@codeaurora.org>
Cc:     Elliot Berman <eberman@codeaurora.org>,
        saiprakash.ranjan@codeaurora.org, tsoni@codeaurora.org,
        sidgup@codeaurora.org, psodagud@codeaurora.org,
        Brian Masney <masneyb@onstation.org>,
        linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 17/17] firmware: qcom_scm: Dynamically support SMCCC and legacy conventions
To:     Bjorn Andersson <bjorn.andersson@linaro.org>,
        Elliot Berman <eberman@codeaurora.org>,
        Stephan Gerhold <stephan@gerhold.net>, agross@kernel.org
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.8.1
Date:   Tue, 07 Jan 2020 23:02:59 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

(Nitpick trivia late at night)

Quoting Elliot Berman (2020-01-07 13:04:26)
> diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
> index 895f148..059bb0f 100644
> --- a/drivers/firmware/qcom_scm.c
> +++ b/drivers/firmware/qcom_scm.c
> @@ -72,6 +72,13 @@ static struct qcom_scm_wb_entry qcom_scm_wb[] =3D {
>         { .flag =3D QCOM_SCM_FLAG_WARMBOOT_CPU3 },
>  };
> =20
> +static const char *qcom_scm_convention_names[] =3D {

Can this be const char * const ?

> +       [SMC_CONVENTION_UNKNOWN] =3D "unknown",
> +       [SMC_CONVENTION_ARM_32] =3D "smc arm 32",
> +       [SMC_CONVENTION_ARM_64] =3D "smc arm 64",
> +       [SMC_CONVENTION_LEGACY] =3D "smc legacy",
> +};
> +
>  static struct qcom_scm *__scm;
> =20
>  static int qcom_scm_clk_enable(void)
> @@ -107,6 +114,143 @@ static void qcom_scm_clk_disable(void)
>         clk_disable_unprepare(__scm->bus_clk);
>  }
> =20
> +static int __qcom_scm_is_call_available(struct device *dev, u32 svc_id,
> +                                       u32 cmd_id);
> +
> +enum qcom_scm_convention qcom_scm_convention;
> +static bool has_queried __read_mostly;
> +static DEFINE_SPINLOCK(query_lock);
> +
> +static void __query_convention(void)
> +{
> +       unsigned long flags;
> +       struct qcom_scm_desc desc =3D {
> +               .svc =3D QCOM_SCM_SVC_INFO,
> +               .cmd =3D QCOM_SCM_INFO_IS_CALL_AVAIL,
> +               .args[0] =3D SCM_SMC_FNID(QCOM_SCM_SVC_INFO,
> +                                          QCOM_SCM_INFO_IS_CALL_AVAIL) |
> +                          (ARM_SMCCC_OWNER_SIP << ARM_SMCCC_OWNER_SHIFT),
> +               .arginfo =3D QCOM_SCM_ARGS(1),
> +               .owner =3D ARM_SMCCC_OWNER_SIP,
> +       };
> +       struct qcom_scm_res res;
> +       int ret;
> +
> +       spin_lock_irqsave(&query_lock, flags);
> +       if (has_queried)
> +               goto out;
> +
> +       qcom_scm_convention =3D SMC_CONVENTION_ARM_64;
> +       // Device isn't required as there is only one argument - no device
> +       // needed to dma_map_single to secure world

This isn't kernel style for multiline comments. Please use /* and */.

> +       ret =3D scm_smc_call(NULL, &desc, &res, true);
> +       if (!ret && res.result[0] =3D=3D 1)
> +               goto out;
> +