Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp456542ybl;
        Tue, 7 Jan 2020 23:41:53 -0800 (PST)
X-Google-Smtp-Source: APXvYqyMBXRrVmUX8OIqqu7ZPmX3UFgbM+Msg8EyLxsDvRChV9mUyIqvYxPI8DRWAatjMl1Gu2rh
X-Received: by 2002:a9d:6557:: with SMTP id q23mr3034699otl.368.1578469313410;
        Tue, 07 Jan 2020 23:41:53 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1578469313; cv=none;
        d=google.com; s=arc-20160816;
        b=V0xi4ADvwDjzG7ErMHIb/elvqkuDA4p889WGEr5dfJ0xsLN/XEDxf794lIMAwatIqC
         IwhdzzRLrjkK07mmhZs395RNFOBgMecHlD9+omT8dvOXfSV3/o+OM/fAVCHIAN1o5gS0
         AnE6CYpyAjfDc4mXxj3oj3cIta+5crrvS6M/d2xzM49D2JaXEvxBJRWNjMr+TjiRgg5j
         qNnMewdyl1FZlwDUSnI5P8WshO0GihSDPHolZzgiRnmVn/j8/3qAfp3S/beWxx49t14f
         D/EkB1Rn0yikiUzR5Niftc+0bRHpws6xGE44X1y0ppUpTHwfptkgr7GZIcVJCVifHs9h
         ha8g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=TngIjaroCN4DhxNH/w6HyPhtFuckDY0NIRg0TlF2UhM=;
        b=YHhFgVgH2VEAdEXvGrHgOobOKD5CuhouHQSeXp0CaRCrAJSqWlPSAcItabwfmBAXGo
         F6gfdfT3bVT20IcVo5WivdIm5pMiB/lETvHjR3Aaj6wuTqG4v+t/yApEZcLLZvIJhMOV
         jrvRbRxIjf3uy6iU36M4/LrOJ5F9w1QEEu5WXBG9Ub2xsIOFFXiPhaq1K2tSrh1OgrbZ
         7oQ/e5Znjecjrb/HNogoolhsXPx+SHHKyL3bMnoYS01rRdu3DX3swf3BJEbhoKFO2TQp
         pnyyS2h4qInC63aIuz5KXX71P8W16s4hQoWct1Q4zDIWWjn+jahKK0Nx7K8gleBdi/M8
         3CLQ==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id r22si1335053otn.192.2020.01.07.23.41.40;
        Tue, 07 Jan 2020 23:41:53 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726363AbgAHHYJ (ORCPT <rfc822;yuvraaj@gmail.com> + 99 others);
        Wed, 8 Jan 2020 02:24:09 -0500
Received: from metis.ext.pengutronix.de ([85.220.165.71]:50741 "EHLO
        metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726079AbgAHHYJ (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Jan 2020 02:24:09 -0500
Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5])
        by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
        (Exim 4.92)
        (envelope-from <mfe@pengutronix.de>)
        id 1ip5gu-0003RP-HA; Wed, 08 Jan 2020 08:23:44 +0100
Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89)
        (envelope-from <mfe@pengutronix.de>)
        id 1ip5gs-0003MG-LI; Wed, 08 Jan 2020 08:23:42 +0100
Date:   Wed, 8 Jan 2020 08:23:42 +0100
From:   Marco Felsch <m.felsch@pengutronix.de>
To:     fengping yu <fengping.yu@mediatek.com>
Cc:     Matthias Brugger <matthias.bgg@gmail.com>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Olof Johansson <olof@lixom.net>,
        Aisheng Dong <aisheng.dong@nxp.com>,
        Anson Huang <Anson.Huang@nxp.com>,
        Maxime Ripard <mripard@kernel.org>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Dinh Nguyen <dinguyen@kernel.org>,
        Marcin Juszkiewicz <marcin.juszkiewicz@linaro.org>,
        Valentin Schneider <valentin.schneider@arm.com>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Mark Brown <broonie@kernel.org>,
        Thierry Reding <treding@nvidia.com>,
        YueHaibing <yuehaibing@huawei.com>,
        Stefan Agner <stefan@agner.cn>, Jacky Bai <ping.bai@nxp.com>,
        linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        devicetree@vger.kernel.org, wsd_upstream@mediatek.com
Subject: Re: [PATCH V2 2/2] drivers: input: keyboard
Message-ID: <20200108072342.xkym3bnqgwapgqjz@pengutronix.de>
References: <20200108062923.14684-1-fengping.yu@mediatek.com>
 <20200108062923.14684-3-fengping.yu@mediatek.com>
 <20200108071130.leowzwzkexozumda@pengutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200108071130.leowzwzkexozumda@pengutronix.de>
X-Sent-From: Pengutronix Hildesheim
X-URL:  http://www.pengutronix.de/
X-IRC:  #ptxdist @freenode
X-Accept-Language: de,en
X-Accept-Content-Type: text/plain
X-Uptime: 08:22:13 up 53 days, 22:40, 46 users,  load average: 0.15, 0.09,
 0.03
User-Agent: NeoMutt/20170113 (1.7.2)
X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5
X-SA-Exim-Mail-From: mfe@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-PTX-Original-Recipient: linux-kernel@vger.kernel.org
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi,

On 20-01-08 08:11, Marco Felsch wrote:

...

> > +struct mtk_keypad {
> > +	struct input_dev *input_dev;
> > +	struct wakeup_source *suspend_lock;
> > +	struct tasklet_struct tasklet;
> 
> Why do you use a tasklet instead of a simple softirq?

Sorry, what I mean was a threaded_irq.

Regards,
  Marco