Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp467583ybl; Tue, 7 Jan 2020 23:57:18 -0800 (PST) X-Google-Smtp-Source: APXvYqx8qz27UVMU8o5uk6VTCKl+SpWr2+0NwWZVROm0MT9quJO5He09Jldo72NSEgrDmD2i/EWG X-Received: by 2002:a9d:7618:: with SMTP id k24mr3244561otl.65.1578470238803; Tue, 07 Jan 2020 23:57:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578470238; cv=none; d=google.com; s=arc-20160816; b=b3ecQsLoe+ruO6FKs6MchX8s32k0qd8nlq45XPzkIsNQiWcJtRIC6l77WBCQjMswd9 wgaVwzdtjBZ49KtQRXwsZJutBegiN9oAr5dY5SgDg7VKEXujZS4r2tF6lhACVYA1DYUL Vh6HArGXZ+v6TE7DLqIVjtUOPzL53Dhtwh4f89OiiQkM1LR+R0p6tEGfJU3JTvt5yJiu rrUxW5ZdHfwrFKXquWhUiLYcDtaTP8OcT2KgBE0J3IzX1siQWCE7tIOHmmxrOdC5OwXp t9OWmqCXcxpAeu4p2JMMGhkFZ/60C0neq80IZYWTFK6dIIJNBJozJhKImngM89lQJJWd jVLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=a5VGo9Q64ek9LGAHrL9tadnOuvuVFDpTBPX7eGadvIg=; b=AijDtyPj0cJFJJOm8F6by8yeR7YdlpJpV6rJ0FIe45yD0JYge2jbbufuPHxz4ewScs y5vJTOd+/bbuAnMByoOE0RF61X30po6Tvyzb8Pwi3OquHSr+Lbc2b04y8C+Jbf3npx7n 11r0HUnloZ2kazw4MSMgc9PuDwZKWQa1vojzxEa5ZIDZVCVgr5MacbG1x7y/tKHKKP0c /iANV8pyz2khnQevFSl7UdTUMecQz+vaMndSvXicZnrHfUi91/ZFEeevkWBZojBAQciD FsS1GUF7wkWsH2FBIqPZv12dPFwbJ5wDR60FassBNdOJflkrwQwq2FMUPgc8nrrxuJpZ lBPQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l20si1407306otr.227.2020.01.07.23.57.06; Tue, 07 Jan 2020 23:57:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726927AbgAHHyx (ORCPT + 99 others); Wed, 8 Jan 2020 02:54:53 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:38087 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726482AbgAHHyx (ORCPT ); Wed, 8 Jan 2020 02:54:53 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ip6Aw-0006cj-M5; Wed, 08 Jan 2020 08:54:46 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ip6Av-0007Hn-Rj; Wed, 08 Jan 2020 08:54:45 +0100 Date: Wed, 8 Jan 2020 08:54:45 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Peng Fan Cc: "jason@lakedaemon.net" , "andrew@lunn.ch" , "gregory.clement@bootlin.com" , "sebastian.hesselbarth@gmail.com" , "linus.walleij@linaro.org" , "mripard@kernel.org" , "wens@csie.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH V2] pinctrl: mvebu: armada-37xx: use use platform api Message-ID: <20200108075445.xoilokyywyacwoma@pengutronix.de> References: <1578467325-4189-1-git-send-email-peng.fan@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1578467325-4189-1-git-send-email-peng.fan@nxp.com> User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Jan 08, 2020 at 07:12:46AM +0000, Peng Fan wrote: > From: Peng Fan > > platform_irq_count() and platform_get_irq() is the more generic > way (independent of device trees) to determine the count of available > interrupts. So use this instead. > > As platform_irq_count() might return an error code (which > of_irq_count doesn't) some additional handling is necessary. > > Signed-off-by: Peng Fan > --- > > V2: > replace %pe with %d for err msg. FTR: I really like having %pe for its better expressiveness and started arguing in the v1 thread. So please wait a bit before applying this patch. Thanks Uwe -- Pengutronix e.K. | Uwe Kleine-K?nig | Industrial Linux Solutions | https://www.pengutronix.de/ |