Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "H. Nikolaus Schaller" <hns@goldelico.com>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Subject: [BUG]: usb: dwc3: gadget: broken on OMAP5432
Date:   Wed, 8 Jan 2020 09:59:44 +0100
Message-Id: <703DD239-8E3B-405C-A531-FF7DEEED38DC@goldelico.com>
Cc:     linux-usb@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Discussions about the Letux Kernel 
        <letux-kernel@openphoenux.org>, kernel@pyra-handheld.com,
        Linux-OMAP <linux-omap@vger.kernel.org>
To:     Tejas Joglekar <Tejas.Joglekar@synopsys.com>,
        Felipe Balbi <balbi@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\))
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,
I noticed that the usb ethernet gadget driver is broken since v5.5-rc2
and 5.4.4, but only for our OMAP5 board. Our OMAP3 boards work with
the same tree, kernel binary and user-space (Debian Stretch).

The symptom is that I can see the interface on the host PC being
enumerated and IP addresses etc. are set up. But a ping in either
direction fails/times out.

After inspecting diffs I found some changes in dwc3:gadget
and indeed omap3/twl4030 uses musb and omap5 uses dwc3.

Reverting

a7f7e61270f1 ("usb: dwc3: gadget: Fix logical condition");

on v5.5-rc makes it work again.

BTW: v4.19.90 works although it includes this logical condition fix.
So the real difference between v4.19 and v5.5 may be elsewhere in
newer kernels and only be revealed by the patch.

If important: my setup is running with USB2 cable and speed
only.

So please check this and other recent dwc3 patches for introducing
a stall of communication.

BR and thanks,
Nikolaus Schaller