Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191227114811.14907-1-chenzhou10@huawei.com>
In-Reply-To: <20191227114811.14907-1-chenzhou10@huawei.com>
From:   Patrik Jakobsson <patrik.r.jakobsson@gmail.com>
Date:   Wed, 8 Jan 2020 10:12:35 +0100
Message-ID: <CAMeQTsY2+9Z1ShVrp1AbQo4+VbVymHrv2meg7353=YDoWbFeLw@mail.gmail.com>
Subject: Re: [PATCH next] drm/gma500: remove set but not used variables 'hist_reg'
To:     Chen Zhou <chenzhou10@huawei.com>
Cc:     David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
        dri-devel <dri-devel@lists.freedesktop.org>,
        linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 27, 2019 at 12:52 PM Chen Zhou <chenzhou10@huawei.com> wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/gma500/psb_irq.c: In function psb_irq_turn_off_dpst:
> drivers/gpu/drm/gma500/psb_irq.c:473:6:
>         warning: variable hist_reg set but not used [-Wunused-but-set-variable]
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Chen Zhou <chenzhou10@huawei.com>

Applied to drm-misc-next

Thanks
Patrik

> ---
>  drivers/gpu/drm/gma500/psb_irq.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/psb_irq.c b/drivers/gpu/drm/gma500/psb_irq.c
> index 40a37e4..91f9001 100644
> --- a/drivers/gpu/drm/gma500/psb_irq.c
> +++ b/drivers/gpu/drm/gma500/psb_irq.c
> @@ -470,12 +470,11 @@ void psb_irq_turn_off_dpst(struct drm_device *dev)
>  {
>         struct drm_psb_private *dev_priv =
>             (struct drm_psb_private *) dev->dev_private;
> -       u32 hist_reg;
>         u32 pwm_reg;
>
>         if (gma_power_begin(dev, false)) {
>                 PSB_WVDC32(0x00000000, HISTOGRAM_INT_CONTROL);
> -               hist_reg = PSB_RVDC32(HISTOGRAM_INT_CONTROL);
> +               PSB_RVDC32(HISTOGRAM_INT_CONTROL);
>
>                 psb_disable_pipestat(dev_priv, 0, PIPE_DPST_EVENT_ENABLE);
>
> --
> 2.7.4
>