Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   james qian wang <james.qian.wang@arm.com>
To:     Arnd Bergmann <arnd@arndb.de>
CC:     Liviu Dudau <Liviu.Dudau@arm.com>,
        Mihail Atanassov <Mihail.Atanassov@arm.com>,
        Brian Starkey <Brian.Starkey@arm.com>,
        David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Nathan Chancellor <natechancellor@gmail.com>,
        Lowry Li <Lowry.Li@arm.com>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        nd <nd@arm.com>
Subject: Re: [PATCH] drm/komeda: mark PM functions as __maybe_unused
Thread-Topic: [PATCH] drm/komeda: mark PM functions as __maybe_unused
Thread-Index: AQHVxaTpM196drNzoU+K8km25bMwD6fgiGmA
Date:   Wed, 8 Jan 2020 09:56:17 +0000
Message-ID: <20200108095609.GA23558@jamwan02-TSP300>
References: <20200107215327.1579195-1-arnd@arndb.de>
In-Reply-To: <20200107215327.1579195-1-arnd@arndb.de>
Accept-Language: en-US
Content-Language: en-US
user-agent: Mutt/1.10.1 (2018-07-13)
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 4bc5c1d5-7d02-434e-043f-08d79421067d
X-MS-TrafficTypeDiagnostic: VE1PR08MB4638:|VE1PR08MB4638:|VI1PR0801MB1904:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <VI1PR0801MB19041F2DBE8D052453BD279AB33E0@VI1PR0801MB1904.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
nodisclaimer: True
x-ms-oob-tlc-oobclassifiers: OLM:8273;OLM:8273;
x-forefront-prvs: 02760F0D1C
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(4636009)(7916004)(366004)(376002)(136003)(39860400002)(396003)(346002)(189003)(199004)(8936002)(9686003)(478600001)(5660300002)(956004)(6916009)(64756008)(6486002)(81166006)(2906002)(81156014)(8676002)(86362001)(4326008)(6496006)(52116002)(66446008)(55236004)(186003)(16526019)(1076003)(66946007)(66476007)(71200400001)(26005)(33716001)(54906003)(66556008)(33656002)(316002);DIR:OUT;SFP:1101;SCL:1;SRVR:VE1PR08MB4638;H:VE1PR08MB5006.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: o7UR8rvTMYKozy4v4+ufH7yQJ9j29c9WkVxXtlzuML6KPUH4ML2XSI9kpwnHc6jIa9GGVc0fQSSHFEkkz7Jj792jfhqceykT19LehQeNlbRELbO2qBdJAtUBo8i0HNwTprz5kpLAyyCSUSYZ6ccv5lTaCon42prXpuIMrIs4FnhkO2zpErDHHF1zqApPL+0rDK0blr65XemtDOb2HXQNlqhU3UC4+04I0U54sJfrN4JI8jGzdM6OEAymJPaep2BbQk0tFmHCiasKBMvIGfIiM1F0ynvpE6bZ6mrBMg18VIDR8p7yVmmBvnGZisNDH6y/HX3pn18Mq65iBnOi+pSE+VkXZBGEd3jFLHaAO11wFlUzPIBuBYKihVelLY7BpNsCw4NaKma0Szmt/2nry617hhOQ6mYBhWXcM0aSaEjKbqUDeyyZnvONt0XtEgUjobs7
Content-Type: text/plain; charset="us-ascii"
Content-ID: <610660CE5AAB6A4D8861041D6FE3465B@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB4638
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=james.qian.wang@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(4636009)(396003)(39860400002)(136003)(346002)(376002)(199004)(189003)(956004)(26826003)(6486002)(336012)(70206006)(186003)(70586007)(5660300002)(33716001)(54906003)(478600001)(33656002)(16526019)(9686003)(8676002)(81156014)(26005)(356004)(86362001)(316002)(4326008)(81166006)(36906005)(2906002)(6862004)(1076003)(8936002)(6496006);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0801MB1904;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;A:1;MX:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 5440e4fa-c649-4d27-972d-08d79421013b
X-Forefront-PRVS: 02760F0D1C
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: V0MC5rxMwIU9qYBsQQ5TqdnLQYMSTecuHXgv5/HdyegG17jbhIBu8jIx+8W6nFHTzG3gdsDbgCipc4NuYZ+NNAS4XOoC7AjvDuAOwPsroo6L7aMnkD3/YM0w3k8UT/JAG+05u3o0OMW9bWg+r3VOgirmCaMCqa/R1TwDQUPC7GTrX8IZb+9yAG3lmp3MGOtqC76SijZWeaZP0z2oAjc8v+95CcjxgUTJS5xaAewzTL7DXDqQGuBfBzPp9EeRp14zzGVFNK6Fv/9mmfo8Di/auJlgejyN0Cu6wbkPjpgO4+zIK4qBzhjtNVAVbRt4J11Kqn21YUu9NJFNJQIRQ+US7g2P0yL/GnFR34KtOCjrrqQdm9Al1KyG7dSqTncRiltWkjeqdAUO7ksPWmDm4LnP4uzlQXF2xlp+d243y/pmTK4SHcQZ5luhrC2lmjO0erfL
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2020 09:56:25.8821
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 4bc5c1d5-7d02-434e-043f-08d79421067d
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0801MB1904
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jan 07, 2020 at 10:53:19PM +0100, Arnd Bergmann wrote:
> Without this, we get a couple of warnings when CONFIG_PM
> is disabled:
>=20
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c:156:12: error: 'komeda_rt=
_pm_resume' defined but not used [-Werror=3Dunused-function]
>  static int komeda_rt_pm_resume(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~
> drivers/gpu/drm/arm/display/komeda/komeda_drv.c:149:12: error: 'komeda_rt=
_pm_suspend' defined but not used [-Werror=3Dunused-function]
>  static int komeda_rt_pm_suspend(struct device *dev)
>             ^~~~~~~~~~~~~~~~~~~~
>=20
> Fixes: efb465088518 ("drm/komeda: Add runtime_pm support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/arm/display/komeda/komeda_drv.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c b/drivers/gp=
u/drm/arm/display/komeda/komeda_drv.c
> index ea5cd1e17304..e7933930a657 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_drv.c
> @@ -146,14 +146,14 @@ static const struct of_device_id komeda_of_match[] =
=3D {
> =20
>  MODULE_DEVICE_TABLE(of, komeda_of_match);
> =20
> -static int komeda_rt_pm_suspend(struct device *dev)
> +static int __maybe_unused komeda_rt_pm_suspend(struct device *dev)
>  {
>  	struct komeda_drv *mdrv =3D dev_get_drvdata(dev);
> =20
>  	return komeda_dev_suspend(mdrv->mdev);
>  }
> =20
> -static int komeda_rt_pm_resume(struct device *dev)
> +static int __maybe_unused komeda_rt_pm_resume(struct device *dev)
>  {
>  	struct komeda_drv *mdrv =3D dev_get_drvdata(dev);
>

Hi Arnd:

Thank you for the patch.

Reviewed-by: James Qian Wang (Arm Technology China) <james.qian.wang@arm.co=
m>

James
> --=20
> 2.20.0