Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp755803ybl; Wed, 8 Jan 2020 05:24:01 -0800 (PST) X-Google-Smtp-Source: APXvYqygKc7qbQDSlTcI8tU7BWr6NJ2XWBACejmUWi5qfw3TYCH4/GXol3YCdjC7OZnPyuQLfQBC X-Received: by 2002:aca:50cd:: with SMTP id e196mr3000963oib.178.1578489840815; Wed, 08 Jan 2020 05:24:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578489840; cv=none; d=google.com; s=arc-20160816; b=d4rY3NfBaz/5YHHsTeSfdQQJKLn5CCZVs3VOLaEGyj2nTK1KGD4k5oDKnlpPllfqjE DBIwOXOGdxs/iCgUYm7f/1gf/83LhSB4lai7/g0v6Q02Rf39hD/aT4bdgco1lLD2r+c/ 577SBg/YqLLCbb8PBojdaDUj1OxzNTxHQqA2GTIO5fvYSwZOjRwrDCOoIb+ZC9HDcmkY 6K5O1YcfJtl2fTeqcEd8OpmxbDmzJY87Vl8FLLND3SMCGyF30u+/alM+/jAUIuvdV0N/ aeUMsU7I8P5qmpi+G8S6rpSmjlUbwUwYkfvTko2jYLjfsfsXTUOlNdexV/dZIW/R1dEo 17nQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=mSIL4XRfgbxCL8YZOg+wNCYLtJmNG5AhoDt05FnR3eU=; b=rd3qzlSzEedWT8m+lzhDBJvX6HFVN0d687rWZpMf5PIuPpeCBpe+kBc/qL9JjlutK1 3TsaGlJ4Ul6Ls/K0RJP+4FdG0U2WEOYgLdtmT36Jl0M/QWuv9NqIDS1Fd4pbCxR+97pY Z174vG81c7h23rGVc6BOB3Y04ZkMEv6QvvJ/4Ug1/WvgR4BA7MRNImUZx+lke0i3UPxs xOWz6lTtD6cXcSYGx38n81jDgTpPITgXisnA9kVs47IY4xcLKzq2qEuXcHDJBOOfr97W PrwjhoFBQ4CpqwZmoWpz+L5mXed903T3AfS6WrMsw74X336NEyF2U0MCwN/90fZDuGXP V/Jg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d6si1663069otq.41.2020.01.08.05.23.47; Wed, 08 Jan 2020 05:24:00 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728012AbgAHNXE (ORCPT + 99 others); Wed, 8 Jan 2020 08:23:04 -0500 Received: from foss.arm.com ([217.140.110.172]:44500 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726757AbgAHNXE (ORCPT ); Wed, 8 Jan 2020 08:23:04 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1A8B431B; Wed, 8 Jan 2020 05:23:04 -0800 (PST) Received: from localhost (unknown [10.37.6.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 99F2B3F703; Wed, 8 Jan 2020 05:23:03 -0800 (PST) Date: Wed, 8 Jan 2020 13:23:02 +0000 From: Mark Brown To: Nicolas Boichat Cc: Rob Herring , David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Liam Girdwood , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, hsinyi@chromium.org Subject: Re: [PATCH v2 4/7] drm/panfrost: Add support for a second regulator for the GPU Message-ID: <20200108132302.GA3817@sirena.org.uk> References: <20200108052337.65916-1-drinkcat@chromium.org> <20200108052337.65916-5-drinkcat@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <20200108052337.65916-5-drinkcat@chromium.org> X-Cookie: Trouble always comes at the wrong time. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --KsGdsel6WgEHnImy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jan 08, 2020 at 01:23:34PM +0800, Nicolas Boichat wrote: > Some GPUs, namely, the bifrost/g72 part on MT8183, have a second > regulator for their SRAM, let's add support for that. > + pfdev->regulator_sram = devm_regulator_get_optional(pfdev->dev, "sram"); > + if (IS_ERR(pfdev->regulator_sram)) { This supply is required for the devices that need it so I'd therefore expect the driver to request the supply non-optionally based on the compatible string rather than just hoping that a missing regulator isn't important. Though I do have to wonder given the lack of any active management of the supply if this is *really* part of the GPU or if it's more of a SoC thing, it's not clear what exactly adding this code is achieving. --KsGdsel6WgEHnImy Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4V17MACgkQJNaLcl1U h9B1Tgf9F6myo+YZUDZcDAsE1tQHONaZ147hS3g2NDCgQf79b/fWyNVelAPRvxg+ wz+J0q2LmDX9K0ldimkt+BEitrL5aVQsPjw/WOXbOk/n4FBP11uDMxk9i586GGfO EXHDmfUQh8D+wEjZBKck8+yaa0NYCFoHdlxc3rPILim9fGRiJKa18EdbPRfb7lNm 86k2Nkicmd8gkBfk7GlJ8MgGabr1ezpiza+F/vhTkEm+WHCcDwy+BadJG5whNnC0 GmKn0ieyraLxmVUjC4BpkJbeG/ye5VPCOcLn4ZjGrRU209STb45MyFAlAaYFNzX0 0wWQAm/aPa23vn2QhxYUW1RALdueLQ== =UhEZ -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy--