Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp804532ybl; Wed, 8 Jan 2020 06:12:37 -0800 (PST) X-Google-Smtp-Source: APXvYqwvY3oBPfJ45kfDj25+FKSkkz2cN2cgTO3LTiob+iG1xkEJIxxN5bRwYxGuJvqlJUE/6Gvi X-Received: by 2002:a9d:6745:: with SMTP id w5mr4419783otm.52.1578492757518; Wed, 08 Jan 2020 06:12:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578492757; cv=none; d=google.com; s=arc-20160816; b=HsI6AfhvuiaSnDqQVblYaNWoJD1R4PKKAGQWTnI+XRcl7RgVYfBoWRPDzgX9h/SJ+o zCcXWoCXYKbRUST4oKTt7H50esTvCXheHbPBBiyJNB5s2VWKAoa3KnoU27GHUhgXFNaJ tH/ZxVk2Ot6SlT3KUqIjYU1UM2q6itHF+7PWsR7wpxKcPjpDobTGaFB15xoUqNqmBeyH 3PJGUEz6GUcCLtB6iUDfBhYSC0x9401m+2vhjze9bhPgQS0O7Jdh6mWO8EO1glD86eCJ 8GY5h6GhycefNK78/UwZhHuF1zBNV7a+GY5sV5hT5vd6G4KRqkRoHXpb2JuQMAYRkRW4 Xrhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :date:message-id:mime-version:references:in-reply-to:subject:cc:to :from; bh=07RgEQXvmw0hpSmELXKe3Vl/OIUylmmcauPctEl8Okg=; b=Vx+s2teGlwT1lyW16AJmBbrHfEpBrvh3EUSOG1+60l3AvZXID2Zzv6T1ePHMOMLFeK ffzOBhcRM+tOCc+Fyl6qAZ4gcEFd2IAN0UWWQ1QXi1w3Y+yh/FhitAYMkMRdsgoV4Z/I VLzrs6q8LdS6tP+/quuLFyZb/snoS0eKFqu71Wt1uIPg9pqLObnE33qjpGA6S4m5DWhl dXtQtffNEXHdVsN9DGmutn4lJNw9pABl9CmO5EZwCHcW2lfj7j/Cv2HKhzeDwUSl0BRd Z8pZr7Bskynl9q5VWxUWdEXxpnNCjedG+anEuj8t1guT3hCLiADLb9o/Wec6QYY/KVz8 ERSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=sHnn9rKo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f190si1818416oig.229.2020.01.08.06.12.24; Wed, 08 Jan 2020 06:12:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=sHnn9rKo; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728219AbgAHMvM (ORCPT + 99 others); Wed, 8 Jan 2020 07:51:12 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:2133 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727119AbgAHMvL (ORCPT ); Wed, 8 Jan 2020 07:51:11 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 08 Jan 2020 04:50:52 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 08 Jan 2020 04:51:10 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 08 Jan 2020 04:51:10 -0800 Received: from HQMAIL109.nvidia.com (172.20.187.15) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 8 Jan 2020 12:51:09 +0000 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL109.nvidia.com (172.20.187.15) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 8 Jan 2020 12:51:09 +0000 Received: from [192.168.22.23] (10.124.1.5) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Wed, 8 Jan 2020 12:51:07 +0000 From: Thierry Reding To: Dmitry Osipenko CC: Laxman Dewangan , Vinod Koul , Dan Williams , Thierry Reding , Jonathan Hunter , =?utf-8?q?Micha=C5=82_Miros=C5=82?= aw , , , Subject: Re: [PATCH v3 00/13] NVIDIA Tegra APB DMA driver fixes and improvements In-Reply-To: <20200106011708.7463-1-digetx@gmail.com> References: <20200106011708.7463-1-digetx@gmail.com> X-NVConfidentiality: public MIME-Version: 1.0 Message-ID: <85d8ea335734417081399a082d44024c@HQMAIL105.nvidia.com> Date: Wed, 8 Jan 2020 12:51:07 +0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1578487853; bh=07RgEQXvmw0hpSmELXKe3Vl/OIUylmmcauPctEl8Okg=; h=X-PGP-Universal:From:To:CC:Subject:In-Reply-To:References: X-NVConfidentiality:MIME-Version:Message-ID:Date:Content-Type: Content-Transfer-Encoding; b=sHnn9rKoZqlmS90zDg4BZOPyVAByenoUio17rRnjU6NTWcYZDxN57X68TrwR5Z9bV yeLilikOvtnevRg+Bj06GycMMRTb9EMPaoD5kjCwM2p8HvZ/bZIIzsiia3UtagyqId gMygLwcmdtgp2YXJ9805gw77QaFKn5Wc57emXQROA3bZPVzSu0yd06UXY2FWrQuQPY uNr+7s8TPXbrBhgeNB2vHX2kpDhAakt5D1ol69c1KwktWReXb/qKKC29scbzko00yu 1Oi4HBXYMyXdjwndwWDNvjyobQapooQ+gur1f8MZxBe1pYayWCZbvM+MpaAum0RS34 QZP0X6cXotLLg== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 06 Jan 2020 04:16:55 +0300, Dmitry Osipenko wrote: > Hello, >=20 > This is series fixes some problems that I spotted recently, secondly the > driver's code gets a cleanup. Please review and apply, thanks in advance! >=20 > Changelog: >=20 > v3: - In the review comment to v1 Micha=C5=82 Miros=C5=82aw suggested tha= t "Prevent > race conditions on channel's freeing" does changes that deserve to > be separated into two patches. I factored out and improved tasklet > releasing into this new patch: >=20 > dmaengine: tegra-apb: Clean up tasklet releasing >=20 > - The "Fix use-after-free" patch got an improved commit message. >=20 > v2: - I took another look at the driver and spotted few more things that > could be improved, which resulted in these new patches: >=20 > dmaengine: tegra-apb: Remove runtime PM usage > dmaengine: tegra-apb: Clean up suspend-resume > dmaengine: tegra-apb: Add missing of_dma_controller_free > dmaengine: tegra-apb: Allow to compile as a loadable kernel modul= e > dmaengine: tegra-apb: Remove MODULE_ALIAS >=20 > Dmitry Osipenko (13): > dmaengine: tegra-apb: Fix use-after-free > dmaengine: tegra-apb: Implement synchronization callback > dmaengine: tegra-apb: Prevent race conditions on channel's freeing > dmaengine: tegra-apb: Clean up tasklet releasing > dmaengine: tegra-apb: Prevent race conditions of tasklet vs free list > dmaengine: tegra-apb: Use devm_platform_ioremap_resource > dmaengine: tegra-apb: Use devm_request_irq > dmaengine: tegra-apb: Fix coding style problems > dmaengine: tegra-apb: Remove runtime PM usage > dmaengine: tegra-apb: Clean up suspend-resume > dmaengine: tegra-apb: Add missing of_dma_controller_free > dmaengine: tegra-apb: Allow to compile as a loadable kernel module > dmaengine: tegra-apb: Remove MODULE_ALIAS >=20 > drivers/dma/Kconfig | 2 +- > drivers/dma/tegra20-apb-dma.c | 481 ++++++++++++++++------------------ > 2 files changed, 220 insertions(+), 263 deletions(-) Test results: 13 builds: 13 pass, 0 fail 12 boots: 11 pass, 1 fail 38 tests: 38 pass, 0 fail Linux version: 5.5.0-rc5-gf9d40c056c0f Boards tested: tegra20-ventana, tegra30-cardhu-a04, tegra124-jetson-tk1, tegra186-p2771-0000, tegra194-p2972-0000, tegra210-p2371-2180