Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20200108121117.45060-1-yuehaibing@huawei.com>
In-Reply-To: <20200108121117.45060-1-yuehaibing@huawei.com>
From:   Bartosz Golaszewski <bgolaszewski@baylibre.com>
Date:   Wed, 8 Jan 2020 14:07:33 +0100
Message-ID: <CAMpxmJWwcL9e6so=XrYmpjW1DF=7Vnq4UMvWE+j+sTbnXjd6Ww@mail.gmail.com>
Subject: Re: [PATCH -next] gpiolib: remove set but not used variable 'config'
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     Linus Walleij <linus.walleij@linaro.org>,
        linux-gpio <linux-gpio@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

=C5=9Br., 8 sty 2020 o 13:11 YueHaibing <yuehaibing@huawei.com> napisa=C5=
=82(a):
>
> drivers/gpio/gpiolib.c: In function gpio_set_config:
> drivers/gpio/gpiolib.c:3053:16: warning:
>  variable config set but not used [-Wunused-but-set-variable]
>
> commit d90f36851d65 ("gpiolib: have a single place
> of calling set_config()") left behind this unused variable.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpio/gpiolib.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
> index 9fd2dfb..aabf801 100644
> --- a/drivers/gpio/gpiolib.c
> +++ b/drivers/gpio/gpiolib.c
> @@ -3050,7 +3050,6 @@ static int gpio_do_set_config(struct gpio_chip *gc,=
 unsigned int offset,
>  static int gpio_set_config(struct gpio_chip *gc, unsigned int offset,
>                            enum pin_config_param mode)
>  {
> -       unsigned long config;
>         unsigned arg;
>
>         switch (mode) {
> @@ -3064,7 +3063,6 @@ static int gpio_set_config(struct gpio_chip *gc, un=
signed int offset,
>                 arg =3D 0;
>         }
>
> -       config =3D PIN_CONF_PACKED(mode, arg);
>         return gpio_do_set_config(gc, offset, mode);
>  }
>

Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>

Thanks!