Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8BIT
To:     Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Wambui Karuga <wambui.karugax@gmail.com>, airlied@linux.ie,
        daniel@ffwll.ch, rodrigo.vivi@intel.com
From:   Chris Wilson <chris@chris-wilson.co.uk>
In-Reply-To: <87v9pmovmx.fsf@intel.com>
Cc:     intel-gfx@lists.freedesktop.org, seanpaul@chromium.org,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
References: <cover.1578409433.git.wambui.karugax@gmail.com>
 <b79ee0f6efbf8358cbb4f2e163fa6b5bb04db794.1578409433.git.wambui.karugax@gmail.com>
 <157847199686.4725.87481257304852182@jlahtine-desk.ger.corp.intel.com>
 <8736cqs2uf.fsf@intel.com>
 <157848029770.2273.9590955422248556735@skylake-alporthouse-com>
 <87v9pmovmx.fsf@intel.com>
Message-ID: <157849519000.2273.18061101721039254369@skylake-alporthouse-com>
User-Agent: alot/0.6
Subject: Re: [Intel-gfx] [PATCH 1/5] drm/i915: convert to using the drm_dbg_kms()
 macro.
Date:   Wed, 08 Jan 2020 14:53:10 +0000
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Jani Nikula (2020-01-08 14:44:38)
> On Wed, 08 Jan 2020, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> > Quoting Jani Nikula (2020-01-08 09:40:40)
> >> On Wed, 08 Jan 2020, Joonas Lahtinen <joonas.lahtinen@linux.intel.com> wrote:
> >> > Quoting Wambui Karuga (2020-01-07 17:13:29)
> >> >> Convert the use of the DRM_DEBUG_KMS() logging macro to the new struct
> >> >> drm_device based drm_dbg_kms() logging macro in i915/intel_pch.c.
> >> >> 
> >> >> Signed-off-by: Wambui Karuga <wambui.karugax@gmail.com>
> >> >> ---
> >> >>  drivers/gpu/drm/i915/intel_pch.c | 46 +++++++++++++++++---------------
> >> >>  1 file changed, 24 insertions(+), 22 deletions(-)
> >> >> 
> >> >> diff --git a/drivers/gpu/drm/i915/intel_pch.c b/drivers/gpu/drm/i915/intel_pch.c
> >> >> index 43b68b5fc562..4ed60e1f01db 100644
> >> >> --- a/drivers/gpu/drm/i915/intel_pch.c
> >> >> +++ b/drivers/gpu/drm/i915/intel_pch.c
> >> >> @@ -12,90 +12,91 @@ intel_pch_type(const struct drm_i915_private *dev_priv, unsigned short id)
> >> >>  {
> >> >>         switch (id) {
> >> >>         case INTEL_PCH_IBX_DEVICE_ID_TYPE:
> >> >> -               DRM_DEBUG_KMS("Found Ibex Peak PCH\n");
> >> >> +               drm_dbg_kms(&dev_priv->drm, "Found Ibex Peak PCH\n");
> >> >
> >> > Did we at some point consider i915_dbg_kms alias? That would just take
> >> > dev_priv (or i915, as it's called in newer code). It would shorten many
> >> > of the statements.
> >> >
> >> > i915_dbg_kms(dev_priv, ...) or i915_dbg_kms(i915, ...)
> >> 
> >> I'd rather use the common drm logging macros. I thought about adding
> >> i915 specific ones only if the drm device specific logging macros
> >> weren't going to be merged.
> >
> > Why do they even exist? Why isn't it enough to do
> > #define drm_info(drm, fmt, ...) dev_info(&(drm)->dev, fmt, ##__VA_ARGS) ?
> 
> It *is* enough to do that, and that's essentially what the new macros
> do, just with an extra helper macro in between.

/o\

Mistook __drm_printk() for the older drm_dev_printk()
-Chris