Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp957894ybl; Wed, 8 Jan 2020 08:36:38 -0800 (PST) X-Google-Smtp-Source: APXvYqwJP/MtybnokGJlf0XhJMON7unElaKgQLyXD2rZZv8dw4dMEDXWRDGuZmDKnwocmCv+EYBM X-Received: by 2002:a9d:6c99:: with SMTP id c25mr4717284otr.178.1578501398298; Wed, 08 Jan 2020 08:36:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578501398; cv=none; d=google.com; s=arc-20160816; b=OazZaw2JN4KFi6sUkdjHGcuyWgo3cP/oMevZExa6wceN6qQ1XjkEuHQVe9ffJ8FrQe +qMm102i3+c17v3GLj6Rj9nio0A7uZBmDhas645FoTYfx6Ke/a+NwXMA168XdHBV02MI FnfZDqRzAfmud1LVujRXmgVyXbgP1fQRE+oitmihUBuDBQUk+XQxOGVw6TbDBk1EPivk jsTvKrUpQ/PMro7nNB4ZzN6+XS3SQqVdpPN+nCjuhRen3AQrGL+P+QBo8opV4pTHCNMD cqC+9C7KEKIpA9s1SZ2tMw1t0JWdsVBs/Ugku/Tm4c3ejSl1CGFMjRjhxO3mrNa4oa0E cO7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=stmoRBUwIDDNfn0qe+9AbU6IJN9NJVkp8GrenHVAux8=; b=K9g+uiu5u3QXeyX6PnDV3Rzb5mSq+HzWdtATFpc4ES5zBSLcZDJyJ+GVE2fUVecRCW QLptQXMk8Lm4C4L9uBxRMGzFc0F/YftPE/gypyga2jqftxJx37BHobzD9neqcxCfY45m 2OjmiLkkfENtuB8Nq4Aogaw3PMM+RVHZUW4NvdBaKLg9Tv4kEmuEEW7JTrvbONGZxrr5 ACR+lDEhdTFns0Tzy4snhANlo/uRuVoTUIchTc3s8IjpGemcy6y4yQNelQ6WbGm2Y4FW 31dXhSpquZLyn/u1/ghfoKzsguYDynGDTzyLdgFAiCICwe6E0uK/lVmpXGk/6EKXj4ba VjNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=C63i9qbA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i12si2141660otk.215.2020.01.08.08.36.26; Wed, 08 Jan 2020 08:36:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=C63i9qbA; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728367AbgAHQfl (ORCPT + 99 others); Wed, 8 Jan 2020 11:35:41 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:41088 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726922AbgAHQfk (ORCPT ); Wed, 8 Jan 2020 11:35:40 -0500 Received: by mail-io1-f65.google.com with SMTP id c16so3854793ioo.8 for ; Wed, 08 Jan 2020 08:35:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=stmoRBUwIDDNfn0qe+9AbU6IJN9NJVkp8GrenHVAux8=; b=C63i9qbAd/9chrpdbayX3EdsPRbIYNp5Mji8wwH7OL/Em9vl7dV0fT+IpLko6zEH4t XVLRzg+F8X9gJxT1EZCB/tMf0lS4dfgZQu6kwaAbYwe3MxoeG4bpf+ice1D6N7nW8tAd PvQcVjLjp1hA4fw3kNzcX+xjRKg/iC15vUEBQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=stmoRBUwIDDNfn0qe+9AbU6IJN9NJVkp8GrenHVAux8=; b=W+7RxITIXBjQ1n02JyTkYqcFFvZziKkNRF8QZFuy9MLs0Vahc8fSbR0LrdwdA8FebD i9fe6VO1xP9Ogv+WETSo1qPIDBOYJSPy8Urqh9Z1BCyL4gALChukAYLF9ATcG1cC/c8j Q2+FEwVnif3n5jhhshExMFd78Np2Ja//94AekVWAneHra0tACK2QXh7h27ktAi9q2TYa UC2MkmyRpy1SgXT1d6oA/3wI4LbP7IuaZWiN7lnMEOHCVrl7uYub/i6GVsjZtA5rqnxD KjLlY+YO4DLYHm2kmmLROJ9s1GgdcXCRYOcIyH4x0QL/DLuDrf3OSx2zj1MWnacCDKRH +bbQ== X-Gm-Message-State: APjAAAX6ndT/+eNEXiKUaEOnnvMwIyFBfQZY+6WXdmnngSwHWWQ+4YOn rqPIrTbtAKIsVINsM/oI3bOz7O3lTsQ= X-Received: by 2002:a02:a694:: with SMTP id j20mr4960877jam.69.1578501339930; Wed, 08 Jan 2020 08:35:39 -0800 (PST) Received: from localhost ([2620:15c:183:200:5d69:b29f:8fd8:6f45]) by smtp.gmail.com with ESMTPSA id z17sm742533ior.22.2020.01.08.08.35.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 08 Jan 2020 08:35:39 -0800 (PST) From: Daniel Campello To: LKML Cc: Daniel Campello , Enric Balletbo i Serra , Wei Yongjun , Duncan Laurie , Nick Crews , Benson Leung Subject: [PATCH] platform/chrome: wilco_ec: Fix unregistration order Date: Wed, 8 Jan 2020 09:35:20 -0700 Message-Id: <20200108093459.2.Ia8f971d42dcf892541a806b906414ddfbe4fea36@changeid> X-Mailer: git-send-email 2.24.1.735.g03f4e72817-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the unregistration order on the Wilco EC core driver to follow the christmas tree pattern. Signed-off-by: Daniel Campello --- drivers/platform/chrome/wilco_ec/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/chrome/wilco_ec/core.c b/drivers/platform/chrome/wilco_ec/core.c index 5210c357feefd4..2d5f027d8770f8 100644 --- a/drivers/platform/chrome/wilco_ec/core.c +++ b/drivers/platform/chrome/wilco_ec/core.c @@ -137,9 +137,9 @@ static int wilco_ec_remove(struct platform_device *pdev) { struct wilco_ec_device *ec = platform_get_drvdata(pdev); + platform_device_unregister(ec->telem_pdev); platform_device_unregister(ec->charger_pdev); wilco_ec_remove_sysfs(ec); - platform_device_unregister(ec->telem_pdev); platform_device_unregister(ec->rtc_pdev); if (ec->debugfs_pdev) platform_device_unregister(ec->debugfs_pdev); -- 2.24.1.735.g03f4e72817-goog