Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp969182ybl; Wed, 8 Jan 2020 08:47:42 -0800 (PST) X-Google-Smtp-Source: APXvYqxereCmfQ8ee+CuzI7j5rbk3HDIEcitsory0HGLDUkdRqXLuHDEkdTUUYH3Lv9tgQyQH7+b X-Received: by 2002:a9d:5885:: with SMTP id x5mr4761092otg.132.1578502062222; Wed, 08 Jan 2020 08:47:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578502062; cv=none; d=google.com; s=arc-20160816; b=ZcT/U8cDatNZ+H7cM9YFKLSJg7RzFLVtsvlmFyuiudFIELf5TzKyf0/klksuBZZkSq rC96brXEKEM9O7eaTPhR6ofX55xmru3da0NJb3sGyVuuPO+8Bo6iszA/IJaVfkQg/l2N 3fm8ntjyxfLdyFUcdQRuW6Ix/YANyH5fMrUvK3kF11AQ8NXmXm7OTm6rGSh6FTRTzbet xRnO2AgEZPCwqfvfX1G88dUPoMI/KvQqoXG6SkwKiuYILG0YTWdTZWs46khP7PMaT1mc AyRooIuAM0OmTEUc2nW4gb7Zm7qO8MKgUhG17c9WSPxMyNvAsun6mVz94c85wI+P5CdX 7WAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=7NaINGSAXQTGeHrgmzZWwS4z1Tzo9mjBWejkl9U/7XU=; b=U9bg51hC5+JQYmXpbfZyXrSQejrfupXWeddmOBjDkVSY9ORIF/4gfXyIu2Pl4gfElS AwdKYj6E+U9Kp+pzgk/nKltuxz6aJP3EpSKx4BBgyRf3ldpD+xKThpnR+IhWja4251u6 Eonv0xJP3iFAHHRwFqHbftKtfQTb7PgND6VrvU/8MSWrzMD/iyxend4McT2zX/lqC6r/ I1gQPALphd1eA8kYTi2lfWwUIP2jg86RVsY75OhDC0K9+L2DpkFNGdfZ7fzvE/wXfyhK 4GWOTfT1xZbXf0gRnFn8NCiIoczW0CeVsD5QduefPexg8opom7ABVdLLt7ED2g4gwajK FI6A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p18si2734799otg.61.2020.01.08.08.47.30; Wed, 08 Jan 2020 08:47:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729263AbgAHQq1 (ORCPT + 99 others); Wed, 8 Jan 2020 11:46:27 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:53116 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727148AbgAHQq0 (ORCPT ); Wed, 8 Jan 2020 11:46:26 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id A108220034; Wed, 8 Jan 2020 17:46:19 +0100 (CET) Date: Wed, 8 Jan 2020 17:46:18 +0100 From: Sam Ravnborg To: Arnd Bergmann Cc: Jani Nikula , Maarten Lankhorst , Maxime Ripard , Thierry Reding , David Airlie , Daniel Vetter , Andy Shevchenko , Randy Dunlap , Linus Walleij , Laurent Pinchart , Sean Paul , dri-devel , Maxime Ripard , Emil Velikov , Boris Brezillon , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] drm/drm_panel: fix export of drm_panel_of_backlight, try #3 Message-ID: <20200108164618.GA28588@ravnborg.org> References: <20200107203231.920256-1-arnd@arndb.de> <87zheyqnla.fsf@intel.com> <20200108100831.GA23308@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=eMA9ckh1 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=A96CT9EkDcBwBZB6U8IA:9 a=CjuIK1q_8ugA:10 a=Z5ABNNGmrOfJ6cZ5bIyy:22 a=bWyr8ysk75zN3GCy5bjg:22 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd. > > > All of this is just another hack until the backlight config usage is > > > fixed for good. Do we really want to make this the example to copy paste > > > wherever we hit the issue next? > > > > > > I'm not naking, but I'm not acking either. > > > > I will try to take a look at your old BACKLIGHT_CLASS_DEVICE patch this > > weekend. I think we need that one fixed - and then we can have this mess > > with "drm_panel_of_backlight" fixed in the right way. > > I had also attempted to fix the larger mess around 'select' statements in DRM/FB > around BACKLIGHT_CLASS_DEVICE several times in the past, and even at > some point sent a patch that was acked but never merged and later broke because > of other changes. Any chance you have the patch around or can dig up a pointer? My google foo did not turn up anything. Sam