Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp974866ybl; Wed, 8 Jan 2020 08:53:26 -0800 (PST) X-Google-Smtp-Source: APXvYqyQ7rJAVaGcAG6OB6hEP5PNmeJb60f7NJ1ruDTbFz7JQwNgk4mc0bVCnCL+xuEiJ6qHzlAH X-Received: by 2002:a9d:7d85:: with SMTP id j5mr5011979otn.86.1578502406276; Wed, 08 Jan 2020 08:53:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578502406; cv=none; d=google.com; s=arc-20160816; b=T3E0J7zpk+2OEhqTsar4HVFMtndnfzBWjBFo4Bmh6MKBA0CHIJAtJwI8yTqHqCklTH zqzqIfcdo8OAvwtvnD8oLgJSrHv0CCghhG9IHp0KtFiWPzvOTZNrODaamNtTlNLIc4zX n8QsPUTuuwTYFO4Q54R4iUZhL3FkXzPQF3HqnitLvC+ZyAx6Zz+3O/ggM7zQrBMY7/+Y VJSdeAH1x+/XP7LlYu8GS/5StD2oBWu2OflCNEpANP0/lNs8lUKLYGHwzFkphcmNtPf/ WWbw0SERZq956AoPtYC6/+xJYUcanATmGBl53SJ4sWpGWMLyWlX+cK0fcIaSqu8EPkJT ba4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=cMQF1OFkSUD0j5rSVKSns4Pm6PXDZg9JYLZA2SLkfR4=; b=o5nHYqiBFEOMRCwp6olKIbF9AMDZ7SLs6VWh57/dGBXqtbVshlpi5qhSfJ2+Z3ulZ6 kXxNk9ahGWXIZajTS5jctnVbpsDk9YwwVp9WwUwEn2mnMzWlBP0jLHOjzX7fy+wcCk7o KSYV6B4MfQ98/NQ2L5TeWGUfgbPz5ww8lcmZFw4nEtS95r1sB68Q/KGVN9aOVuJB9/Tx Qd6+K+qwlCP6+vlKjJ0If/JcuMaYn2tTYsdSFFDIbV3+Ki52LzXKXh15FU2fEQsXFF0I 5U1rDA0XJaPfZxZBGUAdeamxKRhy24bKhd1KQc3Tic71NWPi2l5K+maiLEcId3Es9nnV P19g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OEWjaIOs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r22si1997016otn.192.2020.01.08.08.53.13; Wed, 08 Jan 2020 08:53:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=OEWjaIOs; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729064AbgAHQwZ (ORCPT + 99 others); Wed, 8 Jan 2020 11:52:25 -0500 Received: from mail.kernel.org ([198.145.29.99]:50368 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727606AbgAHQwZ (ORCPT ); Wed, 8 Jan 2020 11:52:25 -0500 Received: from willie-the-truck (236.31.169.217.in-addr.arpa [217.169.31.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2243420678; Wed, 8 Jan 2020 16:52:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1578502344; bh=gr74FHTiieCttQT9nIGhGKdVo2KGuUdcTqpLjQlvpBk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OEWjaIOs21VxjS0qPRpVwIJHHcomsxWvOmWeG4EQLnBsTyzjCJ0+eyTseRpprZvd6 IwFwDiEwPOScxfsmRACklwLKCzTZwunyD6+oZQdbxkErZeXygUyF0fTrqWm+ir1czK Biu5bvZgmTVwPxT9LUFyOCUTmDOqOJrn9/swa3gE= Date: Wed, 8 Jan 2020 16:52:15 +0000 From: Will Deacon To: AKASHI Takahiro Cc: catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org, frowand.list@gmail.com, kexec@lists.infradead.org, james.morse@arm.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/2] libfdt: include fdt_addresses.c Message-ID: <20200108165214.GA19760@willie-the-truck> References: <20191209030345.5735-1-takahiro.akashi@linaro.org> <20191209030345.5735-2-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191209030345.5735-2-takahiro.akashi@linaro.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 09, 2019 at 12:03:44PM +0900, AKASHI Takahiro wrote: > In the implementation of kexec_file_loaded-based kdump for arm64, > fdt_appendprop_addrrange() will be needed. > > So include fdt_addresses.c in making libfdt. > > Signed-off-by: AKASHI Takahiro > Cc: Rob Herring > Cc: Frank Rowand > --- > lib/Makefile | 2 +- > lib/fdt_addresses.c | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) > create mode 100644 lib/fdt_addresses.c I'd like to take this via arm64 and it looks like it follows what we do for other fdt files under lib/. Rob, Frank -- are you ok with me picking this up, please? Will > diff --git a/lib/Makefile b/lib/Makefile > index 93217d44237f..c20b1debe9b4 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -223,7 +223,7 @@ KASAN_SANITIZE_stackdepot.o := n > KCOV_INSTRUMENT_stackdepot.o := n > > libfdt_files = fdt.o fdt_ro.o fdt_wip.o fdt_rw.o fdt_sw.o fdt_strerror.o \ > - fdt_empty_tree.o > + fdt_empty_tree.o fdt_addresses.o > $(foreach file, $(libfdt_files), \ > $(eval CFLAGS_$(file) = -I $(srctree)/scripts/dtc/libfdt)) > lib-$(CONFIG_LIBFDT) += $(libfdt_files) > diff --git a/lib/fdt_addresses.c b/lib/fdt_addresses.c > new file mode 100644 > index 000000000000..23610bcf390b > --- /dev/null > +++ b/lib/fdt_addresses.c > @@ -0,0 +1,2 @@ > +#include > +#include "../scripts/dtc/libfdt/fdt_addresses.c" > -- > 2.24.0