Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Horia Geanta <horia.geanta@nxp.com>
To:     Iuliana Prodan <iuliana.prodan@nxp.com>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        Aymen Sghaier <aymen.sghaier@nxp.com>
CC:     "David S. Miller" <davem@davemloft.net>,
        "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH v2 06/10] crypto: caam - refactor caam_jr_enqueue
Thread-Topic: [PATCH v2 06/10] crypto: caam - refactor caam_jr_enqueue
Thread-Index: AQHVwdGz6i/Y7lkd70GPiPG71gFRzw==
Date:   Wed, 8 Jan 2020 16:59:51 +0000
Message-ID: <VI1PR0402MB34852528A105E1C472686078983E0@VI1PR0402MB3485.eurprd04.prod.outlook.com>
References: <1578013373-1956-1-git-send-email-iuliana.prodan@nxp.com>
 <1578013373-1956-7-git-send-email-iuliana.prodan@nxp.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4c5bd083-0769-4dc9-8a55-08d7945c2d3c
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2020 16:59:51.2559
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pmF7VHUoa13+rboWoUj19BeyrzgCc74IpqzTgM+uEeb3COpcFcHny8OmW3Duj0t2s+ZeYpQHyK5svg2nptQPeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0402MB3855
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 1/3/2020 3:04 AM, Iuliana Prodan wrote:=0A=
> Added a new struct - caam_{skcipher, akcipher, ahash, aead}_request_entry=
,=0A=
> to keep each request information. This has a specific crypto request and=
=0A=
> a bool to check if the request has backlog flag or not.=0A=
> This struct is passed to CAAM, via enqueue function - caam_jr_enqueue.=0A=
> =0A=
> This is done for later use, on backlogging support in CAAM.=0A=
[...]=0A=
> diff --git a/drivers/crypto/caam/caamalg.c b/drivers/crypto/caam/caamalg.=
c=0A=
> index 21b6172..34662b4 100644=0A=
> --- a/drivers/crypto/caam/caamalg.c=0A=
> +++ b/drivers/crypto/caam/caamalg.c=0A=
> @@ -871,6 +871,17 @@ static int xts_skcipher_setkey(struct crypto_skciphe=
r *skcipher, const u8 *key,=0A=
>  }=0A=
>  =0A=
>  /*=0A=
> + * caam_aead_request_entry - storage for tracking each aead request=0A=
> + *                           that is processed by a ring=0A=
> + * @base: common attributes for aead requests=0A=
> + * @bklog: stored to determine if the request needs backlog=0A=
> + */=0A=
> +struct caam_aead_request_entry {=0A=
> +	struct aead_request *base;=0A=
> +	bool bklog;=0A=
> +};=0A=
> +=0A=
> +/*=0A=
>   * aead_edesc - s/w-extended aead descriptor=0A=
>   * @src_nents: number of segments in input s/w scatterlist=0A=
>   * @dst_nents: number of segments in output s/w scatterlist=0A=
> @@ -878,6 +889,7 @@ static int xts_skcipher_setkey(struct crypto_skcipher=
 *skcipher, const u8 *key,=0A=
>   * @mapped_dst_nents: number of segments in output h/w link table=0A=
>   * @sec4_sg_bytes: length of dma mapped sec4_sg space=0A=
>   * @sec4_sg_dma: bus physical mapped address of h/w link table=0A=
> + * @jrentry: information about the current request that is processed by =
a ring=0A=
>   * @sec4_sg: pointer to h/w link table=0A=
>   * @hw_desc: the h/w job descriptor followed by any referenced link tabl=
es=0A=
>   */=0A=
> @@ -888,11 +900,23 @@ struct aead_edesc {=0A=
>  	int mapped_dst_nents;=0A=
>  	int sec4_sg_bytes;=0A=
>  	dma_addr_t sec4_sg_dma;=0A=
> +	struct caam_aead_request_entry jrentry;=0A=
>  	struct sec4_sg_entry *sec4_sg;=0A=
>  	u32 hw_desc[];=0A=
>  };=0A=
>  =0A=
Now that most of the backlogging logic moved from the backend (jr.c)=0A=
to frontends (caamalg.c, caamhash.c etc.), it looks like there's no need fo=
r=0A=
all the *_request_entry structures.=0A=
Instead, bklog flag could be added directly into the corresponding=0A=
*_edesc structure.=0A=
=0A=
Horia=0A=