Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1019495ybl; Wed, 8 Jan 2020 09:35:50 -0800 (PST) X-Google-Smtp-Source: APXvYqw9N4dcBwbhXYHY1TBobQjdkg8vWLlJgQW2whZm5BgHQvHCD29pg/+sfg16SgX78+G8R228 X-Received: by 2002:a9d:68d3:: with SMTP id i19mr4714036oto.71.1578504950276; Wed, 08 Jan 2020 09:35:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578504950; cv=none; d=google.com; s=arc-20160816; b=XWKyQiaun1QGNhQgYL8UQDnyGvOHRug4OmmvtJ5hVRHj+JbaBvMc2FjIiP2Ljhhpws 7JRyqXV9z6ZSHcTl7gIut3NIZ9Jf7HwYlkIAzZTVIsBvU1DUQbUi742RNz1k4oH23xBk 7i8HPIM3sBCeaf062qvafonJC8HuHC+uYzxoV9UpsjtKK48gE5C6WKwnqndeahCJxRgZ 0RzWNNg0/FGrV6dA/vCgEx90/hbGmY/rxDcf2iCasCBop361V5NawFqoAsgAQvrxMoGF O9VyeHMPiGuKassuMoEIk09JLgwIQIh5fVNRr0rJ7Plfq+tDhXEM31c4FrOm2Dqk2g5W laZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=njpKt29+dtaFIGch37CbQfR9p/8Y8+c4taa6G2JbP78=; b=wnxAK4dcKk6D5H8VMZPazj/26+Zn/o/RoV1E7AGQnFw7juFvVWm72faVDQaR7GIQuJ T8R7va7vuU9U41aJmbrEbbvwpkkkRCqO9WgQl46vbKRSDXHKGIzNklefNr9soobK2bVe bg/cVuMZ5Ljgg67zHcE37yVjivsOWWyCeUuLJp5KUbkPf8YdXmPvIqkUKdJ3KlvXVxgQ ad8qgdzdizaZCshvs5CcPTStwc786mWHdjqnjKYpzHig4BNR5kTDuXpKEz21VqgOEcpf 9ujqikej0sdsYPTgu7LVvChzpAUgEafb9kbfQGuTmIDOiIrK7reUkblLYFRQYVTpATzE l5tA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=obzMdnPS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p6si2148901oig.88.2020.01.08.09.35.37; Wed, 08 Jan 2020 09:35:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@ti.com header.s=ti-com-17Q1 header.b=obzMdnPS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=NONE dis=NONE) header.from=ti.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728230AbgAHObg (ORCPT + 99 others); Wed, 8 Jan 2020 09:31:36 -0500 Received: from lelv0143.ext.ti.com ([198.47.23.248]:36972 "EHLO lelv0143.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbgAHObe (ORCPT ); Wed, 8 Jan 2020 09:31:34 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 008EVWMl065317; Wed, 8 Jan 2020 08:31:32 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1578493892; bh=njpKt29+dtaFIGch37CbQfR9p/8Y8+c4taa6G2JbP78=; h=From:To:CC:Subject:Date:In-Reply-To:References; b=obzMdnPSxS72O5adfld/iyMe/74tNXPG2uoTAFBfiisq/ezsr847baYqGn4akMNx4 Soi+XpqWxTO67skHf38hQidGsGzhZ5TqWkwu3paTY4+wH+Ne6vJgkMxzkYYGC0fTMj unvJkDBzPdWOfb3GECDcN0jcbNduSmvD3Fn1F/hk= Received: from DFLE114.ent.ti.com (dfle114.ent.ti.com [10.64.6.35]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 008EVWWs056097 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 8 Jan 2020 08:31:32 -0600 Received: from DFLE115.ent.ti.com (10.64.6.36) by DFLE114.ent.ti.com (10.64.6.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Wed, 8 Jan 2020 08:31:32 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Wed, 8 Jan 2020 08:31:32 -0600 Received: from a0230074-OptiPlex-7010.india.ti.com (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 008EVS9V112013; Wed, 8 Jan 2020 08:31:30 -0600 From: Faiz Abbas To: , CC: , , Subject: [PATCH 1/3] mmc: sdhci_am654: Remove Inverted Write Protect flag Date: Wed, 8 Jan 2020 20:02:59 +0530 Message-ID: <20200108143301.1929-2-faiz_abbas@ti.com> X-Mailer: git-send-email 2.19.2 In-Reply-To: <20200108143301.1929-1-faiz_abbas@ti.com> References: <20200108143301.1929-1-faiz_abbas@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The MMC/SD controllers on am65x and j721e don't in fact detect the write protect line as inverted. No issues were detected because of this because the sdwp line is not connected on any of the evms. Fix this by removing the flag. Fixes: 1accbced1c32 ("mmc: sdhci_am654: Add Support for 4 bit IP on J721E") Cc: stable@vger.kernel.org Signed-off-by: Faiz Abbas --- drivers/mmc/host/sdhci_am654.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/sdhci_am654.c b/drivers/mmc/host/sdhci_am654.c index b8e897e31e2e..2d38b1e12a7e 100644 --- a/drivers/mmc/host/sdhci_am654.c +++ b/drivers/mmc/host/sdhci_am654.c @@ -253,8 +253,7 @@ static struct sdhci_ops sdhci_am654_ops = { static const struct sdhci_pltfm_data sdhci_am654_pdata = { .ops = &sdhci_am654_ops, - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, }; @@ -290,8 +289,7 @@ static struct sdhci_ops sdhci_j721e_8bit_ops = { static const struct sdhci_pltfm_data sdhci_j721e_8bit_pdata = { .ops = &sdhci_j721e_8bit_ops, - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, }; @@ -314,8 +312,7 @@ static struct sdhci_ops sdhci_j721e_4bit_ops = { static const struct sdhci_pltfm_data sdhci_j721e_4bit_pdata = { .ops = &sdhci_j721e_4bit_ops, - .quirks = SDHCI_QUIRK_INVERTED_WRITE_PROTECT | - SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, + .quirks = SDHCI_QUIRK_MULTIBLOCK_READ_ACMD12, .quirks2 = SDHCI_QUIRK2_PRESET_VALUE_BROKEN, }; -- 2.19.2