Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authorized-sender: andreas@gaisler.com
Subject: Re: [PATCH 2/2] gpio: gpio-grgpio: fix possible
 sleep-in-atomic-context bugs in grgpio_irq_map/unmap()
To:     Linus Walleij <linus.walleij@linaro.org>,
        Jia-Ju Bai <baijiaju1990@gmail.com>
Cc:     Bartosz Golaszewski <bgolaszewski@baylibre.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <20191218132605.10594-1-baijiaju1990@gmail.com>
 <CACRpkdY4JsvOsjQvB=hb=QPV=bLXkC3ekmPUXFiPMnj1NK-Jtg@mail.gmail.com>
From:   Andreas Larsson <andreas@gaisler.com>
Message-ID: <74268192-4d4f-8019-804e-49b34ec52787@gaisler.com>
Date:   Wed, 8 Jan 2020 15:41:41 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <CACRpkdY4JsvOsjQvB=hb=QPV=bLXkC3ekmPUXFiPMnj1NK-Jtg@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2020-01-07 10:37, Linus Walleij wrote:
> However there is a deeper problem, this code was added by Andreas
> Larsson in 2013 and at the time this was a hacky way to deal with
> an interrupt that is actually hierarchical.
> 
> Since 2013 we have gained:
> - Hierarchical interrupt controllers
> - Hierarchical interrupt chip helpers in gpiolib
> 
> So this code really needs to be modernized using a hierarchical
> irqchip.
> 
> See for example commit:
> aa7d618ac65f ("gpio: ixp4xx: Convert to hierarchical GPIOLIB_IRQCHIP")
> for an example.
> 
> Who is using grgpio these days and could work on fixing this up?

I will put on my list to look into this. GRGPIO is used in all our 
chips, and in most designs made by our customers.

The main hurdle with the interrupt handling in the current driver was to 
both allow several lines to generate the same system interrupt and at 
the same time make sure to not register any system interrupts for any 
lines until the user actually requests it (as in the general case all 
interrupts would be registered leading to clashes with interrupts that 
cannot necessarily be shared). Hopefully, the hierarchical interrupt 
controller and chip helper functionalities can cater for these requirements.

Best regards,
Andreas Larsson