Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 8 Jan 2020 15:50:56 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Saravanan Sekar <sravanhome@gmail.com>
Cc:     lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
        mripard@kernel.org, shawnguo@kernel.org, heiko@sntech.de,
        sam@ravnborg.org, icenowy@aosc.io,
        laurent.pinchart@ideasonboard.com, gregkh@linuxfoundation.org,
        Jonathan.Cameron@huawei.com, davem@davemloft.net,
        mchehab+samsung@kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] regulator: mpq7920: add mpq7920 regulator driver
Message-ID: <20200108155056.GA4036@sirena.org.uk>
References: <20200108131234.24128-1-sravanhome@gmail.com>
 <20200108131234.24128-4-sravanhome@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="Q68bSM7Ycu6FN28Q"
Content-Disposition: inline
In-Reply-To: <20200108131234.24128-4-sravanhome@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--Q68bSM7Ycu6FN28Q
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Wed, Jan 08, 2020 at 02:12:33PM +0100, Saravanan Sekar wrote:

> +	for_each_child_of_node(np, child) {
> +		for (i = 0; i <= MPQ7920_BUCK4; i++) {
> +			struct regulator_desc *rdesc = &info->rdesc[i];
> +
> +			if (strcmp(rdesc->name, child->name))
> +				continue;

You can replace this loop with an of_parse_cb callback, please send an
incremental patch doing this.

--Q68bSM7Ycu6FN28Q
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4V+loACgkQJNaLcl1U
h9COqwf/fFpfXig6rh7ARcurwTgTV49oOWEbpumCuN5gZAi1vxKX7avl4APGbadS
jvOJPUCAxapnVoKqG43Y+SkZyz8Tu6pDz7yaGbSvo91UayuEbwkTy5edLuxld1cV
0x6Jv4WQo6Kz7XMypUI9Zi8ahxS8ZnA5WJvCMveRa16uC7DeBpoYVhr2Q8TEcHZQ
oulZOkT+j2y049GY3ZHTSdg6PAgu+XlfFXoppg2Unqwfpb8C6/IdPgW6mvEJgdTY
ZukNejDLOsvG8bnc4VeZ/5y8qlG65DkBJDYfIpOqQVVcQbvR7jNk0eSWf7/o27FJ
U6r8PglFKgzEtFa0MLLDrvZE2rpK0w==
=0O/A
-----END PGP SIGNATURE-----

--Q68bSM7Ycu6FN28Q--