Message-ID: <43DA851D.6070209@cfl.rr.com>
Date: Fri, 27 Jan 2006 15:39:57 -0500
From: Phillip Susi <psusi@cfl.rr.com>
User-Agent: Thunderbird 1.5 (Windows/20051201)
MIME-Version: 1.0
To: jmerkey@ns1.utah-nac.org
CC: "linux-os (Dick Johnson)" <linux-os@analogic.com>,
       "Jeff V. Merkey" <jmerkey@wolfmountaingroup.com>,
       linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.14 kernels and above copy_to_user stupidity with IRQ disabled
 check
References: <43DA62CC.8090309@wolfmountaingroup.com> <Pine.LNX.4.61.0601271513360.15124@chaos.analogic.com> <20060127201058.GA18805@ns1.utah-nac.org>
In-Reply-To: <20060127201058.GA18805@ns1.utah-nac.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 806
Lines: 21

jmerkey@ns1.utah-nac.org wrote:
> OK.  Got it.  I guess I need to restructure.  And BTW, This was a code fragment
> only, the spinlock gets released when -EFAULT is called -- was just an example.
>
> Jeff

Unless you have redefined EFAULT in some strange and hideous way, it is 
not "called" and doesn't free the spinlock.  EFAULT is defined as a 
literal integer, so you're just returning a number without freeing the 
spinlock. 


If you have redefined EFAULT to a macro function call or whatever, then 
don't do that, it's REALLY horrible coding practice. 


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/