Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <CGME20191220062733epcas1p31665a3ae968ab8c70d91a3cddf529e73@epcas1p3.samsung.com>
 <20191220062419.23516-1-namjae.jeon@samsung.com> <20191220062419.23516-3-namjae.jeon@samsung.com>
In-Reply-To: <20191220062419.23516-3-namjae.jeon@samsung.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 8 Jan 2020 20:55:44 +0100
Message-ID: <CAK8P3a1wcrKzhhODwoQTu=WHorkd+dQThk+G9w77QSgJ=LnR4A@mail.gmail.com>
Subject: Re: [PATCH v8 02/13] exfat: add super block operations
To:     Namjae Jeon <namjae.jeon@samsung.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Linux FS-devel Mailing List <linux-fsdevel@vger.kernel.org>,
        gregkh <gregkh@linuxfoundation.org>,
        Valdis Kletnieks <valdis.kletnieks@vt.edu>,
        Christoph Hellwig <hch@lst.de>, sj1557.seo@samsung.com,
        linkinjeon@gmail.com
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 20, 2019 at 7:28 AM Namjae Jeon <namjae.jeon@samsung.com> wrote:

> +static int exfat_fill_super(struct super_block *sb, struct fs_context *fc)
> +{
> +       struct exfat_sb_info *sbi = sb->s_fs_info;
> +       struct exfat_mount_options *opts = &sbi->options;
> +       struct inode *root_inode;
> +       int err;
> +
> +       if (opts->allow_utime == (unsigned short)-1)
> +               opts->allow_utime = ~opts->fs_dmask & 0022;
> +
> +       if (opts->utf8 && strcmp(opts->iocharset, exfat_iocharset_with_utf8)) {
> +               exfat_msg(sb, KERN_WARNING,
> +                       "utf8 enabled, \"iocharset=%s\" is recommended",
> +                       exfat_iocharset_with_utf8);
> +       }
> +
> +       if (opts->discard) {
> +               struct request_queue *q = bdev_get_queue(sb->s_bdev);
> +
> +               if (!blk_queue_discard(q))
> +                       exfat_msg(sb, KERN_WARNING,
> +                               "mounting with \"discard\" option, but the device does not support discard");
> +               opts->discard = 0;
> +       }
> +
> +       sb->s_flags |= SB_NODIRATIME;
> +       sb->s_magic = EXFAT_SUPER_MAGIC;
> +       sb->s_op = &exfat_sops;

I don't see you set up s_time_gran, s_time_min and s_time_max
anywhere. Please fill those to get the correct behavior. That also lets
you drop the manual truncation of the values.

       Arnd