Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of mellanox.com designates
 193.47.165.251 as permitted sender) receiver=protection.outlook.com;
 client-ip=193.47.165.251; helo=mtlcas13.mtl.com;
Subject: Re: [PATCH v10 6/9] nvme: Export existing nvme core functions
To:     Logan Gunthorpe <logang@deltatee.com>,
        <linux-kernel@vger.kernel.org>, <linux-nvme@lists.infradead.org>
CC:     Sagi Grimberg <sagi@grimberg.me>,
        Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
        Stephen Bates <sbates@raithlin.com>, Jens Axboe <axboe@fb.com>,
        Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
References: <20200108174030.3430-1-logang@deltatee.com>
 <20200108174030.3430-7-logang@deltatee.com>
From:   Max Gurtovoy <maxg@mellanox.com>
Message-ID: <707b39a3-b58a-44b7-7ffa-0c2bd3f28e21@mellanox.com>
Date:   Wed, 8 Jan 2020 23:48:42 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.1
MIME-Version: 1.0
In-Reply-To: <20200108174030.3430-7-logang@deltatee.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jan 2020 21:48:53.9118
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: f62e60a2-f726-46f7-ac7e-08d794848e59
X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=a652971c-7d2e-4d9b-a6a4-d149256f461b;Ip=[193.47.165.251];Helo=[mtlcas13.mtl.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0502MB2904
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 1/8/2020 7:40 PM, Logan Gunthorpe wrote:
> Export nvme_put_ns(), nvme_command_effects(), nvme_execute_passthru_rq()
> and nvme_find_get_ns() for use in the nvmet passthru code.
>
> The exports are conditional on CONFIG_NVME_TARGET_PASSTHRU.
>
> Based-on-a-patch-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> ---
>   drivers/nvme/host/core.c | 14 +++++++++-----
>   drivers/nvme/host/nvme.h |  5 +++++
>   2 files changed, 14 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index d7912e7a9911..037415882d46 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -463,7 +463,7 @@ static void nvme_free_ns(struct kref *kref)
>   	kfree(ns);
>   }
>   
> -static void nvme_put_ns(struct nvme_ns *ns)
> +void nvme_put_ns(struct nvme_ns *ns)
>   {
>   	kref_put(&ns->kref, nvme_free_ns);
>   }
> @@ -896,8 +896,8 @@ static void *nvme_add_user_metadata(struct bio *bio, void __user *ubuf,
>   	return ERR_PTR(ret);
>   }
>   
> -static u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> -				u8 opcode)
> +u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> +			 u8 opcode)
>   {
>   	u32 effects = 0;
>   
> @@ -982,7 +982,7 @@ static void nvme_passthru_end(struct nvme_ctrl *ctrl, u32 effects)
>   		nvme_queue_scan(ctrl);
>   }
>   
> -static void nvme_execute_passthru_rq(struct request *rq)
> +void nvme_execute_passthru_rq(struct request *rq)
>   {
>   	struct nvme_command *cmd = nvme_req(rq)->cmd;
>   	struct nvme_ctrl *ctrl = nvme_req(rq)->ctrl;
> @@ -3441,7 +3441,7 @@ static int ns_cmp(void *priv, struct list_head *a, struct list_head *b)
>   	return nsa->head->ns_id - nsb->head->ns_id;
>   }
>   
> -static struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid)
> +struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned nsid)
>   {
>   	struct nvme_ns *ns, *ret = NULL;
>   
> @@ -4225,6 +4225,10 @@ EXPORT_SYMBOL_GPL(nvme_sync_queues);
>    * use by the nvmet-passthru and should not be used for
>    * other things.
>    */
> +EXPORT_SYMBOL_GPL(nvme_put_ns);
> +EXPORT_SYMBOL_GPL(nvme_command_effects);
> +EXPORT_SYMBOL_GPL(nvme_execute_passthru_rq);
> +EXPORT_SYMBOL_GPL(nvme_find_get_ns);

Since this is the convention in the driver, can you export the symbols 
at the end of each function ?

Otherwise looks good,

Reviewed-by: Max Gurtovoy <maxg@mellanox.com>


>   
>   struct nvme_ctrl *nvme_ctrl_get_by_path(const char *path)
>   {
> diff --git a/drivers/nvme/host/nvme.h b/drivers/nvme/host/nvme.h
> index 356e4062796e..b1b1e7dd866b 100644
> --- a/drivers/nvme/host/nvme.h
> +++ b/drivers/nvme/host/nvme.h
> @@ -687,6 +687,11 @@ static inline void nvme_hwmon_init(struct nvme_ctrl *ctrl) { }
>    * use by the nvmet-passthru and should not be used for
>    * other things.
>    */
> +void nvme_put_ns(struct nvme_ns *ns);
> +u32 nvme_command_effects(struct nvme_ctrl *ctrl, struct nvme_ns *ns,
> +			 u8 opcode);
> +void nvme_execute_passthru_rq(struct request *rq);
> +struct nvme_ns *nvme_find_get_ns(struct nvme_ctrl *ctrl, unsigned int nsid);
>   struct nvme_ctrl *nvme_ctrl_get_by_path(const char *path);
>   #endif /* CONFIG_NVME_TARGET_PASSTHRU */
>