Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1288577ybl; Wed, 8 Jan 2020 14:33:19 -0800 (PST) X-Google-Smtp-Source: APXvYqxjDxi1JkKQydR0hesUtdqBDSuGHgFHlu1h6S6bSWX9EnjqW7F0rD70K87zPEAkphfbzZpQ X-Received: by 2002:aca:1801:: with SMTP id h1mr796391oih.16.1578522799590; Wed, 08 Jan 2020 14:33:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578522799; cv=none; d=google.com; s=arc-20160816; b=VDTrWQfpWnW8PvfsvK/83ekW/WgHJt98+82/1aW949fme9cGgdcydFDzU8J2cAJXLU MLrGnj3GqbxQ+MxPknnEKu7CNlMoqx9JIhQVk0qTOmYkY3Pjn2wlGb9Pifg9lGHtBCDP 37zG1GrKXkzTOgvrelzikvKD4klG2Kxfw+wM4CW9hftR9zm+zo/wXjqwFYvh+7L3EiUB IbMaRkLBb6s/5bLdFLe5QYTYsnfp//XntD5vdynLKnb00WXsI+Uxo775v7GKgPudZLy5 xJK0Ya6ZL7h5E5By1fA5hPzWEJV5C06SgjxSTOcDzzYHlquFvpEXb5mXOZjUeWuKPP8B PLaQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=hHJ9jOeyYoWsntkHCwET4nvtfDHkKOy66q0FV3P1f+Q=; b=Gf9YT3ZUBKD1ASIsVCAWVIjX9nITw6MqelwQmTUE08qLs9A3XdO5JOj3irS8Fe2p8a kurUt2bs5U/GBPodGwho5dZVdZBYWMl7SSEyPklbqTEMsQX+O2oa5uMtIzWzDNu4ISfS 4f0POx08WRkgCokQRlBZ0AjPiwLLk4kTNTRawTSoPxmfXxczA7HAF3vIAkeN1iu2Kt1i 4qhtFI6G8PLwh8VOWR7N5cSRtRNRQL21+kAlC3Pzdfly3AC62ashfmABTXIkeEABT969 gQvvX8v8Ehe/XYyJ3ELoRiiQAhGYhEObDIUH/5RqGIK8NFmro1XQ+S0nwMOkxPHf8TBv KwLA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si2651181otq.137.2020.01.08.14.33.07; Wed, 08 Jan 2020 14:33:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727352AbgAHWcU (ORCPT + 99 others); Wed, 8 Jan 2020 17:32:20 -0500 Received: from correo.us.es ([193.147.175.20]:55664 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726390AbgAHWcU (ORCPT ); Wed, 8 Jan 2020 17:32:20 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id D280EC514C for ; Wed, 8 Jan 2020 23:32:16 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id C7CA5DA713 for ; Wed, 8 Jan 2020 23:32:16 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id BBB9CDA70E; Wed, 8 Jan 2020 23:32:16 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id A888ADA705; Wed, 8 Jan 2020 23:32:14 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 08 Jan 2020 23:32:14 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 89BBF426CCB9; Wed, 8 Jan 2020 23:32:14 +0100 (CET) Date: Wed, 8 Jan 2020 23:32:14 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Florian Westphal Cc: netfilter-devel@vger.kernel.org, syzkaller-bugs@googlegroups.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, syzbot+46a4ad33f345d1dd346e@syzkaller.appspotmail.com Subject: Re: [PATCH nf] netfilter: conntrack: dccp, sctp: handle null timeout argument Message-ID: <20200108223214.3niyo2o2sr2zf3fg@salvia> References: <0000000000009cd5e0059b7eb836@google.com> <20200106223417.18279-1-fw@strlen.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200106223417.18279-1-fw@strlen.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 06, 2020 at 11:34:17PM +0100, Florian Westphal wrote: > The timeout pointer can be NULL which means we should modify the > per-nets timeout instead. > > All do this, except sctp and dccp which instead give: > > general protection fault: 0000 [#1] PREEMPT SMP KASAN > net/netfilter/nf_conntrack_proto_dccp.c:682 > ctnl_timeout_parse_policy+0x150/0x1d0 net/netfilter/nfnetlink_cttimeout.c:67 > cttimeout_default_set+0x150/0x1c0 net/netfilter/nfnetlink_cttimeout.c:368 > nfnetlink_rcv_msg+0xcf2/0xfb0 net/netfilter/nfnetlink.c:229 > netlink_rcv_skb+0x177/0x450 net/netlink/af_netlink.c:2477 Applied, thanks Florian.