Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1523456ybl; Wed, 8 Jan 2020 19:34:27 -0800 (PST) X-Google-Smtp-Source: APXvYqzE2KFC/H/UPLYwN0KSVa7KucS/mFLNPGakNWiPNRuA8vPrLgp6+rcCLjfnWyt0Ja7tfbHc X-Received: by 2002:a9d:5c86:: with SMTP id a6mr6995581oti.68.1578540866826; Wed, 08 Jan 2020 19:34:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578540866; cv=none; d=google.com; s=arc-20160816; b=CeuWs4r/xRCyXWoLeqGAyS3TJoKNyWaOWfKv9J1XmNKINAKy6p3A9ZVBYwZgAhyxn0 5nQs0Ft9Pr0FtH5o/Uohk2wHaD+TPc9tFs30/8KFRzxd955krQsLYIL8AGdB7reCtgeZ 75KVhiu11VLwsb3dqII9Keddk/oEldVTuMZ6oU1aKY3DHhQoaKLR2z6UQk3VvE3pW7cA JNzEOmeVFzs6hjTZ+j/rsutAQ+dF2iiqi9+/tFJ8mfBP5ZRqo8PZfCLjZEnE1hr6CYMX rxP2v3dkmHnXoGmH+n8V44c9tu5DhCVm0MHehcOesoOoVLzmXM1AiWOQDjuoUwzYsfzS OXHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=VZ2TqqhPaSVHPFCAp9VkRzjFCSnuYTScC7/s8agUkio=; b=CgW3Kv4scqiV8IdwWAolIRmoTOARpRzPqoLK+jPVgfr+xPh1FZQRPWn3h8xEXePzWN xuJw/rDmmVUxCCO37ZqqMl6hlijV0MjZKhYvnClXaDbiZAwzhqV3JXo6gMY5RlrGUuOV YQ8IjS8/I3HsW7jGIvookrXuSRbhpCJCZ7HHQ2Rie+Shw71q7Vxn+gjOyaekM41pXFOB S0bzganUrSBtw3bp3kAgSv7utExpT4i0NH+dozIufV0a4pKycRRyVlnaQK4OPfqnirm5 fRz1kctnfbYXoRlfUcZ/nI9fjEztcaSOWcBQmx8+t7Pl9prYs15PmIb4JQ72qwIGMf6r v0RQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b="fjyE/L+j"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q12si4267991otr.183.2020.01.08.19.34.09; Wed, 08 Jan 2020 19:34:26 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2019-08-05 header.b="fjyE/L+j"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727738AbgAIDdW (ORCPT + 99 others); Wed, 8 Jan 2020 22:33:22 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:46754 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726913AbgAIDdV (ORCPT ); Wed, 8 Jan 2020 22:33:21 -0500 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 0093X6ZQ172912; Thu, 9 Jan 2020 03:33:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2019-08-05; bh=VZ2TqqhPaSVHPFCAp9VkRzjFCSnuYTScC7/s8agUkio=; b=fjyE/L+jNX+n98vIuWlmkegIicSZka25fXXqO1N0OaEemyKeMKzZT0UyBvlSMvjESw/S C96XCfmhYBPaDucAw0Vz+pF9OWrZZmP82UpDN98Hp7Aq9oHVQAqjx+SaPP63YY19msNh ZtPXQkzjSPoc1QACp/6BaT+Pl8MKlhAzmSKHdyFzpLTHXu5Rz55O7vTfP9KnTBuTnj9n fxTrXAmYHMexVm7uOIj4NY8Zv5bJ9lFpGAHTy9nI2urV8mq3EItqeqR2BYBSeG62EgmY QQRCQKgJH13O91NdBKcy/lDtQLpv7MqH0qeGumW4Sx8s5HBsjjlPXqAg0fFZIJk1Gwiq vg== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 2xakbr00d4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Jan 2020 03:33:09 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 0093X9LJ106882; Thu, 9 Jan 2020 03:33:09 GMT Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by userp3030.oracle.com with ESMTP id 2xdmrx8p5g-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 09 Jan 2020 03:33:08 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 0093X3XP026880; Thu, 9 Jan 2020 03:33:04 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 08 Jan 2020 19:33:02 -0800 To: "hch\@lst.de" Cc: "Singh\, Balbir" , "linux-kernel\@vger.kernel.org" , "Chaitanya.Kulkarni\@wdc.com" , "linux-block\@vger.kernel.org" , "linux-nvme\@lists.infradead.org" , "jejb\@linux.ibm.com" , "mst\@redhat.com" , "axboe\@kernel.dk" , "Sangaraju\, Someswarudu" Subject: Re: [resend v1 4/5] drivers/nvme/host/core.c: Convert to use disk_set_capacity From: "Martin K. Petersen" Organization: Oracle Corporation References: <20200102075315.22652-1-sblbir@amazon.com> <20200102075315.22652-5-sblbir@amazon.com> <1b88bedc6d5435fa7154f3356fa3f1a3e6888ded.camel@amazon.com> <20200108150447.GC10975@lst.de> Date: Wed, 08 Jan 2020 22:33:00 -0500 In-Reply-To: <20200108150447.GC10975@lst.de> (hch@lst.de's message of "Wed, 8 Jan 2020 16:04:47 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9494 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=854 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001090033 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9494 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=915 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001090033 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Christoph, >> The expected behaviour is not clear, but the functionality is not >> broken, user space should be able to deal with a resize event where >> the previous capacity == new capacity IMHO. > > I think it makes sense to not bother with a notification unless there > is an actual change. I agree. -- Martin K. Petersen Oracle Linux Engineering