Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 9 Jan 2020 15:58:33 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Aapo Vienamo <aapo.vienamo@iki.fi>
Cc:     Rob Herring <robh+dt@kernel.org>,
        Mark Rutland <mark.rutland@arm.com>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        NXP Linux Team <linux-imx@nxp.com>,
        devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: mxs: Enable usbphy1 and usb1 on apx4devkit DTS
Message-ID: <20200109075832.GG4456@T480>
References: <20191229131503.20843-1-aapo.vienamo@iki.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191229131503.20843-1-aapo.vienamo@iki.fi>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Dec 29, 2019 at 03:15:03PM +0200, Aapo Vienamo wrote:
> Enable the USB host port on the APx4 development board.
> 
> Signed-off-by: Aapo Vienamo <aapo.vienamo@iki.fi>
> ---
>  arch/arm/boot/dts/imx28-apx4devkit.dts | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx28-apx4devkit.dts b/arch/arm/boot/dts/imx28-apx4devkit.dts
> index 3a184d13887b..f00d201ce242 100644
> --- a/arch/arm/boot/dts/imx28-apx4devkit.dts
> +++ b/arch/arm/boot/dts/imx28-apx4devkit.dts
> @@ -183,6 +183,12 @@ auart2: serial@8006e000 {
>  				pinctrl-0 = <&auart2_2pins_a>;
>  				status = "okay";
>  			};
> +
> +			usbphy1: usbphy@8007e000 {
> +				pinctrl-names = "default";
> +				pinctrl-0 = <&usb1_pins_a>;
> +				status = "okay";
> +			};
>  		};
>  	};
>  
> @@ -193,6 +199,10 @@ mac0: ethernet@800f0000 {
>  			pinctrl-0 = <&mac0_pins_a>;
>  			status = "okay";
>  		};
> +
> +		usb1: usb@80090000 {

We want to keep nodes with unit-address sorted in that address.  That
said, usb@80090000 should go before ethernet@800f0000.

Shawn

> +		      status = "okay";
> +		};
>  	};
>  
>  	regulators {
> -- 
> 2.24.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel