Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1773842ybl; Thu, 9 Jan 2020 01:10:53 -0800 (PST) X-Google-Smtp-Source: APXvYqwZLsrpXot8ayZt2Js9j+4t+GTvVdhWbjbFYujRRwQFST5fieEStRoielBVZE1YcQLUwYR3 X-Received: by 2002:a05:6830:1f19:: with SMTP id u25mr7988948otg.170.1578561053868; Thu, 09 Jan 2020 01:10:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578561053; cv=none; d=google.com; s=arc-20160816; b=BD75WGtI7mIsd/n1k4PLFy2wJh2NZ9H9x3gYvV7zdT0ZqYY1pK9yMdJtTo9EL9AtlG 941J1avJEMde52MRtvIzkSsYFxZI7QLzjYJicqTXOIqxEl23UgoYY3bOdh9Zde/YSNp4 XTKYtZYaggi+YccyPe8ssbJu1EmcwtHay6EYv0BFdB/4TPJ9klIEF3fqa4CLgQRBGLea g6xf1aWyQRCAnkW/Ur8FypvEDMImXg9wOBftSO9O2ZGQikdW0rCwrmfzqXeJuEdT32/g p4QYDsYnFxQyusTRg5dayfxHi/QTzDw5prDrWUmKfTnFzYqM+o511VU3WQQvHBeOtkUs VznQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=iWKF4KF9Y1CtiEun++0rxUUQMRPGqGyeC6hWhJkdSUc=; b=FYIyo/f4mza5SqGiaSK4d8a4hUf6FGXPcAUSroKwTV474cnEabZQlqtoKkjvjQP2hL gdqsnej1OqtyU0U4ScUx5gX3LsWVWJuwbiI79fAOraysH7rcG8XLPV9iPN3GlHZy8lN4 CtihusOwFtqjwxxTZD2msQ1hQ2calOppx3uEqaO7YOcx04c51zI+nbexsAY75JYMxogn DevixZaGwrhD/kCjO74Gbnzrn2YbOTphzYWUHSDRDQXGd8ICfEjvYE94fYT+MXuA3Ik1 zJ9x+sZXNMV0Wl4aS9d7SYQI67imRhHXghJzE0vQJgUkTd3ceivTzHD92SWgrkjeHgtE 99Fw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QGT9LAJa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id i10si3683385otk.195.2020.01.09.01.10.41; Thu, 09 Jan 2020 01:10:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=QGT9LAJa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728972AbgAIJI6 (ORCPT + 99 others); Thu, 9 Jan 2020 04:08:58 -0500 Received: from mail-qt1-f196.google.com ([209.85.160.196]:39855 "EHLO mail-qt1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728593AbgAIJI6 (ORCPT ); Thu, 9 Jan 2020 04:08:58 -0500 Received: by mail-qt1-f196.google.com with SMTP id e5so5278158qtm.6 for ; Thu, 09 Jan 2020 01:08:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iWKF4KF9Y1CtiEun++0rxUUQMRPGqGyeC6hWhJkdSUc=; b=QGT9LAJanjfXKoCERl6lGxDO5mX9gXrEuQ7sDttgSjCnzBSKSYfwnG4X9f+Ngw4O1v Jkhrpm+DlIJNPfdLLVhSKTc7QDIodBcyMEhHwaxzV8RY5q+Ffgk+1IFXnbZvNBlyfPV8 UQwFDYjv97NNGovIbt5sPou5JjNNOYGlmCfeQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iWKF4KF9Y1CtiEun++0rxUUQMRPGqGyeC6hWhJkdSUc=; b=Bsm4Kgu/A7I0kniu7qzo7UCzsJn150eOUkZ+LPx8JCsnUIcws3L4EIhr5vLR+RvsR0 ILB9LhVt/RjhTxHAtkV+u+k70/Pb7f8mzMPpDymGhCCNuzHJVaY+RAs8D8lccQadB9CV Qnqdy1YbhxH9Hi20bmLnYdEQGwNQL5p87zlJwHj4+m/sJxRCI09mbJZ2IkUOZ5jMuz0g 2+Y5dwc7GS56fo+CCuQ05PJjRggnlK1Wjp3N05a4QoKfbagniaGwBPAaPuiQoziNIoOX h8WUp3mrz/cF45JM3I1fS/0eWGfiM+FhhcrFiw2XuUYIvXHAvHR97nHOGwy95cjdyw3U 41SA== X-Gm-Message-State: APjAAAUFCxFX+s00acri+LFb7dut1w3esd6Vnfb1vShPA6IGmAtyRInm 6GB0eqfblfGyOs03x6FNkl8IXNsy2J4wgy9ksXrohQ== X-Received: by 2002:aed:2f45:: with SMTP id l63mr7382614qtd.221.1578560937298; Thu, 09 Jan 2020 01:08:57 -0800 (PST) MIME-Version: 1.0 References: <20200108052337.65916-1-drinkcat@chromium.org> In-Reply-To: <20200108052337.65916-1-drinkcat@chromium.org> From: Nicolas Boichat Date: Thu, 9 Jan 2020 17:08:46 +0800 Message-ID: Subject: Re: [PATCH v2 0/7] Add dts for mt8183 GPU (and misc panfrost patches) To: Rob Herring Cc: David Airlie , Daniel Vetter , Mark Rutland , Matthias Brugger , Tomeu Vizoso , Steven Price , Alyssa Rosenzweig , Liam Girdwood , Mark Brown , dri-devel , Devicetree List , lkml , linux-arm Mailing List , "moderated list:ARM/Mediatek SoC support" , Hsin-Yi Wang Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 8, 2020 at 1:23 PM Nicolas Boichat wrote: > > Hi! > > Sorry for the long delay since https://patchwork.kernel.org/patch/11132381/, > finally got around to give this a real try. > > The main purpose of this series is to upstream the dts change and the binding > document, but I wanted to see how far I could probe the GPU, to check that the > binding is indeed correct. The rest of the patches are RFC/work-in-progress, but > I think some of them could already be picked up. > > So this is tested on MT8183 with a chromeos-4.19 kernel, and a ton of > backports to get the latest panfrost driver (I should probably try on > linux-next at some point but this was the path of least resistance). > > I tested it as a module as it's more challenging (originally probing would > work built-in, on boot, but not as a module, as I didn't have the power > domain changes, and all power domains are on by default during boot). > > Probing logs looks like this, currently: > [ 221.867726] panfrost 13040000.gpu: clock rate = 511999970 > [ 221.867929] panfrost 13040000.gpu: Linked as a consumer to regulator.14 > [ 221.868600] panfrost 13040000.gpu: Linked as a consumer to regulator.31 > [ 221.870586] panfrost 13040000.gpu: Linked as a consumer to genpd:0:13040000.gpu > [ 221.871492] panfrost 13040000.gpu: Linked as a consumer to genpd:1:13040000.gpu > [ 221.871866] panfrost 13040000.gpu: Linked as a consumer to genpd:2:13040000.gpu > [ 221.872427] panfrost 13040000.gpu: mali-g72 id 0x6221 major 0x0 minor 0x3 status 0x0 > [ 221.872439] panfrost 13040000.gpu: features: 00000000,13de77ff, issues: 00000000,00000400 > [ 221.872445] panfrost 13040000.gpu: Features: L2:0x07120206 Shader:0x00000000 Tiler:0x00000809 Mem:0x1 MMU:0x00002830 AS:0xff JS:0x7 > [ 221.872449] panfrost 13040000.gpu: shader_present=0x7 l2_present=0x1 > [ 221.873526] panfrost 13040000.gpu: error powering up gpu stack > [ 221.878088] [drm] Initialized panfrost 1.1.0 20180908 for 13040000.gpu on minor 2 > [ 221.940817] panfrost 13040000.gpu: error powering up gpu stack > [ 222.018233] panfrost 13040000.gpu: error powering up gpu stack > (repeated) > > So the GPU is probed, but there's an issue when powering up the STACK, not > quite sure why, I'll try to have a deeper look, at some point. Just as a follow-up to that one. stack_present=0x00000007 on my GPU. However, the ARM-provided driver I use on this platform doesn't have CONFIG_MALI_CORESTACK enabled so the "stack" is never turned on. https://chromium.googlesource.com/chromiumos/third_party/kernel/+/chromeos-4.19/drivers/gpu/arm/midgard/Kconfig#101 . So possibly this does not need to be done on Bifrost GPUs (and the error should be harmless). > Thanks! > > Nicolas > > v2: > - Use sram instead of mali_sram as SRAM supply name. > - Rename mali@ to gpu@. > - Add dt-bindings changes > - Stacking patches after the device tree change that allow basic > probing (still incomplete and broken). > > Nicolas Boichat (7): > dt-bindings: gpu: mali-bifrost: Add Mediatek MT8183 > arm64: dts: mt8183: Add node for the Mali GPU > drm/panfrost: Improve error reporting in panfrost_gpu_power_on > drm/panfrost: Add support for a second regulator for the GPU > drm/panfrost: Add support for multiple power domain support > RFC: drm/panfrost: Add bifrost compatible string > RFC: drm/panfrost: devfreq: Add support for 2 regulators > > .../bindings/gpu/arm,mali-bifrost.yaml | 20 ++++ > arch/arm64/boot/dts/mediatek/mt8183-evb.dts | 7 ++ > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 104 +++++++++++++++++ > drivers/gpu/drm/panfrost/panfrost_devfreq.c | 18 +++ > drivers/gpu/drm/panfrost/panfrost_device.c | 108 ++++++++++++++++-- > drivers/gpu/drm/panfrost/panfrost_device.h | 7 ++ > drivers/gpu/drm/panfrost/panfrost_drv.c | 1 + > drivers/gpu/drm/panfrost/panfrost_gpu.c | 15 ++- > 8 files changed, 267 insertions(+), 13 deletions(-) > > -- > 2.24.1.735.g03f4e72817-goog >