Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1775704ybl; Thu, 9 Jan 2020 01:13:11 -0800 (PST) X-Received: by 2002:a05:6830:1d7a:: with SMTP id l26mr7429582oti.138.1578560951191; Thu, 09 Jan 2020 01:09:11 -0800 (PST) X-Google-Smtp-Source: APXvYqzGWHC7JKfvuS3ldjL1r9a4YdKk4VFiA02BVdbwSImKXR8PDM7079BoPGKo0KLdOJ1AKTmZ X-Received: by 2002:a05:6830:1d7a:: with SMTP id l26mr7429487oti.138.1578560949885; Thu, 09 Jan 2020 01:09:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578560949; cv=none; d=google.com; s=arc-20160816; b=tEF7tuLC85Js+7qNSvxGsF8ATGWQCNvDoNnOK0lM9mVc+Cl3i5fsQ/KaTAsvVqLxlN CNdR6hiaocvrkY5b1en7/y+ExqyVggend0jhFiqV4t33RYMXlCeeOfinnF/M6ZMoO5qW W88PolP7N5nBz+3u5eOvD2YFoR22t7GTax/A3D1zm9fAuAJXpba9XjuOWuqpXhpMhzdD aM366eWy23C/vI/bLwOjIAnx2Cvq6JP0m3YAczUqc5zolNCrEr2S5PaSPDkXenbarP1r q3P2DiNgGMlbfec6ulW3LjKSstbiC7JMkdf73DW2Ncq+U66oEJuF5Tdj8LPC6k7KwShZ 7dgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Kvdfo5p7rGw6kjZkh9zkMAcibuMahAFzCWtpfQCY54I=; b=iPGEP0DtVtZ1AbNUoZRD1z8CJkaic/R1uW3C3WBEsUYmDfNFCedHOoEhF5iNlMoMFX Y5kGwHw3fkSqGLhwTssdXN1FLcr361iOL7SSm816JwGE0Sk+9VZ8ORfbakf8cedd/oqo 9k6lDfnQjZOYMpx5ZvmKSfpkfLuSaytpG32kFuVN1p4NSlljLBCCOIeY39MQxkgVcqAG 4oCRmIZx6Qntuv1wzIDj8cxhBWPwUyr590FVs3Odw4Z9gxmX+c5slkJqZnQ617AI67lU ztMPO628yO2AYX6EG4xucGyixMWQHX5jLuXR42NKIoEHoIpuF2Nei1fgw8+thoOWabEu Bfdg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q7ic9Z2e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si3221636oic.263.2020.01.09.01.08.57; Thu, 09 Jan 2020 01:09:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Q7ic9Z2e; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729167AbgAIJHA (ORCPT + 99 others); Thu, 9 Jan 2020 04:07:00 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:51137 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729130AbgAIJG7 (ORCPT ); Thu, 9 Jan 2020 04:06:59 -0500 Received: by mail-wm1-f67.google.com with SMTP id a5so1996723wmb.0 for ; Thu, 09 Jan 2020 01:06:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Kvdfo5p7rGw6kjZkh9zkMAcibuMahAFzCWtpfQCY54I=; b=Q7ic9Z2e9nve5H4Tkmw1sEa3snMzPEKbOpJC+93YR6BjyzubO6YRlLXrTNYQmv/Mfx KUrQKWtbAx3s/XgHEJwYz3q1lKgoy04GLeGJcoC0XfwozQuHczFKZyW6TMOS6yULtXol cA+hqjdYmRUAdM0aTcRIOpiSq+GllGzA+v8iKE54owjsx8hIiVHNU2HTWcECOc+je4PB CTm3bj7Xe5tJL/Bbp9OM0qffAd3e1ciM93jVuAwR48NDAGlR7rY9c5N6AUJNk9jnviN0 /IaBe3F0gNYnU/rrJShNwOCK9/JM3l7tI/jha5wCzPdj1lzDtWpVcaxi8oHvjG6L584Y 1cyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Kvdfo5p7rGw6kjZkh9zkMAcibuMahAFzCWtpfQCY54I=; b=D+F4EryYjnFVwS19g9Od4knYvNRv6jfEUUzsWHQrKJ7C6jCm16VhwQpK+lZ5usGBVi qO7Tu19PN0sprUqS1HSijDlE2zhu14zTY8arl17yB08tGMO9YLCDkD3bm5aEnLGNmCMO vAHTj4VZNTuRUPe2/gjYQx5KpkPiBbMRGZc/0KkRScXJ14D9k3c25TX/SWJqi1L90DIt 9tSLzxy/l61sqmjGMP1jE1m/eFaMU3nufIZ0tL5MsbIVJ4/hA2uOPPmg0FzATixiTMUm cGmaBz40PW3RJJlVkEmzyWmDiJ7ui7HP29SVKgcIuO05s2dXz53ZRvOTvjMYZj1T1Dmd YrHQ== X-Gm-Message-State: APjAAAXHMXvuPJlL8a6xBkys8fML4EgfPKaQAe4YB6uYeb5Ly4Fxaozv TwyKYyRAC6LAOkrZkiUvfoE= X-Received: by 2002:a1c:f009:: with SMTP id a9mr3393989wmb.73.1578560817414; Thu, 09 Jan 2020 01:06:57 -0800 (PST) Received: from wambui.zuku.co.ke ([197.237.61.225]) by smtp.googlemail.com with ESMTPSA id i8sm8004734wro.47.2020.01.09.01.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2020 01:06:56 -0800 (PST) From: Wambui Karuga To: jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch Cc: sean@poorly.run, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/5] drm/i915: conversion to new logging macros in i915/intel_csr.c Date: Thu, 9 Jan 2020 12:06:43 +0300 Message-Id: <0ea8e0f39013a73ed66052893a8f8abf8cc23ba6.1578560355.git.wambui.karugax@gmail.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Replace the use of printk and struct device based logging macros with the new struct drm_device based logging macros in i915/intel_csr.c Signed-off-by: Wambui Karuga --- drivers/gpu/drm/i915/intel_csr.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index 09870a31b4f0..85e41db7dc0e 100644 --- a/drivers/gpu/drm/i915/intel_csr.c +++ b/drivers/gpu/drm/i915/intel_csr.c @@ -298,12 +298,14 @@ void intel_csr_load_program(struct drm_i915_private *dev_priv) u32 i, fw_size; if (!HAS_CSR(dev_priv)) { - DRM_ERROR("No CSR support available for this platform\n"); + drm_err(&dev_priv->drm, + "No CSR support available for this platform\n"); return; } if (!dev_priv->csr.dmc_payload) { - DRM_ERROR("Tried to program CSR with empty payload\n"); + drm_err(&dev_priv->drm, + "Tried to program CSR with empty payload\n"); return; } @@ -636,16 +638,16 @@ static void csr_load_work_fn(struct work_struct *work) intel_csr_load_program(dev_priv); intel_csr_runtime_pm_put(dev_priv); - DRM_INFO("Finished loading DMC firmware %s (v%u.%u)\n", - dev_priv->csr.fw_path, - CSR_VERSION_MAJOR(csr->version), + drm_info(&dev_priv->drm, + "Finished loading DMC firmware %s (v%u.%u)\n", + dev_priv->csr.fw_path, CSR_VERSION_MAJOR(csr->version), CSR_VERSION_MINOR(csr->version)); } else { - dev_notice(dev_priv->drm.dev, + drm_notice(&dev_priv->drm, "Failed to load DMC firmware %s." " Disabling runtime power management.\n", csr->fw_path); - dev_notice(dev_priv->drm.dev, "DMC firmware homepage: %s", + drm_notice(&dev_priv->drm, "DMC firmware homepage: %s", INTEL_UC_FIRMWARE_URL); } @@ -712,7 +714,8 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv) if (i915_modparams.dmc_firmware_path) { if (strlen(i915_modparams.dmc_firmware_path) == 0) { csr->fw_path = NULL; - DRM_INFO("Disabling CSR firmware and runtime PM\n"); + drm_info(&dev_priv->drm, + "Disabling CSR firmware and runtime PM\n"); return; } @@ -722,11 +725,12 @@ void intel_csr_ucode_init(struct drm_i915_private *dev_priv) } if (csr->fw_path == NULL) { - DRM_DEBUG_KMS("No known CSR firmware for platform, disabling runtime PM\n"); + drm_dbg_kms(&dev_priv->drm, + "No known CSR firmware for platform, disabling runtime PM\n"); return; } - DRM_DEBUG_KMS("Loading %s\n", csr->fw_path); + drm_dbg_kms(&dev_priv->drm, "Loading %s\n", csr->fw_path); schedule_work(&dev_priv->csr.work); } -- 2.24.1