Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp1807523ybl; Thu, 9 Jan 2020 01:55:16 -0800 (PST) X-Google-Smtp-Source: APXvYqwTOrQtJOFn7AfXAT+LUutJRwmKkL5pRH3F0HPBZDrqx391pktAnBR7s59S/Mt9Bl4/CBgx X-Received: by 2002:a05:6830:1141:: with SMTP id x1mr8028803otq.120.1578563715944; Thu, 09 Jan 2020 01:55:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1578563715; cv=none; d=google.com; s=arc-20160816; b=aTDixAda03KlVnT71LnQp5c/RplITkIfV2tJbGZHSAJre/qEUctEUrcHcYDuanoU97 gDid41XNXX6E0P7cjFHo6tYCBUU9N+zgeZGg5rjJg4XgHAwOmUGnUNEHKHl1G3UVysZ6 /XhBrSk8700i4ypTKuWnjA8vL9Z1ULPWHqZnmtm4v0qVa3O6K6q/LUdQ4OiUhn+uZZwA fUCnnBCMSfMrGp/dlRAgdTpN23lMJU6oxSiL5EaXTxr8rs75ZJpySdjzQLarZ5L/R0kR mXb7+myMBi4wvClnP5CsCJ3VkoigXPk1O3Ayl0hvflruVhXR7AAdvHkR3Y3lF995cUCY YhAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:content-disposition :mime-version:message-id:subject:cc:to:from:date:dkim-signature; bh=reRhFkkSbTi+HYG5loXVudYrpRXMMINGsWh+qsIUU+o=; b=iaflf+q1iBBSkxGgQ9jadWx2nyAgdvgpV1wQvMR9FYNzdAqi6JEB2WEyb7O084gqDu 9xvGYgnDQFAHagc11jOz6fuZoSyYMlGizEWvLPXqsRD4bRZYENknUpuG37VxjG7P2rt6 g05rPcwZynCckDC+lS/ESvsIItlEKufClx/FFcMhhvHixQm0HtbNVQFoUsajRHwqQyIM VSGRMZRYEQBoDyyccqMV/oSAL8QcWczRzTzaMxZIIbWFmSSJOOpnU43KFnXup30GkhNo R1NbHZs7Y9PYUbUmlO50PHmHm63N9uueCceh9ZxuBTp/e2mvAc30sh1XA1snPpGWUTCJ EaYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ELh/2WFC"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 19si3418522oiq.128.2020.01.09.01.55.03; Thu, 09 Jan 2020 01:55:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="ELh/2WFC"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729877AbgAIJyJ (ORCPT + 99 others); Thu, 9 Jan 2020 04:54:09 -0500 Received: from mail-wm1-f66.google.com ([209.85.128.66]:37929 "EHLO mail-wm1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729750AbgAIJyI (ORCPT ); Thu, 9 Jan 2020 04:54:08 -0500 Received: by mail-wm1-f66.google.com with SMTP id u2so2081118wmc.3; Thu, 09 Jan 2020 01:54:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=reRhFkkSbTi+HYG5loXVudYrpRXMMINGsWh+qsIUU+o=; b=ELh/2WFC6eCc9BY28TjxMy8nG9S+SxI8k5HCg9J6G7oBwvmBQ6cnSZhFuA5IsC+5RM /wKZPOkC1JBDBf0aD2NgGJ5oMGfxlaDAUc+P1yIUP53vwLAuR9Kac62vcXb6yqQ5BVqY nFtB0o/5QDVmRW5orLOfAt73BsUOjMWHjD6eJJlF+Lr0z1piYOBwUZijAaYoK8/TBQSZ aHhKhW5PvAmc4LwEeGAl7lJ1QTjR2TqiK0hAR662vpxTfLVFWz8Ylno/esnuSljUaSze Z1IbeJTSD1TE2sA3YG3dwfIFz0tjiosJXIE6vEynxSqsdBPq0NcF7CeW6Kl4jkUAneRa 3oSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=reRhFkkSbTi+HYG5loXVudYrpRXMMINGsWh+qsIUU+o=; b=pu1N+Wo5u60q52jT6T1sCq98OusCnF16VTHMwtb+ORv5CtIwp/8PKRj3xKBDQmdN74 sQOusqxdDabEfYt28tVjMMXpzcGImEDtJU/+XqPHVXxEPPtFWEWHS5XKFHCMv8pe/MoA j5gEWfKpmSkH05uU4KbsSnGN0SIMq0f01SOBYo28Bcy0qRsl2VmcRtTl+nbx2vUijelH kI4518vlTYNPEygM38BdSsNRXAluMuyJj8x7IoadYDzGEDW9UVsMDlBcaUHyMv/wA4vY 5vhAmTrUo1XlGoEABaEC7KRPY2P2exSCr2Yx9gsQDQ/hwi04cTbWWvajVFhiOh5IExtX uD1A== X-Gm-Message-State: APjAAAXrnVWVcTu7KdJkTSbFUxumK3sJvGZDxz3tAkC0WJRZiWlLGpsO q7rinH8uYBwtpemjAK0ohEo= X-Received: by 2002:a1c:ddc5:: with SMTP id u188mr3566955wmg.83.1578563646048; Thu, 09 Jan 2020 01:54:06 -0800 (PST) Received: from Red ([2a01:cb1d:147:7200:2e56:dcff:fed2:c6d6]) by smtp.googlemail.com with ESMTPSA id g21sm7997492wrb.48.2020.01.09.01.54.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Jan 2020 01:54:05 -0800 (PST) Date: Thu, 9 Jan 2020 10:54:03 +0100 From: Corentin Labbe To: alexandre.torgue@st.com, mripard@kernel.org, wens@csie.org, kishon@ti.com, lgirdwood@gmail.com, broonie@kernel.org, axboe@kernel.dk Cc: linux-ide@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com Subject: ata: sunxi: Regression due to 5253fe05bb47 ("phy: core: Add consumer device link support") Message-ID: <20200109095403.GA26453@Red> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello On next-20200108 (at least), the sunxi_ahci fail to probe with: 3.025955] 8<--- cut here --- [ 3.029012] Unable to handle kernel NULL pointer dereference at virtual address 00000071 [ 3.037115] pgd = (ptrval) [ 3.039819] [00000071] *pgd=00000000 [ 3.043408] Internal error: Oops: 5 [#1] SMP ARM [ 3.048019] Modules linked in: [ 3.051078] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.5.0-rc1-00004-g5253fe05bb47 #24 [ 3.059067] Hardware name: Allwinner sun7i (A20) Family [ 3.064297] PC is at device_link_add+0x68/0x4c8 [ 3.068824] LR is at device_link_add+0x68/0x4c8 [ 3.073348] pc : [] lr : [] psr: 60000013 [ 3.079605] sp : ef04dd68 ip : 60000013 fp : 00000007 [ 3.084822] r10: 00000000 r9 : eea8a740 r8 : ef0a5c10 [ 3.090039] r7 : ef0a5c10 r6 : ffffffed r5 : 00000001 r4 : 00000001 [ 3.096556] r3 : ef060000 r2 : 00000000 r1 : 00000000 r0 : c0a4e588 [ 3.103076] Flags: nZCv IRQs on FIQs on Mode SVC_32 ISA ARM Segment none [ 3.110201] Control: 10c5387d Table: 4000406a DAC: 00000051 [ 3.115937] Process swapper/0 (pid: 1, stack limit = 0x(ptrval)) [ 3.121936] Stack: (0xef04dd68 to 0xef04e000) [ 3.126292] dd60: 000005e4 c02141e4 ef7bf970 ffffffed ef0a5c10 eea8a7c0 [ 3.134461] dd80: 00000000 ef0a5c10 eea8a740 00000000 00000007 c03acaec 00000000 ee8a3700 [ 3.142630] dda0: ef7bf970 ee8a3700 ef0a5c10 c04d2804 ef04c000 ef0a5c10 ef0a5c00 ee8a3700 [ 3.150799] ddc0: 00000000 00000000 00000000 c04d2e20 00000001 c029b2bc c0a4f9fc 00000000 [ 3.158969] dde0: ef0b3630 c029aec8 00000000 5aef773a eea8c478 ef0a5c10 00000000 ef0a5c00 [ 3.167138] de00: 00000000 00000000 c0a4f9fc 00000000 00000007 c04cedfc ef0a5c10 00000000 [ 3.175307] de20: c0a4f9fc c047d6b8 c0aa51dc ef0a5c10 c0aa51e0 00000000 00000000 c047b894 [ 3.183476] de40: ef0a5c10 c0a4f9fc c0a4f9fc c047be38 c093d834 c09004a8 000000d8 c047bb84 [ 3.191646] de60: 000000d8 c05a37c0 c0760330 ef0a5c10 00000000 c0a4f9fc c047be38 c093d834 [ 3.199815] de80: c09004a8 000000d8 00000007 c047be30 00000000 c0a4f9fc ef0a5c10 c047be90 [ 3.207984] dea0: ef0fc634 ef04c000 c0a4f9fc c0479c68 c09004a8 ef01e458 ef0fc634 5aef773a [ 3.216152] dec0: c0a4df18 c0a4f9fc eea8a300 c0a4df18 00000000 c047acb0 c083ac48 c0aa5870 [ 3.224321] dee0: c0a4f9fc c0a4f9fc c091eff4 00000000 ffffe000 c047c6fc c0a6fc40 c091eff4 [ 3.232491] df00: 00000000 c01026e8 effffe6e c013c488 00000000 c08b9d00 c0845f90 00000000 [ 3.240660] df20: 00000006 00000006 c07ff574 00000000 c0809bd8 c07ff5e8 00000000 effffe67 [ 3.248829] df40: effffe6a 5aef773a 00000000 00000006 c0a6fc40 5aef773a c093d850 c0952220 [ 3.256998] df60: c0a6fc40 c0a6fc40 c093d854 c0900ed0 00000006 00000006 00000000 c09004a8 [ 3.265167] df80: 00000000 00000000 c06f7a9c 00000000 00000000 00000000 00000000 00000000 [ 3.273335] dfa0: 00000000 c06f7aa4 00000000 c01010e8 00000000 00000000 00000000 00000000 [ 3.281504] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 3.289672] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 00000000 00000000 [ 3.297858] [] (device_link_add) from [] (devm_of_phy_get+0x64/0xb0) [ 3.305947] [] (devm_of_phy_get) from [] (ahci_platform_get_phy+0x28/0xd0) [ 3.314552] [] (ahci_platform_get_phy) from [] (ahci_platform_get_resources+0x234/0x448) [ 3.324372] [] (ahci_platform_get_resources) from [] (ahci_sunxi_probe+0x10/0xa8) [ 3.333585] [] (ahci_sunxi_probe) from [] (platform_drv_probe+0x48/0x98) [ 3.342017] [] (platform_drv_probe) from [] (really_probe+0x1e0/0x348) [ 3.350267] [] (really_probe) from [] (driver_probe_device+0x60/0x16c) [ 3.358525] [] (driver_probe_device) from [] (device_driver_attach+0x58/0x60) [ 3.367390] [] (device_driver_attach) from [] (__driver_attach+0x58/0xcc) [ 3.375908] [] (__driver_attach) from [] (bus_for_each_dev+0x78/0xb8) [ 3.384080] [] (bus_for_each_dev) from [] (bus_add_driver+0x1b4/0x1d4) [ 3.392337] [] (bus_add_driver) from [] (driver_register+0x74/0x108) [ 3.400423] [] (driver_register) from [] (do_one_initcall+0x78/0x1d4) [ 3.408598] [] (do_one_initcall) from [] (kernel_init_freeable+0x138/0x1d4) [ 3.417291] [] (kernel_init_freeable) from [] (kernel_init+0x8/0x110) [ 3.425462] [] (kernel_init) from [] (ret_from_fork+0x14/0x2c) [ 3.433019] Exception stack(0xef04dfb0 to 0xef04dff8) [ 3.438065] dfa0: 00000000 00000000 00000000 00000000 [ 3.446234] dfc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 [ 3.454400] dfe0: 00000000 00000000 00000000 00000000 00000013 00000000 [ 3.461010] Code: e59f0464 03844040 eb0a0b7b eb004882 (e5d63084) [ 3.467153] ---[ end trace 0dbbaca7a7b65a4b ]--- The problem was bisected to 5253fe05bb47a2402f471d76078b3dcc66442d6c ("phy: core: Add consumer device link support") Reverting this patch fix the problem Regards