Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH next] KVM: Fix debugfs_simple_attr.cocci warnings
To:     Nicolai Stange <nstange@suse.de>
Cc:     Chen Wandun <chenwandun@huawei.com>, rkrcmar@redhat.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
References: <1577151674-67949-1-git-send-email-chenwandun@huawei.com>
 <4f193d99-ee9b-5217-c2f6-3a8a96bf1534@redhat.com> <87h816nsv9.fsf@suse.de>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <5d75e57a-4d04-e6b9-1bbd-a01072bfa6b1@redhat.com>
Date:   Thu, 9 Jan 2020 10:17:57 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.1.1
MIME-Version: 1.0
In-Reply-To: <87h816nsv9.fsf@suse.de>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 08/01/20 11:29, Nicolai Stange wrote:
> 
> How about introducing a
>   #define debugfs_create_attr debugfs_create_file_unsafe
> instead to make those
> s/DEFINE_SIMPLE_ATTRIBUTE/DEFINE_DEBUGFS_ATTRIBUTE/
> patches look less scary?

I agree that could be worthwhile.  My main complaint is the "scariness
factor" of the patches that convert DEFINE_SIMPLE_ATTRIBUTE to
DEFINE_DEBUGFS_ATTRIBUTE, and this change would alleviate that problem.

Thanks,

Paolo